Skip to content

Commit d1a4ac6

Browse files
morganchen12morganchen12
committed
do nothing
1 parent 2eb19d6 commit d1a4ac6

File tree

6 files changed

+286
-84
lines changed

6 files changed

+286
-84
lines changed

‎functions/src/github.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,9 +167,9 @@ export class GitHubClient {
167167
* Blocks the given user on behalf of the specified organization.
168168
*/
169169
blockFromOrg(org: string, username: string) {
170-
return this.api.request('PUT /orgs/' + org + '/blocks/' + username, {
170+
return this.api.request("PUT /orgs/" + org + "/blocks/" + username, {
171171
org: org,
172-
username: username,
172+
username: username
173173
});
174174
}
175175

‎functions/src/issues.ts‎

Lines changed: 22 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -244,61 +244,33 @@ export class IssueHandler {
244244
// Filter spam from b/378634578. This can be removed in the future.
245245
const spamWords = [
246246
"pemain",
247-
"wallet wallet", // seems to be in most crypto issues
248-
"minecraft",
249247
"paybis",
250-
"blockchain",
251-
"official contact number",
252-
"phantom wallet",
253-
"defi wallet",
254-
"dogecoin",
255-
"crypto.com",
256-
"moonpay",
257-
"coinmama",
258-
"daftar",
259-
"activation key",
260248
"cracked version",
261-
"download now",
262249
"xnxx",
263250
"sex@videos",
264-
"freeplayer.one",
265-
"movies7to.lol",
266251
"inatogel",
267-
'rel="nofollow"',
268252
"ao vivo",
269-
"click here to watch",
270-
"diretta streaming",
271-
"rijeka",
272-
"social media x",
273-
"live streams free",
253+
["cracktel.com"],
254+
["therealhax.net"],
255+
["## [", "download", "/dl/"],
256+
["changelly", "crypto"],
257+
["telegram leak"],
258+
["call +1", "contact"],
259+
["safepal", "support"],
260+
["recover", "account", "1-866-"],
261+
["1-866-409-9289"],
262+
["robinhood", "support"],
263+
["blockchain", "support"],
264+
["blogspot.com"],
265+
["wordpress.com/wp-content"],
274266
["situs", "slot"],
275-
["premier league", "live"],
276-
["live streams", "rugby"],
277-
["pro league", "tv"],
278-
["diretta", "le"],
279-
["en direct", "tv"],
280-
["direct streaming", "match", "tv"],
281267
["jogos", "direto"],
282268
["jogos", "directo"],
283-
["video viral", "x twitter"],
284-
["video", "viral", "trending now"],
285-
["autodesk", "login"],
286-
["films", "hd", "4k"],
287-
["free streaming", "tv shows"],
288-
["nfl", "live streams"],
289-
["free games", "unblocked"],
290-
["wallet", "support"],
291-
["download", "crack"],
292-
["download", "serial key"],
293-
["sex", "videos"]
269+
["video viral", "x twitter"]
294270
];
295271
const issueContent = ` ${issue.title} ${issue.body || ""} `.toLowerCase();
296272
// Scope spam filtering to affected repos only.
297-
const isAffectedRepo =
298-
org == "firebase" &&
299-
(name == "flutterfire" ||
300-
name == "quickstart-android" ||
301-
name == "quickstart-ios");
273+
const isAffectedRepo = org == "firebase";
302274
const isSpam =
303275
isAffectedRepo &&
304276
spamWords.find(wordOrArray => {
@@ -313,18 +285,13 @@ export class IssueHandler {
313285
if (isSpam) {
314286
// Discard other actions, wipe and lock the issue, and block
315287
// the offending user.
316-
const reason = `Issue is believed to be spam: ${issue.title}`
317-
return [
318-
new types.GitHubSpamAction(
319-
org, name, issue.number, reason
320-
),
321-
new types.GitHubBlockAction(
322-
org, issue.user.login
323-
),
324-
new types.GitHubLockAction(
325-
org, name, issue.number
326-
)
327-
];
288+
const reason = `Issue is believed to be spam: ${issue.title}`;
289+
// Disabled for now. Can be re-enabled if spam reoccurs in the future.
290+
// return [
291+
// new types.GitHubSpamAction(org, name, issue.number, reason),
292+
// new types.GitHubBlockAction(org, issue.user.login),
293+
// new types.GitHubLockAction(org, name, issue.number)
294+
// ];
328295
}
329296

330297
// Check if it matches the template. This feature is implicitly enabled by

‎functions/src/test/mock_data/stale_issue.json‎

Lines changed: 98 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,98 @@
1+
{
2+
"url": "https://api.github.com/repos/firebase/firebase-ios-sdk/issues/14624",
3+
"repository_url": "https://api.github.com/repos/firebase/firebase-ios-sdk",
4+
"labels_url": "https://api.github.com/repos/firebase/firebase-ios-sdk/issues/14624/labels{/name}",
5+
"comments_url": "https://api.github.com/repos/firebase/firebase-ios-sdk/issues/14624/comments",
6+
"events_url": "https://api.github.com/repos/firebase/firebase-ios-sdk/issues/14624/events",
7+
"html_url": "https://github.com/firebase/firebase-ios-sdk/issues/14624",
8+
"id": 2955590098,
9+
"node_id": "I_kwDOBU6LVM6wKrnS",
10+
"number": 14624,
11+
"title": "Unable to add Firebase through SPM in xcode 16",
12+
"user": {
13+
"login": "shilpa12233",
14+
"id": 139213207,
15+
"node_id": "U_kgDOCEw5lw",
16+
"avatar_url": "https://avatars.githubusercontent.com/u/139213207?v=4",
17+
"gravatar_id": "",
18+
"url": "https://api.github.com/users/shilpa12233",
19+
"html_url": "https://github.com/shilpa12233",
20+
"followers_url": "https://api.github.com/users/shilpa12233/followers",
21+
"following_url": "https://api.github.com/users/shilpa12233/following{/other_user}",
22+
"gists_url": "https://api.github.com/users/shilpa12233/gists{/gist_id}",
23+
"starred_url": "https://api.github.com/users/shilpa12233/starred{/owner}{/repo}",
24+
"subscriptions_url": "https://api.github.com/users/shilpa12233/subscriptions",
25+
"organizations_url": "https://api.github.com/users/shilpa12233/orgs",
26+
"repos_url": "https://api.github.com/users/shilpa12233/repos",
27+
"events_url": "https://api.github.com/users/shilpa12233/events{/privacy}",
28+
"received_events_url": "https://api.github.com/users/shilpa12233/received_events",
29+
"type": "User",
30+
"user_view_type": "public",
31+
"site_admin": false
32+
},
33+
"labels": [
34+
{
35+
"id": 1290843477,
36+
"node_id": "MDU6TGFiZWwxMjkwODQzNDc3",
37+
"url": "https://api.github.com/repos/firebase/firebase-ios-sdk/labels/needs-info",
38+
"name": "needs-info",
39+
"color": "d93f0b",
40+
"default": false,
41+
"description": ""
42+
},
43+
{
44+
"id": 1290843946,
45+
"node_id": "MDU6TGFiZWwxMjkwODQzOTQ2",
46+
"url": "https://api.github.com/repos/firebase/firebase-ios-sdk/labels/no-recent-activity",
47+
"name": "no-recent-activity",
48+
"color": "eaeaea",
49+
"default": false,
50+
"description": ""
51+
},
52+
{
53+
"id": 2273899029,
54+
"node_id": "MDU6TGFiZWwyMjczODk5MDI5",
55+
"url": "https://api.github.com/repos/firebase/firebase-ios-sdk/labels/Swift%20Package%20Manager",
56+
"name": "Swift Package Manager",
57+
"color": "eaa364",
58+
"default": false,
59+
"description": ""
60+
}
61+
],
62+
"state": "open",
63+
"locked": false,
64+
"assignee": null,
65+
"assignees": [
66+
67+
],
68+
"milestone": null,
69+
"comments": 3,
70+
"created_at": "2025-03-28T09:52:25Z",
71+
"updated_at": "2025-04-04T01:05:31Z",
72+
"closed_at": null,
73+
"author_association": "NONE",
74+
"type": null,
75+
"active_lock_reason": null,
76+
"sub_issues_summary": {
77+
"total": 0,
78+
"completed": 0,
79+
"percent_completed": 0
80+
},
81+
"body": "### Description\n\nI am trying to add firebase through SPM , swift 5 , with firebase latest version 11.10.0, but it's giving a lot of errors.\n\n<img width=\"353\" alt=\"Image\" src=\"https://github.com/user-attachments/assets/54b446aa-0a44-4e59-b910-36cd207f23a3\" />\n\n@paulb777 , can you please suggest any solution.\n\n### Reproducing the issue\n\n_No response_\n\n### Firebase SDK Version\n\n11.10.0\n\n### Xcode Version\n\n16\n\n### Installation Method\n\nSwift Package Manager\n\n### Firebase Product(s)\n\nAnalytics, All\n\n### Targeted Platforms\n\niOS\n\n### Relevant Log Output\n\n```shell\n\n```\n\n### If using Swift Package Manager, the project's Package.resolved\n\n<!--- Look below for instructions on how to share your Package.resolved. --->\n\n<details>\n<summary>Expand <code>Package.resolved</code> snippet</summary>\n<br>\n\n```json\n\nReplace this line with the contents of your Package.resolved.\n\n```\n\n</details>\n\n\n### If using CocoaPods, the project's Podfile.lock\n\n<!--- Look below for instructions on how to share your Podfile.lock. --->\n\n<details>\n<summary>Expand <code>Podfile.lock</code> snippet</summary>\n<br>\n\n```yml\n\nReplace this line with the contents of your Podfile.lock!\n\n```\n\n</details>\n",
82+
"closed_by": null,
83+
"reactions": {
84+
"url": "https://api.github.com/repos/firebase/firebase-ios-sdk/issues/14624/reactions",
85+
"total_count": 0,
86+
"+1": 0,
87+
"-1": 0,
88+
"laugh": 0,
89+
"hooray": 0,
90+
"confused": 0,
91+
"heart": 0,
92+
"rocket": 0,
93+
"eyes": 0
94+
},
95+
"timeline_url": "https://api.github.com/repos/firebase/firebase-ios-sdk/issues/14624/timeline",
96+
"performed_via_github_app": null,
97+
"state_reason": null
98+
}

‎functions/src/test/mock_data/stale_issue_comments.json‎

Lines changed: 137 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,137 @@
1+
[
2+
{
3+
"url": "https://api.github.com/repos/firebase/firebase-ios-sdk/issues/comments/2760764598",
4+
"html_url": "https://github.com/firebase/firebase-ios-sdk/issues/14624#issuecomment-2760764598",
5+
"issue_url": "https://api.github.com/repos/firebase/firebase-ios-sdk/issues/14624",
6+
"id": 2760764598,
7+
"node_id": "IC_kwDOBU6LVM6kjey2",
8+
"user": {
9+
"login": "google-oss-bot",
10+
"id": 26440463,
11+
"node_id": "MDQ6VXNlcjI2NDQwNDYz",
12+
"avatar_url": "https://avatars.githubusercontent.com/u/26440463?v=4",
13+
"gravatar_id": "",
14+
"url": "https://api.github.com/users/google-oss-bot",
15+
"html_url": "https://github.com/google-oss-bot",
16+
"followers_url": "https://api.github.com/users/google-oss-bot/followers",
17+
"following_url": "https://api.github.com/users/google-oss-bot/following{/other_user}",
18+
"gists_url": "https://api.github.com/users/google-oss-bot/gists{/gist_id}",
19+
"starred_url": "https://api.github.com/users/google-oss-bot/starred{/owner}{/repo}",
20+
"subscriptions_url": "https://api.github.com/users/google-oss-bot/subscriptions",
21+
"organizations_url": "https://api.github.com/users/google-oss-bot/orgs",
22+
"repos_url": "https://api.github.com/users/google-oss-bot/repos",
23+
"events_url": "https://api.github.com/users/google-oss-bot/events{/privacy}",
24+
"received_events_url": "https://api.github.com/users/google-oss-bot/received_events",
25+
"type": "User",
26+
"user_view_type": "public",
27+
"site_admin": false
28+
},
29+
"created_at": "2025-03-28T09:52:43Z",
30+
"updated_at": "2025-03-28T09:52:43Z",
31+
"author_association": "NONE",
32+
"body": "I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.",
33+
"reactions": {
34+
"url": "https://api.github.com/repos/firebase/firebase-ios-sdk/issues/comments/2760764598/reactions",
35+
"total_count": 0,
36+
"+1": 0,
37+
"-1": 0,
38+
"laugh": 0,
39+
"hooray": 0,
40+
"confused": 0,
41+
"heart": 0,
42+
"rocket": 0,
43+
"eyes": 0
44+
},
45+
"performed_via_github_app": null
46+
},
47+
{
48+
"url": "https://api.github.com/repos/firebase/firebase-ios-sdk/issues/comments/2761541364",
49+
"html_url": "https://github.com/firebase/firebase-ios-sdk/issues/14624#issuecomment-2761541364",
50+
"issue_url": "https://api.github.com/repos/firebase/firebase-ios-sdk/issues/14624",
51+
"id": 2761541364,
52+
"node_id": "IC_kwDOBU6LVM6kmcb0",
53+
"user": {
54+
"login": "paulb777",
55+
"id": 73870,
56+
"node_id": "MDQ6VXNlcjczODcw",
57+
"avatar_url": "https://avatars.githubusercontent.com/u/73870?v=4",
58+
"gravatar_id": "",
59+
"url": "https://api.github.com/users/paulb777",
60+
"html_url": "https://github.com/paulb777",
61+
"followers_url": "https://api.github.com/users/paulb777/followers",
62+
"following_url": "https://api.github.com/users/paulb777/following{/other_user}",
63+
"gists_url": "https://api.github.com/users/paulb777/gists{/gist_id}",
64+
"starred_url": "https://api.github.com/users/paulb777/starred{/owner}{/repo}",
65+
"subscriptions_url": "https://api.github.com/users/paulb777/subscriptions",
66+
"organizations_url": "https://api.github.com/users/paulb777/orgs",
67+
"repos_url": "https://api.github.com/users/paulb777/repos",
68+
"events_url": "https://api.github.com/users/paulb777/events{/privacy}",
69+
"received_events_url": "https://api.github.com/users/paulb777/received_events",
70+
"type": "User",
71+
"user_view_type": "public",
72+
"site_admin": false
73+
},
74+
"created_at": "2025-03-28T14:32:38Z",
75+
"updated_at": "2025-03-28T14:32:38Z",
76+
"author_association": "MEMBER",
77+
"body": "See discussion at https://github.com/facebook/react-native/issues/48462. We'll need more information about how to reproduce and what instructions were followed to help here.",
78+
"reactions": {
79+
"url": "https://api.github.com/repos/firebase/firebase-ios-sdk/issues/comments/2761541364/reactions",
80+
"total_count": 0,
81+
"+1": 0,
82+
"-1": 0,
83+
"laugh": 0,
84+
"hooray": 0,
85+
"confused": 0,
86+
"heart": 0,
87+
"rocket": 0,
88+
"eyes": 0
89+
},
90+
"performed_via_github_app": null
91+
},
92+
{
93+
"url": "https://api.github.com/repos/firebase/firebase-ios-sdk/issues/comments/2777314306",
94+
"html_url": "https://github.com/firebase/firebase-ios-sdk/issues/14624#issuecomment-2777314306",
95+
"issue_url": "https://api.github.com/repos/firebase/firebase-ios-sdk/issues/14624",
96+
"id": 2777314306,
97+
"node_id": "IC_kwDOBU6LVM6linQC",
98+
"user": {
99+
"login": "google-oss-bot",
100+
"id": 26440463,
101+
"node_id": "MDQ6VXNlcjI2NDQwNDYz",
102+
"avatar_url": "https://avatars.githubusercontent.com/u/26440463?v=4",
103+
"gravatar_id": "",
104+
"url": "https://api.github.com/users/google-oss-bot",
105+
"html_url": "https://github.com/google-oss-bot",
106+
"followers_url": "https://api.github.com/users/google-oss-bot/followers",
107+
"following_url": "https://api.github.com/users/google-oss-bot/following{/other_user}",
108+
"gists_url": "https://api.github.com/users/google-oss-bot/gists{/gist_id}",
109+
"starred_url": "https://api.github.com/users/google-oss-bot/starred{/owner}{/repo}",
110+
"subscriptions_url": "https://api.github.com/users/google-oss-bot/subscriptions",
111+
"organizations_url": "https://api.github.com/users/google-oss-bot/orgs",
112+
"repos_url": "https://api.github.com/users/google-oss-bot/repos",
113+
"events_url": "https://api.github.com/users/google-oss-bot/events{/privacy}",
114+
"received_events_url": "https://api.github.com/users/google-oss-bot/received_events",
115+
"type": "User",
116+
"user_view_type": "public",
117+
"site_admin": false
118+
},
119+
"created_at": "2025-04-04T01:05:30Z",
120+
"updated_at": "2025-04-04T01:05:30Z",
121+
"author_association": "NONE",
122+
"body": "<!-- event: mark-stale -->\nHey @shilpa12233. We need more information to resolve this issue but there hasn't been an update in 5 weekdays. I'm marking the issue as stale and if there are no new updates in the next 5 days I will close it automatically.\n\nIf you have more information that will help us get to the bottom of this, just add a comment!",
123+
"reactions": {
124+
"url": "https://api.github.com/repos/firebase/firebase-ios-sdk/issues/comments/2777314306/reactions",
125+
"total_count": 0,
126+
"+1": 0,
127+
"-1": 0,
128+
"laugh": 0,
129+
"hooray": 0,
130+
"confused": 0,
131+
"heart": 0,
132+
"rocket": 0,
133+
"eyes": 0
134+
},
135+
"performed_via_github_app": null
136+
}
137+
]

0 commit comments

Comments
 (0)