Skip to content

Commit e65e7ce

Browse files
committed
Fix for selectize#1594, optgroup may be undefined while sorting
1 parent 18ae944 commit e65e7ce

File tree

5 files changed

+9
-9
lines changed

5 files changed

+9
-9
lines changed

dist/js/selectize.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1641,8 +1641,8 @@
16411641
// sort optgroups
16421642
if (this.settings.lockOptgroupOrder) {
16431643
groups_order.sort(function(a, b) {
1644-
var a_order = self.optgroups[a].$order || 0;
1645-
var b_order = self.optgroups[b].$order || 0;
1644+
var a_order = self.optgroups[a] && self.optgroups[a].$order || 0;
1645+
var b_order = self.optgroups[b] && self.optgroups[b].$order || 0;
16461646
return a_order - b_order;
16471647
});
16481648
}
@@ -1974,7 +1974,7 @@
19741974

19751975
return $();
19761976
},
1977-
1977+
19781978
/**
19791979
* Finds the first element with a "textContent" property
19801980
* that matches the given textContent value.

dist/js/selectize.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/js/standalone/selectize.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/js/standalone/selectize.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/selectize.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1139,8 +1139,8 @@ $.extend(Selectize.prototype, {
11391139
// sort optgroups
11401140
if (this.settings.lockOptgroupOrder) {
11411141
groups_order.sort(function(a, b) {
1142-
var a_order = self.optgroups[a].$order || 0;
1143-
var b_order = self.optgroups[b].$order || 0;
1142+
var a_order = self.optgroups[a] && self.optgroups[a].$order || 0;
1143+
var b_order = self.optgroups[b] && self.optgroups[b].$order || 0;
11441144
return a_order - b_order;
11451145
});
11461146
}
@@ -1472,7 +1472,7 @@ $.extend(Selectize.prototype, {
14721472

14731473
return $();
14741474
},
1475-
1475+
14761476
/**
14771477
* Finds the first element with a "textContent" property
14781478
* that matches the given textContent value.

0 commit comments

Comments
 (0)