Extended and adapted to install PostgreSQL 10 for CentOS and Ubuntu (ANXS#267)

* Extended and adapted to install PostgreSQL 10 for CentOS and Ubuntu

Tested with ansible 2.4.1 for Ubuntu 16.04 and CentOS-7.4

- replaced deprecated 'include:' by 'include_tasks:' for ansible 2.4.1
- added config and config template for postgresql 10
- adapted defaults.yml
- adapted templates/etc_systemd_system_postgresql.service.d_custom.conf.j2
  for PostgreSQL 10 the template outputs the wrong line:
	ExecStartPre=/usr/pgsql-10/bin/postgresql10-check-db-dir
  the correct one must include an additional '-':
	ExecStartPre=/usr/pgsql-10/bin/postgresql-10-check-db-dir

* Removed tabs from defaults/main.yml.

* Adapted .travis.yml and yml files to run tests successfully for all given ansible versions.

- added a test for ansible 2.4.2.0/posgresql 10.

- replaced newer 'include_task' by 'include' again so that the role can be used with older
  ansible versions. NOTE: 'include' is deprecated and will be removed in ansible 2.8.

- commeted out docker based tests because they do not run successfully and I do not know
  docker ;-)

* Bug fix. Removed remains for my local teste in test/playbook.yml.

* Bug fix and refinement for postgresql.conf-10.* .

- added max_parallel_workers to postgresql.conf-10.j2 (forgotten/deleted in previous version)
- hard coded value for wal_retrieve_retry_interval in postgresql.conf-10.j2 replaced by ansible variable

Changes to be committed:
	modified:   Vagrantfile
	modified:   defaults/main.yml
	modified:   templates/postgresql.conf-10.j2
	modified:   vagrant-inventory

* Added suggestions from gclough.

 Changes to be committed:
	modified:   Vagrantfile
	modified:   defaults/main.yml
	modified:   templates/HOWTO.postgresql.conf
	modified:   templates/etc_systemd_system_postgresql.service.d_custom.conf.j2
	modified:   tests/playbook.yml
	modified:   tests/vars.yml
	modified:   vagrant-inventory

* Replaced vagrant setup by project's master branch.

* Updated tests/docker/group_vars/all.yml to include version 10.

* Uncommented 'no_log: true' in users.yml.

* Uncommented user baz in tests/docker/group_vars/postgresql.yml.

* Recreated user baz but without passwd. We need him as database owner :-).

* Added encrypted passwd for user baz.

* Commented need for encrypted password if version >= 10.

* Reenabled no_log: true for task  PostgreSQL | Make sure the PostgreSQL users are present
Fixed text in templates/HOWTO.posgresql.conf

* Just to trigger a new build on github. Added blank in README.md.

* Second try to trigger a rebuild. Blank in README.md deleted.

Author: WolfgangPecho

defaults/main.yml

@@ -116,6 +116,7 @@ postgresql_ssl_ciphers:
   - "@STRENGTH"
 postgresql_ssl_prefer_server_ciphers: on
 postgresql_ssl_ecdh_curve: "prime256v1"
+postgresal_ssl_dh_params_file: ""                                 # (>= 10)  
 postgresql_ssl_renegotiation_limit: 512MB # amount of data between renegotiations
 postgresql_ssl_cert_file: "/etc/ssl/certs/ssl-cert-snakeoil.pem"  # (>= 9.2)
 postgresql_ssl_key_file: "/etc/ssl/private/ssl-cert-snakeoil.key" # (>= 9.2)
@@ -199,6 +200,7 @@ postgresql_bgwriter_flush_after:    0      # (>= 9.6) 0 disables,
 postgresql_effective_io_concurrency:        1   # 1-1000; 0 disables prefetching
 postgresql_max_worker_processes:            8   # (change requires restart)
 postgresql_max_parallel_workers_per_gather: 0   # (>= 9.6) taken from max_worker_processes
+postgresql_max_parallel_workers:            8   # (>= 10)
 postgresql_old_snapshot_threshold:          -1  # (>= 9.6) 1min-60d; -1 disables; 0 is immediate
                                                 # (change requires restart)
 postgresql_backend_flush_after:             0   # (>= 9.6) 0 disables, default is 0
@@ -319,6 +321,15 @@ postgresql_wal_receiver_timeout: 60s
 # time to wait before retrying to retrieve WAL after a failed attempt
 postgresql_wal_retrieve_retry_interval: 5s # (>= 9.5)
 
+# - Subscribers - (>= 10) 
+
+# These settings are ignored on a publisher.
+
+postgresql_max_logical_replication_workers: 4   # (>= 10) taken from max_worker_processes
+            # (change requires restart)
+postgresql_max_sync_workers_per_subscription: 2 # (>= 10) taken from max_logical_replication_workers
+
+
 #------------------------------------------------------------------------------
 # QUERY TUNING
 #------------------------------------------------------------------------------
@@ -347,7 +358,9 @@ postgresql_cpu_index_tuple_cost:       0.005   # same scale as above
 postgresql_cpu_operator_cost:          0.0025  # same scale as above
 postgresql_parallel_tuple_cost:        0.1     # same scale as above (>= 9.6)
 postgresql_parallel_setup_cost:        1000.0  # same scale as above (>= 9.6)
-postgresql_min_parallel_relation_size: 8MB     # (>= 9.6)
+postgresql_min_parallel_relation_size: 8MB     # (= 9.6) replaced by below two parameters in 10
+postgresql_min_parallel_table_scan_size: 8MB   # (>= 10)
+postgresql_min_parallel_index_scan_size: 512kB # (>= 10)
 postgresql_effective_cache_size:       128MB
 
 
@@ -499,11 +512,13 @@ postgresql_log_line_prefix: "%t "
 # log lock waits >= deadlock_timeout
 postgresql_log_lock_waits: off
 postgresql_log_statement:  "none"  # none, ddl, mod, all
+postgresql_log_replication_commands: off
 # log temporary files equal or larger
 postgresql_log_temp_files: -1
 postgresql_log_timezone:   "UTC"
 
 
+
 #------------------------------------------------------------------------------
 # RUNTIME STATISTICS
 #------------------------------------------------------------------------------
@@ -588,6 +603,7 @@ postgresql_bytea_output: "hex"  # hex, escape
 postgresql_xmlbinary:    "base64"
 postgresql_xmloption:    "content"
 postgresql_gin_fuzzy_search_limit:  0   # (<= 9.2)
+postgresql_gin_pending_list_limit: 4MB  # (>= 9.5)
 
 
 # - Locale and Formatting -
@@ -639,6 +655,11 @@ postgresql_max_locks_per_transaction: 64         # min 10
 # lock table slots.
 postgresql_max_pred_locks_per_transaction: 64    # min 10
 
+postgresql_max_pred_locks_per_relation: -2       # (>= 10) negative values mean
+               # (max_pred_locks_per_transaction
+               #  / -max_pred_locks_per_relation) - 1
+postgresql_max_pred_locks_per_page: 2            # (>= 10) min 0
+
 
 #------------------------------------------------------------------------------
 # VERSION/PLATFORM COMPATIBILITY
@@ -713,6 +734,7 @@ postgresql_pgdg_releases:
       9.4: 3,
       9.5: 3,
       9.6: 3,
+       10: 2,
   }
   centos: {
       9.1: 7,
@@ -721,6 +743,7 @@ postgresql_pgdg_releases:
       9.4: 3,
       9.5: 3,
       9.6: 3,
+       10: 2,
   }
   sl: {
       9.1: 8,
@@ -729,6 +752,7 @@ postgresql_pgdg_releases:
       9.4: 3,
       9.5: 3,
       9.6: 3,
+       10: 2,
   }
   oraclelinux: {
       9.1: 8,
@@ -737,6 +761,7 @@ postgresql_pgdg_releases:
       9.4: 3,
       9.5: 3,
       9.6: 3,
+       10: 2,
   }
 postgresql_version_terse: "{{ postgresql_version | replace('.', '') }}"
 postgresql_yum_repository_base_url: "http://yum.postgresql.org"

templates/HOWTO.postgresql.conf

@@ -2,21 +2,34 @@
 How to add a new PostgreSQL version
 ===================================
 
-1) Download the Debian package 'postgresql-9.X_[...].deb' from
-http://apt.postgresql.org/pub/repos/apt/pool/main/p/postgresql-9.X/
+Note:  (https://www.postgresql.org/support/versioning)
 
-2) Extract the 'usr/share/postgresql/9.1/postgresql.conf.sample' file
-and save it under the 'templates' role directory
-    => templates/postgresql.conf.9.{X}.orig
+Beginning with version 10, a major release is indicated by increasing the first part of the version, 
+e.g. 10 to 11. Before version 10, a major release was indicated by increasing either the first or second 
+part of the version number, e.g. 9.5 to 9.6. 
 
-3) Check the difference between another version:
-    => vimdiff postgresql.conf.9.{X-1}.orig postgresql.conf.9.{X}.orig
+Do the following steps: ( versions mentioned for transitioninng from version 9.6 to 10 )
 
-4) Copy an existing template:
-    => cp postgresql.conf.9.{X-1}.j2 postgresql.conf.9.{X}.j2
+1) Download the Debian package 'postgresql-<major_version>_[...].deb' from
+http://apt.postgresql.org/pub/repos/apt/pool/main/p/postgresql-<major_version>, e.g. for new version 10 from
+http://apt.postgresql.org/pub/repos/apt/pool/main/p/postgresql-10
+
+2) Extract the 'usr/share/postgresql/<major-version>/postgresql.conf.sample' file with
+   dpkg-deb -x postgresql-<major_version>_[...].deb dir/to/extract/to/
+
+   and save it under the 'templates' role directory
+    => templates/postgresql.conf.<major_version>.orig
+
+3) Check the difference between another version, e.g. for 9.6 -> 10:
+    => vimdiff postgresql.conf.10.orig postgresql.conf.9.6.orig
+
+4) Copy an existing template, e.g.:
+    => cp postgresql.conf.9.6.j2 postgresql.conf.10.j2
 
 5) Update the new template following the major differences.
 
-5) If there are new options or some of them removed, update the 'default/main.yml' file and add a "(>= 9.X)" or "(<= 9.X)" comment to them.
+6) If there are new options or some of them removed, update the 'default/main.yml' file and add a "(>= 10)" or "(<= 10)" comment to them.
+
+7) For yum based installation add version and minor version of postgresql in 'default/main.yml' under '# YUM settings' at end of file
 
-6) Update the '.travis.yml' file to test its new version.
+8) Update the '.travis.yml' file to test its new version.

templates/etc_systemd_system_postgresql.service.d_custom.conf.j2

@@ -6,6 +6,9 @@ User={{ postgresql_service_user }}
 Group={{ postgresql_service_group }}
 
 Environment=PGDATA={{ postgresql_conf_directory }}
-
 ExecStartPre=
+{% if postgresql_version | version_compare('10', '>=') %}
+ExecStartPre={{ postgresql_bin_directory }}/postgresql-{{ postgresql_version_terse }}-check-db-dir {{ postgresql_data_directory }}
+{% else %}
 ExecStartPre={{ postgresql_bin_directory }}/postgresql{{ postgresql_version_terse }}-check-db-dir {{ postgresql_data_directory }}
+{% endif %}