chore(relay): Remove stale comment about span.name (#4835)

gggritso · web-flow · commit 351f96744b5f · 2025-06-23T08:42:13.000+02:00
As of #4796, the `op` field on `SpanV1` does _not_ contain the name, it contains the op! So, this comment is no longer true, there's no duplication.
diff --git a/relay-spans/src/v2_to_v1.rs b/relay-spans/src/v2_to_v1.rs
@@ -99,10 +99,8 @@ pub fn span_v2_to_span_v1(span_v2: SpanV2) -> SpanV1 {
         }
     }
 
-    // Note: This writes the incoming `name` field to a the `sentry.name` attribute. This creates a
-    // bit of duplication, since the attribute `sentry.name` will have the same value as the `op`
-    // field. This duplication is temporary, since we will soon generate a proper `op` field that will
-    // be different from the name.
+    // Write the incoming `name` field to a the `sentry.name` attribute, since the V1
+    // Span schema doesn't have a top-level `name` field.
     if let Some(name) = name.value() {
         data.insert(
             "sentry.name".to_owned(),

Original file line number	Diff line number	Diff line change
`@@ -99,10 +99,8 @@ pub fn span_v2_to_span_v1(span_v2: SpanV2) -> SpanV1 {`
`99`	`99`	`}`
`100`	`100`	`}`
`101`	`101`
`102`		- // Note: This writes the incoming `name` field to a the `sentry.name` attribute. This creates a
`103`		- // bit of duplication, since the attribute `sentry.name` will have the same value as the `op`
`104`		- // field. This duplication is temporary, since we will soon generate a proper `op` field that will
`105`		`- // be different from the name.`
	`102`	+ // Write the incoming `name` field to a the `sentry.name` attribute, since the V1
	`103`	+ // Span schema doesn't have a top-level `name` field.
`106`	`104`	`if let Some(name) = name.value() {`
`107`	`105`	`data.insert(`
`108`	`106`	`"sentry.name".to_owned(),`