fix(issue-summary): Catch automation errors #93674
Merged
+88
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
kddubey
commented
Jun 17, 2025
Comment on lines
+298
to
+300
| raise ValueError("Issue summary scores is None or empty.") | ||
| if issue_summary.scores.fixability_score is None: | ||
| return | ||
| raise ValueError("Issue summary fixability score is None.") |
There was a problem hiding this comment.
changing to ValueError b/c there isn't a good reason for these to not be populated
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #93674 +/- ##
==========================================
+ Coverage 88.02% 88.04% +0.02%
==========================================
Files 10328 10326 -2
Lines 596011 595870 -141
Branches 23155 23127 -28
==========================================
- Hits 524640 524639 -1
+ Misses 70878 70738 -140
Partials 493 493 |
roaga
approved these changes
Jun 17, 2025
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
rn issue summary hard-fails and the generated summary isn't returned if `_run_automation` fails for whatever reason, e.g., `get_autofix_state` fails b/c of seer DB flake. this PR changes behavior to log the exception instead. also including a few style changes—can follow along in each commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rn issue summary hard-fails and the generated summary isn't returned if
_run_automationfails for whatever reason, e.g.,get_autofix_statefails b/c of seer DB flake. this PR changes behavior to log the exception instead. also including a few style changes—can follow along in each commit