Merge pull request payolapayments#250 from eliotsykes/instrument-quantity-changed-fix

Call `instrument_quantity_changed` from `ChangeSubscriptionQuantity`. Closes payolapayments#235.

Author: eliotsykes

CHANGELOG.md

@@ -7,6 +7,9 @@ All notable changes to Payola will be documented in this file.
 ## Unreleased
 [Full Changelog](https://github.com/peterkeen/payola/compare/v1.4.0...HEAD)
 
+### Bug Fixes
+- Call `instrument_quantity_changed` from `ChangeSubscriptionQuantity`. #235
+
 ## v1.4.0 - 2016-01-28
 [Full Changelog](https://github.com/peterkeen/payola/compare/v1.3.2...v1.4.0)
 

app/services/payola/change_subscription_quantity.rb

@@ -13,7 +13,7 @@ def self.call(subscription, quantity)
         subscription.quantity = quantity
         subscription.save!
 
-        subscription.instrument_plan_changed(old_quantity)
+        subscription.instrument_quantity_changed(old_quantity)
 
       rescue RuntimeError, Stripe::StripeError => e
         subscription.errors[:base] << e.message

spec/services/payola/change_subscription_quantity_spec.rb

@@ -5,28 +5,44 @@ module Payola
     let(:stripe_helper) { StripeMock.create_test_helper }
 
     describe "#call" do
+      let(:original_quantity) { 1 }
+      let(:new_quantity) { original_quantity + 1 }
+
       before(:each) do
         @plan = create(:subscription_plan)
         expect(@plan.errors).to be_blank
 
         token = StripeMock.generate_card_token({})
-        @subscription = create(:subscription, quantity: 1, stripe_token: token, plan: @plan, state: 'processing')
+        @subscription = create(:subscription, quantity: original_quantity, stripe_token: token, plan: @plan, state: 'processing')
         StartSubscription.call(@subscription)
         expect(@subscription.error).to be_nil
         expect(@subscription.active?).to be_truthy
-        @subscription = Payola::ChangeSubscriptionQuantity.call(@subscription, 2)
-        expect(@subscription.errors).to be_blank
+      end
+
+      it "should not produce any subscription errors" do
+        subscription = Payola::ChangeSubscriptionQuantity.call(@subscription, new_quantity)
+
+        expect(subscription.errors).to be_blank
       end
 
       it "should change the quantity on the stripe subscription" do
-        customer = Stripe::Customer.retrieve(@subscription.stripe_customer_id)
-        sub = customer.subscriptions.retrieve(@subscription.stripe_id)
+        subscription = Payola::ChangeSubscriptionQuantity.call(@subscription, new_quantity)
 
-        expect(sub.quantity).to eq 2
+        customer = Stripe::Customer.retrieve(subscription.stripe_customer_id)
+        sub = customer.subscriptions.retrieve(subscription.stripe_id)
+        expect(sub.quantity).to eq new_quantity
       end
 
       it "should change the quantity on the payola subscription" do
-        expect(@subscription.reload.quantity).to eq 2
+        subscription = Payola::ChangeSubscriptionQuantity.call(@subscription, new_quantity)
+
+        expect(subscription.reload.quantity).to eq new_quantity
+      end
+
+      it "should notify quantity has changed" do
+        expect(@subscription).to receive(:instrument_quantity_changed).with(original_quantity)
+
+        Payola::ChangeSubscriptionQuantity.call(@subscription, new_quantity)
       end
     end
   end