gmock-internal-utils.cc: Avoid implicit conversion from int to char

dinord · copybara-github · commit 8d51dc50eb7e · 2022-05-17T01:37:27.000-07:00
Fixes #3832 PiperOrigin-RevId: 449158813 Change-Id: Ibe85239ab1f123097b2c1b61616c9d611e5b90d0
diff --git a/googlemock/src/gmock-internal-utils.cc b/googlemock/src/gmock-internal-utils.cc
@@ -234,7 +234,7 @@ bool Base64Unescape(const std::string& encoded, std::string* decoded) {
       return false;
     }
     if (bit_pos == 0) {
-      dst |= src_bin << 2;
+      dst |= static_cast<char>(src_bin << 2);
       bit_pos = 6;
     } else {
       dst |= static_cast<char>(src_bin >> (bit_pos - 2));

Original file line number	Diff line number	Diff line change
`@@ -234,7 +234,7 @@ bool Base64Unescape(const std::string& encoded, std::string* decoded) {`
`234`	`234`	`return false;`
`235`	`235`	`}`
`236`	`236`	`if (bit_pos == 0) {`
`237`		`- dst \|= src_bin << 2;`
	`237`	`+ dst \|= static_cast<char>(src_bin << 2);`
`238`	`238`	`bit_pos = 6;`
`239`	`239`	`} else {`
`240`	`240`	`dst \|= static_cast<char>(src_bin >> (bit_pos - 2));`