Skip to content

Commit bda8544

Browse files
Abseil Teamcopybara-github
authored andcommitted
Fixup some missing overrides in googletest.
This CL adds a couple missing overrides in the googletest sources. These were found downstream when -Wsuggest-override and -Wsuggest-destructor-override were enabled. PiperOrigin-RevId: 447754883 Change-Id: I7bf35a8757cbc5ae157827037aa3d13f47392406
1 parent 4348d4e commit bda8544

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

googletest/include/gtest/internal/gtest-port.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1530,7 +1530,7 @@ class ThreadLocal : public ThreadLocalBase {
15301530
explicit ThreadLocal(const T& value)
15311531
: default_factory_(new InstanceValueHolderFactory(value)) {}
15321532

1533-
~ThreadLocal() { ThreadLocalRegistry::OnThreadLocalDestroyed(this); }
1533+
~ThreadLocal() override { ThreadLocalRegistry::OnThreadLocalDestroyed(this); }
15341534

15351535
T* pointer() { return GetOrCreateValue(); }
15361536
const T* pointer() const { return GetOrCreateValue(); }
@@ -1559,7 +1559,7 @@ class ThreadLocal : public ThreadLocalBase {
15591559
->pointer();
15601560
}
15611561

1562-
virtual ThreadLocalValueHolderBase* NewValueForCurrentThread() const {
1562+
ThreadLocalValueHolderBase* NewValueForCurrentThread() const override {
15631563
return default_factory_->MakeNewHolder();
15641564
}
15651565

0 commit comments

Comments
 (0)