Adding eslint and npm run test for travis

Author: Matt Gaunt

.eslintrc.js

@@ -0,0 +1,35 @@
+module.exports = {
+  extends: ['eslint:recommended', 'google'],
+  env: {
+    node: true,
+    es6: true,
+  },
+  parserOptions: {
+    ecmaVersion: 2017,
+    sourceType: 'module',
+  },
+  rules: {
+    'require-jsdoc': 0,
+    'valid-jsdoc': 0,
+    'no-console': 0,
+  },
+  overrides: [
+    {
+      files: ['src/**/*.js'],
+      env: {
+        browser: true,
+      }
+    },
+    {
+      files: [
+        'src/service-worker.js',
+      ],
+      env: {
+        serviceWorker: true,
+      },
+      globals: {
+        workbox: true,
+      },
+    },
+  ],
+};

.travis.yml

@@ -6,5 +6,4 @@ node_js:
   - '8'
   - '6'
   - '4'
-script:
-  - gulp build
+

gulp-tasks/build.js

@@ -3,11 +3,11 @@ const fse = require('fs-extra');
 
 const getTaskFilepaths = require('./utils/get-task-filepaths');
 
-const cleanDestDir = () =>  {
+function cleanDestDir() {
   return fse.remove(global.__buildConfig.dest);
-};
+}
 
-const build = (done) => {
+function build(done) {
   const parallelTasks = [];
   const postBuildTasks = [];
   const taskFiles = getTaskFilepaths();
@@ -29,7 +29,7 @@ const build = (done) => {
   ];
 
   return gulp.series(buildTasks)(done);
-};
+}
 
 module.exports = {
   task: build,

gulp-tasks/copy.js

@@ -2,15 +2,15 @@ const gulp = require('gulp');
 
 const extensions = [
   'json',
-  'ico'
+  'ico',
 ];
 
-const copy = () => {
+function copy() {
   return gulp.src(`${global.__buildConfig.src}/**/*.{${extensions.join(',')}}`)
   .pipe(gulp.dest(global.__buildConfig.dest));
 }
 
 module.exports = {
   build: copy,
-  watchGlobs: `${global.__buildConfig.src}/**/*.{${extensions.join(',')}}`
+  watchGlobs: `${global.__buildConfig.src}/**/*.{${extensions.join(',')}}`,
 };

gulp-tasks/css.js

@@ -13,5 +13,5 @@ const css = () => {
 
 module.exports = {
   build: css,
-  watchGlobs: `${global.__buildConfig.src}/**/*.css`
+  watchGlobs: `${global.__buildConfig.src}/**/*.css`,
 };

gulp-tasks/html.js

@@ -16,5 +16,5 @@ const html = () => {
 
 module.exports = {
   build: html,
-  watchGlobs: `${global.__buildConfig.src}/**/*.html`
+  watchGlobs: `${global.__buildConfig.src}/**/*.html`,
 };

gulp-tasks/images.js

@@ -17,5 +17,5 @@ const images = () => {
 
 module.exports = {
   build: images,
-  watchGlobs: `${global.__buildConfig.src}/**/*.{${extensions.join(',')}}`
+  watchGlobs: `${global.__buildConfig.src}/**/*.{${extensions.join(',')}}`,
 };

gulp-tasks/javascript.js

@@ -21,7 +21,7 @@ const processScript = (scriptPath, relativePath) => {
     },
     plugins: [
       replacePlugin({
-        'process.env.NODE_ENV': JSON.stringify(process.env.NODE_ENV)
+        'process.env.NODE_ENV': JSON.stringify(process.env.NODE_ENV),
       }),
       uglifyPlugin({}, esMinify),
     ],
@@ -67,5 +67,5 @@ const javascript = (done) => {
 
 module.exports = {
   build: javascript,
-  watchGlobs: `${global.__buildConfig.src}/**/*.js`
+  watchGlobs: `${global.__buildConfig.src}/**/*.js`,
 };

gulp-tasks/sass.js

@@ -9,21 +9,21 @@ const extensions = [
   'scss',
 ];
 
-const sass = () => {
+function sass() {
   return gulp.src(`${global.__buildConfig.src}/**/*.{${extensions.join(',')}}`)
   .pipe(sourcemaps.init())
   .pipe(
     gulpSass({
-      precision: 10
+      precision: 10,
     })
     .on('error', gulpSass.logError)
   )
   .pipe(postcssConfig())
   .pipe(sourcemaps.write())
   .pipe(gulp.dest(global.__buildConfig.dest));
-};
+}
 
 module.exports = {
   build: sass,
-  watchGlobs: `${global.__buildConfig.src}/**/*.{${extensions.join(',')}}`
-}
+  watchGlobs: `${global.__buildConfig.src}/**/*.{${extensions.join(',')}}`,
+};

gulp-tasks/serve.js

@@ -5,12 +5,12 @@ const path = require('path');
 
 const PREFERRED_PORT = 5000;
 
-const serveViaStatic = () => {
+function serveViaStatic() {
   const serve = serveStatic(global.__buildConfig.dest);
 
   const httpServer = http.createServer((req, res) => {
     serve(req, res, () => {
-      res.writeHead(404, { 'Content-Type': 'text/plain' });
+      res.writeHead(404, {'Content-Type': 'text/plain'});
       res.end('Not Found.');
     });
   });
@@ -30,9 +30,9 @@ const serveViaStatic = () => {
     const address = httpServer.address();
     console.log(`Serving @ http://${address.address}:${address.port}`);
   });
-};
+}
 
-const serveViaBrowserSync = () => {
+function serveViaBrowserSync() {
   const server = browserSync.create();
 
   server.watch(path.posix.join(global.__buildConfig.dest, '**', '*'))
@@ -49,9 +49,9 @@ const serveViaBrowserSync = () => {
     logFileChanges: false,
     port: PREFERRED_PORT,
   });
-};
+}
 
-const serve = () => {
+function serve() {
   if (process.env.NODE_ENV === 'production') {
     return serveViaStatic();
   } else {

gulp-tasks/serviceWorker.js

@@ -1,16 +1,15 @@
 const path = require('path');
-const gulp = require('gulp');
 const workboxBuild = require('workbox-build');
 
-const serviceWorker = async () => {
+async function serviceWorker() {
   await workboxBuild.injectManifest({
     swSrc: path.join(global.__buildConfig.src, 'service-worker.js'),
     swDest: path.join(global.__buildConfig.dest, 'service-worker.js'),
-    globDirectory: global.__buildConfig.dest
+    globDirectory: global.__buildConfig.dest,
   });
-};
+}
 
 module.exports = {
   build: serviceWorker,
-  watchGlobs: `${global.__buildConfig.dest}/**/*.*`
+  watchGlobs: `${global.__buildConfig.dest}/**/*.*`,
 };

gulp-tasks/utils/get-task-filepaths.js

@@ -1,7 +1,7 @@
 const path = require('path');
 const fs = require('fs');
 
-module.exports = () => {
+module.exports = function() {
   const tasksDirectory = path.join(__dirname, '..');
   const taskFileNames = fs.readdirSync(tasksDirectory);
   const fullPaths = [];
@@ -12,7 +12,7 @@ module.exports = () => {
       continue;
     }
 
-    fullPaths.push(path.join(tasksDirectory, taskFileName))
+    fullPaths.push(path.join(tasksDirectory, taskFileName));
   }
   return fullPaths;
-}
+};

gulp-tasks/utils/postcssConfig.js

@@ -11,8 +11,8 @@ module.exports = () => {
         customProperties: {
           // Allows both fallback and CSS variables to be used
           preserve: true,
-        }
-      }
+        },
+      },
     }),
     cssnano({
       autoprefixer: false,

gulp-tasks/watch.js

@@ -1,10 +1,8 @@
 const gulp = require('gulp');
-const fse = require('fs-extra');
 
 const getTaskFilepaths = require('./utils/get-task-filepaths');
 
 const watch = (done) => {
-  const watchTasks = [];
   const taskFiles = getTaskFilepaths();
   for (const taskFilepath of taskFiles) {
     const {watchGlobs, build} = require(taskFilepath);

gulpfile.js

@@ -18,7 +18,6 @@
  */
 const gulp = require('gulp');
 const path = require('path');
-const fse = require('fs-extra');
 const getTaskFilepaths = require('./gulp-tasks/utils/get-task-filepaths');
 
 global.__buildConfig = {