Skip to content

Commit 07a8b80

Browse files
committed
Remove the Windows 2019 docker image
1 parent f5e4db3 commit 07a8b80

File tree

7 files changed

+14
-14
lines changed

7 files changed

+14
-14
lines changed

.github/workflows/check-windows-build-image.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ permissions:
1010

1111
jobs:
1212
check-windows-build-image:
13-
runs-on: windows-2019
13+
runs-on: windows-2022
1414
steps:
1515
- name: Checkout code
1616
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

.github/workflows/publish-alloy-windows.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
name: Publish Alloy Windows container
2525
strategy:
2626
matrix:
27-
os: [windows-2022, windows-2019]
27+
os: [windows-2022]
2828
runs-on: ${{ matrix.os }}
2929
steps:
3030
# This step needs to run before "Checkout code".

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,12 @@ internal API changes are not present.
1010
Main (unreleased)
1111
-----------------
1212

13+
### Breaking changes
14+
15+
- Removing the `nanoserver-1809` container image for Windows 2019. (@ptodev)
16+
This is due to the deprecation of `windows-2019` GitHub Actions runners.
17+
The `windowsservercore-ltsc2022` Alloy image is still being published to DockerHub.
18+
1319
### Features
1420

1521
- (_Experimental_) Add an `array.group_by` stdlib function to group items in an array by a key. (@wildum)

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@
7878
include tools/make/*.mk
7979

8080
ALLOY_IMAGE ?= grafana/alloy:latest
81-
ALLOY_IMAGE_WINDOWS ?= grafana/alloy:nanoserver-1809
81+
ALLOY_IMAGE_WINDOWS ?= grafana/alloy:windowsservercore-ltsc2022
8282
ALLOY_BINARY ?= build/alloy
8383
SERVICE_BINARY ?= build/alloy-service
8484
ALLOYLINT_BINARY ?= build/alloylint

docs/sources/set-up/install/docker.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ To run {{< param "PRODUCT_NAME" >}} as a Windows Docker container, run the follo
7575
docker run \
7676
-v "<CONFIG_FILE_PATH>:C:\Program Files\GrafanaLabs\Alloy\config.alloy" \
7777
-p 12345:12345 \
78-
grafana/alloy:nanoserver-1809 \
78+
grafana/alloy:windowsservercore-ltsc2022 \
7979
run --server.http.listen-addr=0.0.0.0:12345 "--storage.path=C:\ProgramData\GrafanaLabs\Alloy\data" \
8080
"C:\Program Files\GrafanaLabs\Alloy\config.alloy"
8181
```

tools/build-image/windows/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM library/golang:1.24.0-windowsservercore-1809
1+
FROM library/golang:1.24.0-windowsservercore-ltsc2022
22

33
SHELL ["powershell", "-command"]
44

tools/ci/docker-containers-windows

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -29,21 +29,15 @@ if [ "$WINDOWS_VERSION" = "windows-2022" ]; then
2929
export BASE_IMAGE_WINDOWS="mcr.microsoft.com/windows/nanoserver:ltsc2022"
3030
IMAGE_NAME_SUFFIX="windowsservercore-ltsc2022"
3131
else
32-
export BASE_IMAGE_GO="library/golang:${ALLOY_GO_VERSION}-windowsservercore-1809"
33-
export BASE_IMAGE_WINDOWS="mcr.microsoft.com/windows/nanoserver:ltsc2019"
34-
# We aren't calling this windows-2019 for backwards compatibility reasons.
35-
# Alloy used to always call this nanoserver-1809.
36-
IMAGE_NAME_SUFFIX="nanoserver-1809"
32+
# Report invalid windows base image and exit with code 1
33+
echo "Invalid windows base image: $WINDOWS_VERSION"
34+
exit 1
3735
fi
3836

3937
export RELEASE_ALLOY_IMAGE=grafana/alloy
4038
export DEVEL_ALLOY_IMAGE=grafana/alloy-dev
4139

4240
# TODO: Unit test this script? Test cases:
43-
# * Input: ALLOY_GO_VERSION=1.24 GITHUB_REF_TYPE=tag GITHUB_REF_NAME=v1.8.0 ./tools/ci/docker-containers-windows alloy
44-
# Output: docker build -t grafana/alloy:v1.8.0-nanoserver-1809 -t grafana/alloy:nanoserver-1809 --build-arg VERSION=v1.8.0 --build-arg RELEASE_BUILD=1 --build-arg BASE_IMAGE_GO=library/golang:1.24-windowsservercore-1809 --build-arg BASE_IMAGE_WINDOWS=mcr.microsoft.com/windows/nanoserver:ltsc2019 -f ./Dockerfile.windows .
45-
# * Input: ALLOY_GO_VERSION=1.24 GITHUB_REF_TYPE=tag GITHUB_REF_NAME=v1.7.0-rc.4 ./tools/ci/docker-containers-windows alloy
46-
# Output: docker build -t grafana/alloy:v1.7.0-rc.4-nanoserver-1809 -t grafana/alloy:v1.7.0-rc.4-nanoserver-1809 --build-arg VERSION=v1.7.0-rc.4 --build-arg RELEASE_BUILD=1 --build-arg BASE_IMAGE_GO=library/golang:1.24-windowsservercore-1809 --build-arg BASE_IMAGE_WINDOWS=mcr.microsoft.com/windows/nanoserver:ltsc2019 -f ./Dockerfile.windows .
4741
# * Input: ALLOY_GO_VERSION=1.24 WINDOWS_VERSION=windows-2022 GITHUB_REF_TYPE=tag GITHUB_REF_NAME=v1.8.0 ./tools/ci/docker-containers-windows alloy
4842
# Output: docker build -t grafana/alloy:v1.8.0-windowsservercore-ltsc2022 -t grafana/alloy:windowsservercore-ltsc2022 --build-arg VERSION=v1.8.0 --build-arg RELEASE_BUILD=1 --build-arg BASE_IMAGE_GO=library/golang:1.24-windowsservercore-ltsc2022 --build-arg BASE_IMAGE_WINDOWS=mcr.microsoft.com/windows/nanoserver:ltsc2022 -f ./Dockerfile.windows .
4943
if [ -n "$GITHUB_TAG" ]; then

0 commit comments

Comments
 (0)