Fix gcc warnings. Return error if castling status != 0.

Author: jdart1

src/apps/fathom.c

@@ -714,7 +714,7 @@ int main(int argc, char **argv)
     }
     printf("%d moves returned from DTZ probe\n",moves.size);
     char str[20];
-    for (int i = 0; i < moves.size; i++) {
+    for (unsigned i = 0; i < moves.size; i++) {
       struct TbRootMove *m = &(moves.moves[i]);
       move_parts_to_str(pos, TB_MOVE_FROM(m->move),
                         TB_MOVE_TO(m->move),
@@ -732,7 +732,7 @@ int main(int argc, char **argv)
       return -1;
     }
     printf("%d moves returned from WDL probe\n",moves.size);
-    for (int i = 0; i < moves.size; i++) {
+    for (unsigned i = 0; i < moves.size; i++) {
       struct TbRootMove *m = &(moves.moves[i]);
       move_parts_to_str(pos, TB_MOVE_FROM(m->move),
                         TB_MOVE_TO(m->move),

src/tbchess.c

@@ -298,17 +298,17 @@ static const uint64_t anti2board_table[15] =
     0x0001020408102040ull,
 };
 
-static inline size_t diag2index(uint64_t b, unsigned d)
+static inline size_t diag2index(uint64_t b)
 {
     b *= 0x0101010101010101ull;
     b >>= 56;
     b >>= 1;
     return (size_t)b;
 }
 
-static inline size_t anti2index(uint64_t b, unsigned a)
+static inline size_t anti2index(uint64_t b)
 {
-    return diag2index(b, a);
+    return diag2index(b);
 }
 
 #define diag(s)                 square2diag_table[(s)]
@@ -322,8 +322,8 @@ static uint64_t bishop_attacks(unsigned sq, uint64_t occ)
     unsigned d = diag(sq), a = anti(sq);
     uint64_t d_occ = occ & (diag2board(d) & ~BOARD_EDGE);
     uint64_t a_occ = occ & (anti2board(a) & ~BOARD_EDGE);
-    size_t d_idx = diag2index(d_occ, d);
-    size_t a_idx = anti2index(a_occ, a);
+    size_t d_idx = diag2index(d_occ);
+    size_t a_idx = anti2index(a_occ);
     uint64_t d_attacks = diag_attacks_table[sq][d_idx];
     uint64_t a_attacks = anti_attacks_table[sq][a_idx];
     return d_attacks | a_attacks;

src/tbprobe.c

@@ -185,9 +185,11 @@ static unsigned lsb(uint64_t b) {
 
 #if _BYTE_ORDER == _BIG_ENDIAN
 
+/* (unused)
 static uint64_t from_le_u64(uint64_t input) {
   return bswap64(input);
 }
+*/
 
 static uint32_t from_le_u32(uint32_t input) {
   return bswap32(input);
@@ -205,15 +207,18 @@ static uint32_t from_be_u32(uint32_t x) {
   return x;
 }
 
-static uint16_t from_be_u16(uint16_t x) {
+/* (unused)
+  static uint16_t from_be_u16(uint16_t x) {
   return x;
-}
+ }*/
 
 #else
 
+/* (unused)
 static uint64_t from_le_u64(uint64_t x) {
   return x;
 }
+*/
 
 static uint32_t from_le_u32(uint32_t x) {
   return x;
@@ -231,9 +236,11 @@ static uint32_t from_be_u32(uint32_t input) {
   return bswap32(input);
 }
 
+/* (unused)
 static uint16_t from_be_u16(const uint16_t input) {
   return bswap16(input);
 }
+*/
 
 #endif
 
@@ -585,6 +592,7 @@ int tb_probe_root_dtz(
         (uint8_t)ep,
         turn
     };
+    if (castling != 0) return 0;
     return root_probe_dtz(&pos, hasRepeated, useRule50, results);
 }
 
@@ -617,6 +625,7 @@ int tb_probe_root_wdl(
         (uint8_t)ep,
         turn
     };
+    if (castling != 0) return 0;
     return root_probe_wdl(&pos, useRule50, results);
 }
 
@@ -1742,7 +1751,7 @@ int probe_table(const Pos *pos, int s, int *success, const int type)
   int p[TB_PIECES];
   size_t idx;
   int t = 0;
-  uint8_t flags;
+  uint8_t flags = 0; // initialize to fix GCC warning
 
   if (!be->hasPawns) {
     if (type == DTZ) {