Skip to content

Commit dc76fc3

Browse files
authored
Fix codecov-action [DI-520] (#726)
The C++ coverage action has been [silently failing](https://github.com/hazelcast/hazelcast-cpp-client/actions/runs/15610247637/attempts/1). Updated all usages to: - supply a token to properly authenticate (the reason for the failure) - fail the step if the upload fails (to avoid the error going unreported) - use the latest version (consistency) Fixes: [DI-520](https://hazelcast.atlassian.net/browse/DI-520) [DI-520]: https://hazelcast.atlassian.net/browse/DI-520?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
1 parent 61e1357 commit dc76fc3

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

.github/workflows/coverage_runner.yml

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,23 +87,29 @@ jobs:
8787

8888
- name: Publish results to Codecov for PR coming from hazelcast organization
8989
if: ${{ matrix.python-version == needs.python-versions.outputs.latest-python-version && matrix.os == 'ubuntu-latest' && github.event_name == 'pull_request_target' }}
90-
uses: codecov/codecov-action@v1
90+
uses: codecov/codecov-action@v5
9191
with:
92+
token: ${{ secrets.CODECOV_TOKEN }}
9293
files: ./coverage.xml
9394
override_pr: ${{ github.event.pull_request.number }}
95+
fail_ci_if_error: true
9496

9597
- name: Publish results to Codecov for Push
9698
if: ${{ matrix.python-version == needs.python-versions.outputs.latest-python-version && matrix.os == 'ubuntu-latest' && github.event_name == 'push' }}
97-
uses: codecov/codecov-action@v1
99+
uses: codecov/codecov-action@v5
98100
with:
101+
token: ${{ secrets.CODECOV_TOKEN }}
99102
files: ./coverage.xml
103+
fail_ci_if_error: true
100104

101105
- name: Publish result to Codecov for PR coming from community
102106
if: ${{ matrix.python-version == needs.python-versions.outputs.latest-python-version && matrix.os == 'ubuntu-latest' && github.event_name == 'workflow_dispatch' }}
103-
uses: codecov/codecov-action@v1
107+
uses: codecov/codecov-action@v5
104108
with:
109+
token: ${{ secrets.CODECOV_TOKEN }}
105110
files: ./coverage.xml
106111
override_pr: ${{ github.event.inputs.pr_number }}
112+
fail_ci_if_error: true
107113

108114
- name: Upload remote controller logs if test run fails
109115
uses: actions/upload-artifact@v4

0 commit comments

Comments
 (0)