Skip to content

Commit 12da6fc

Browse files
danielsoglTheSharpieOne
authored andcommitted
docs(Modal): improve toggle example (reactstrap#1395)
Boolean states should be set with the previous state to avoid async state change issues.
1 parent 3289569 commit 12da6fc

File tree

9 files changed

+27
-27
lines changed

9 files changed

+27
-27
lines changed

docs/lib/examples/Modal.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ class ModalExample extends React.Component {
1414
}
1515

1616
toggle() {
17-
this.setState({
18-
modal: !this.state.modal
19-
});
17+
this.setState(prevState => ({
18+
modal: !prevState.modal
19+
}));
2020
}
2121

2222
render() {

docs/lib/examples/ModalBackdrop.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@ class ModalExample extends React.Component {
1616
}
1717

1818
toggle() {
19-
this.setState({
20-
modal: !this.state.modal
21-
});
19+
this.setState(prevState => ({
20+
modal: !prevState.modal
21+
}));
2222
}
2323

2424
changeBackdrop(e) {

docs/lib/examples/ModalCustomCloseButton.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ class ModalExample extends React.Component {
1414
}
1515

1616
toggle() {
17-
this.setState({
18-
modal: !this.state.modal
19-
});
17+
this.setState(prevState => ({
18+
modal: !prevState.modal
19+
}));
2020
}
2121

2222
render() {

docs/lib/examples/ModalCustomCloseIcon.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ class ModalExample extends React.Component {
1414
}
1515

1616
toggle() {
17-
this.setState({
18-
modal: !this.state.modal
19-
});
17+
this.setState(prevState => ({
18+
modal: !prevState.modal
19+
}));
2020
}
2121

2222
render() {

docs/lib/examples/ModalCustomTimeout.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ class ModalExample extends React.Component {
1414
}
1515

1616
toggle() {
17-
this.setState({
18-
modal: !this.state.modal
19-
});
17+
this.setState(prevState => ({
18+
modal: !prevState.modal
19+
}));
2020
}
2121

2222
render() {

docs/lib/examples/ModalDestructuring.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@ class ModalExample extends React.Component {
1616
}
1717

1818
toggle() {
19-
this.setState({
20-
modal: !this.state.modal
21-
});
19+
this.setState(prevState => ({
20+
modal: !prevState.modal
21+
}));
2222
}
2323

2424
changeUnmountOnClose(e) {

docs/lib/examples/ModalExternal.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ class ModalExample extends React.Component {
1414
}
1515

1616
toggle() {
17-
this.setState({
18-
modal: !this.state.modal
19-
});
17+
this.setState(prevState => ({
18+
modal: !prevState.modal
19+
}));
2020
}
2121

2222
render() {

docs/lib/examples/ModalFadeless.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ class ModalExample extends React.Component {
1414
}
1515

1616
toggle() {
17-
this.setState({
18-
modal: !this.state.modal
19-
});
17+
this.setState(prevState => ({
18+
modal: !prevState.modal
19+
}));
2020
}
2121

2222
render() {

docs/lib/examples/ModalNested.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ class ModalExample extends React.Component {
1818
}
1919

2020
toggle() {
21-
this.setState({
22-
modal: !this.state.modal
23-
});
21+
this.setState(prevState => ({
22+
modal: !prevState.modal
23+
}));
2424
}
2525

2626
toggleNested() {

0 commit comments

Comments
 (0)