Skip to content

Commit fdbc388

Browse files
Kaleb BurdTheSharpieOne
authored andcommitted
Bug/v7 merge conflict fix (reactstrap#1324)
1 parent ea0f1f0 commit fdbc388

38 files changed

+615
-183
lines changed

CHANGELOG.md

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,25 @@
1+
<a name="6.5.0"></a>
2+
# [6.5.0](https://github.com/reactstrap/reactstrap/compare/6.4.0...6.5.0) (2018-10-04)
3+
4+
5+
### Bug Fixes
6+
7+
* **boundariesElement:** add DOMElement to allowed proptypes ([#1238](https://github.com/reactstrap/reactstrap/issues/1238)) ([cfe7318](https://github.com/reactstrap/reactstrap/commit/cfe7318))
8+
* **Dropdown:** enter key triggers onClick ([#1232](https://github.com/reactstrap/reactstrap/issues/1232)) ([f2528da](https://github.com/reactstrap/reactstrap/commit/f2528da)), closes [#1228](https://github.com/reactstrap/reactstrap/issues/1228)
9+
* **Modal:** do not trigger focus on SVG elements ([#1212](https://github.com/reactstrap/reactstrap/issues/1212)) ([c7e6ef5](https://github.com/reactstrap/reactstrap/commit/c7e6ef5)), closes [#1208](https://github.com/reactstrap/reactstrap/issues/1208)
10+
* **Modal:** use static openCount to become resilient to classList modification ([#1190](https://github.com/reactstrap/reactstrap/issues/1190)) ([c8ceeeb](https://github.com/reactstrap/reactstrap/commit/c8ceeeb)), closes [#1189](https://github.com/reactstrap/reactstrap/issues/1189)
11+
* **Tooltip:** clear timers on component unmount ([#1180](https://github.com/reactstrap/reactstrap/issues/1180)) ([9fea409](https://github.com/reactstrap/reactstrap/commit/9fea409))
12+
13+
14+
### Features
15+
16+
* **Button:** add close icon support ([#1206](https://github.com/reactstrap/reactstrap/issues/1206)) ([02f5e9a](https://github.com/reactstrap/reactstrap/commit/02f5e9a)), closes [#1182](https://github.com/reactstrap/reactstrap/issues/1182)
17+
* **FormGrid:** Add form-row ([#1237](https://github.com/reactstrap/reactstrap/issues/1237)) ([205e80d](https://github.com/reactstrap/reactstrap/commit/205e80d)), closes [#1195](https://github.com/reactstrap/reactstrap/issues/1195)
18+
* **Modal:** add custom close button ([#1168](https://github.com/reactstrap/reactstrap/issues/1168)) ([5f33a1a](https://github.com/reactstrap/reactstrap/commit/5f33a1a))
19+
* **Popover/Tooltip:** Implented usage of react 16.3 RefObject as target ([#1200](https://github.com/reactstrap/reactstrap/issues/1200)) ([0eade39](https://github.com/reactstrap/reactstrap/commit/0eade39)), closes [#1198](https://github.com/reactstrap/reactstrap/issues/1198)
20+
21+
22+
123
<a name="6.4.0"></a>
224
# [6.4.0](https://github.com/reactstrap/reactstrap/compare/6.3.1...6.4.0) (2018-08-17)
325

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ Then open [http://localhost:3000/](http://localhost:3000/) to see your app. The
3434
Install reactstrap and Bootstrap from NPM. Reactstrap does not include Bootstrap CSS so this needs to be installed as well:
3535

3636
```
37-
npm install --save bootstrap@4.1.1
38-
npm install --save reactstrap react@^16.3.2 react-dom@^16.3.2
37+
npm install --save bootstrap
38+
npm install --save reactstrap react react-dom
3939
```
4040

4141
Import Bootstrap CSS in the ```src/index.js``` file:

docs/lib/Components/ButtonDropdownPage.js

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import {
1010
import Example from '../examples/ButtonDropdownMulti';
1111
import ExampleSplit from '../examples/ButtonDropdownMultiSplit';
1212
import ButtonDropdownExample from '../examples/ButtonDropdown';
13+
import ButtonDropdownUncontrolledExample from '../examples/ButtonDropdownUncontrolled'
1314
import SectionTitle from '../UI/SectionTitle';
1415

1516
const ButtonDropdownExampleSource = require('!!raw!../examples/ButtonDropdown');
@@ -165,6 +166,33 @@ DropdownToggle.propTypes = {
165166
</ButtonDropdown>`}
166167
</PrismCode>
167168
</pre>
169+
<SectionTitle>Uncontrolled Dropdown</SectionTitle>
170+
<div className="docs-example">
171+
<ButtonDropdownUncontrolledExample />
172+
</div>
173+
<pre>
174+
<PrismCode className="language-jsx">
175+
{`import React from 'react';
176+
import { UncontrolledButtonDropdown, DropdownMenu, DropdownItem, DropdownToggle } from 'reactstrap';
177+
178+
export default function Example () => {
179+
return (
180+
<UncontrolledButtonDropdown>
181+
<DropdownToggle caret>
182+
Dropdown
183+
</DropdownToggle>
184+
<DropdownMenu>
185+
<DropdownItem header>Header</DropdownItem>
186+
<DropdownItem disabled>Action</DropdownItem>
187+
<DropdownItem>Another Action</DropdownItem>
188+
<DropdownItem divider />
189+
<DropdownItem>Another Action</DropdownItem>
190+
</DropdownMenu>
191+
</UncontrolledButtonDropdown>
192+
);
193+
}`}
194+
</PrismCode>
195+
</pre>
168196
<SectionTitle>Drop direction variations</SectionTitle>
169197
<div className="docs-example">
170198
<div>

docs/lib/Components/ButtonsPage.js

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@ const ButtonOutlineSource = require('!!raw!../examples/ButtonOutline');
1313
import ButtonStateful from '../examples/ButtonStateful';
1414
const ButtonStatefulSource = require('!!raw!../examples/ButtonStateful');
1515

16+
import ButtonCloseIcon from '../examples/ButtonCloseIcon';
17+
const ButtonCloseIconSource = require('!!raw!../examples/ButtonCloseIcon');
18+
1619
export default class ButtonsPage extends React.Component {
1720
render() {
1821
return (
@@ -44,7 +47,10 @@ export default class ButtonsPage extends React.Component {
4447
innerRef: PropTypes.oneOfType([PropTypes.func, PropTypes.string]),
4548
4649
onClick: PropTypes.func,
47-
size: PropTypes.string
50+
size: PropTypes.string,
51+
52+
// use close prop for BS4 close icon utility
53+
close: PropTypes.bool,
4854
}`}
4955
</PrismCode>
5056
</pre>
@@ -123,6 +129,20 @@ export default class ButtonsPage extends React.Component {
123129
{ButtonStatefulSource}
124130
</PrismCode>
125131
</pre>
132+
133+
<SectionTitle>Close icon</SectionTitle>
134+
<p>
135+
Use a generic close icon to dismiss content. Use <code>&lt;Button close /&gt;</code> for the default icon. Otherwise, custom content for the button
136+
may be defined. (e.g. JSX: <code>&lt;Button close&gt;&lt;span aria-hidden="true"&gt;&ndash;&lt;/span&gt;&lt;/Button&gt;</code>) The default aria-label is "Close".
137+
</p>
138+
<div className="docs-example">
139+
<ButtonCloseIcon />
140+
</div>
141+
<pre>
142+
<PrismCode className="language-jsx">
143+
{ButtonCloseIconSource}
144+
</PrismCode>
145+
</pre>
126146
</div>
127147
);
128148
}

docs/lib/Components/FormPage.js

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@ const FormExampleSource = require('!!raw!../examples/Form');
1010
import FormGridExample from '../examples/FormGrid';
1111
const FormGridExampleSource = require('!!raw!../examples/FormGrid');
1212

13+
import FormGridFormRowExample from '../examples/FormGridFormRow';
14+
const FormGridFormRowExampleSource = require('!!raw!../examples/FormGridFormRow');
15+
1316
import FormInlineExample from '../examples/FormInline';
1417
const FormInlineExampleSource = require('!!raw!../examples/FormInline');
1518

@@ -146,6 +149,16 @@ FormText.propTypes = {
146149
</PrismCode>
147150
</pre>
148151

152+
<SectionTitle>Form Grid with Form Row</SectionTitle>
153+
<div className="docs-example">
154+
<FormGridFormRowExample />
155+
</div>
156+
<pre>
157+
<PrismCode className="language-jsx">
158+
{FormGridFormRowExampleSource}
159+
</PrismCode>
160+
</pre>
161+
149162
<SectionTitle>Inline Form</SectionTitle>
150163
<div className="docs-example">
151164
<FormInlineExample />

docs/lib/Components/LayoutPage.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,9 @@ export default class LayoutsPage extends React.Component {
3232
<pre>
3333
<PrismCode className="language-jsx">
3434
{`Row.propTypes = {
35-
noGutters: PropTypes.bool
35+
noGutters: PropTypes.bool,
36+
// see https://reactstrap.github.io/components/form Form Grid with Form Row
37+
form: PropTypes.bool
3638
}`}
3739
</PrismCode>
3840
</pre>

docs/lib/Components/ModalsPage.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ const ModalsPage = () => {
6565
PropTypes.bool,
6666
PropTypes.oneOf(['static'])
6767
]),
68-
// allows for a node/componet to exist next to the modal (outside of it). Useful for external close buttons
68+
// allows for a node/component to exist next to the modal (outside of it). Useful for external close buttons
6969
// external: PropTypes.node,
7070
// called on componentDidMount
7171
onEnter: PropTypes.func,

docs/lib/Components/PopoversPage.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export default class PopoversPage extends React.Component {
3737
// callback for toggling isOpen in the controlling component
3838
toggle: PropTypes.func,
3939
// boundaries for popper, can be scrollParent, window, viewport, or any DOM element
40-
boundariesElement: PropTypes.string,
40+
boundariesElement: PropTypes.oneOfType([PropTypes.string, DOMElement]),
4141
target: PropTypes.oneOfType([
4242
PropTypes.string,
4343
PropTypes.func,

docs/lib/Components/TablesPage.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,13 @@ borderless: PropTypes.bool,
4848
striped: PropTypes.bool,
4949
dark: PropTypes.bool,
5050
hover: PropTypes.bool,
51-
responsive: PropTypes.bool
51+
responsive: PropTypes.bool,
52+
// Custom ref handler that will be assigned to the "ref" of the inner <table> element
53+
innerRef: PropTypes.oneOfType([
54+
PropTypes.func,
55+
PropTypes.string,
56+
PropTypes.object
57+
])
5258
};`}
5359
</PrismCode>
5460
</pre>

docs/lib/Components/TooltipsPage.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ export default class TooltipsPage extends React.Component {
3333
// space separated list of triggers (e.g. "click hover focus")
3434
trigger: PropTypes.string,
3535
// boundaries for popper, can be scrollParent, window, viewport, or any DOM element
36-
boundariesElement: PropTypes.string,
36+
boundariesElement: PropTypes.oneOfType([PropTypes.string, DOMElement]),
3737
// boolean to control the state of the tooltip
3838
isOpen: PropTypes.bool,
3939
hideArrow: PropTypes.bool,

0 commit comments

Comments
 (0)