Merge pull request #52 from dsanders11/pkg-no-name

Gracefully handle misconfigured packages with no name

Author: spion

src/index.ts

@@ -178,7 +178,14 @@ const packageJsonWorkspacesNohoistFormat = packageJsonWorkspaces && packageJsonW
 
 const workspaceGlobs = packageJsonWorkspacesNohoistFormat || packageJsonWorkspaces || ['packages/*']
 
-const pkgs = listPkgs('./', workspaceGlobs)
+let pkgs
+try {
+  pkgs = listPkgs('./', workspaceGlobs)
+} catch (err) {
+  console.error(chalk.red(`\nERROR: ${err.message}`))
+  process.exit(1)
+}
+
 const pkgPaths = _.mapValues(_.keyBy(pkgs, p => p.json.name), v => v.path)
 
 const pkgJsons = _.map(pkgs, pkg => pkg.json)

src/workspace.ts

@@ -38,6 +38,7 @@ export function listPkgs(wsRoot: string, globs: string[]) {
         return
       }
       const pkgJson = JSON.parse(fs.readFileSync(pkgJsonPath, 'utf8'))
+      if (!pkgJson.name) throw new Error(`Package in directory ${f} has no name in package.json`)
       packages[pkgJson.name] = {
         path: path.join(wsRoot, f),
         json: pkgJson

tests/basic.ts

@@ -184,4 +184,19 @@ describe('basic', () => {
       }
     )
   })
+
+  it('should show an error for pkgs without name', async () => {
+    await withScaffold(
+      {
+        packages: [
+          echo.makePkg({ path: 'packages/p1', dependencies: {} }),
+        ]
+      },
+      async () => {
+        let tst = await wsrun('doecho')
+        expect(tst.status).toBeTruthy()
+        expect(String(tst.output[2])).toEqual('\nERROR: Package in directory packages/p1 has no name in package.json\n')
+      }
+    )
+  })
 })

tests/test.util.ts

@@ -20,7 +20,7 @@ let rimrafAsync = promisify(rimraf)
 let mkdirpAsync = promisify(mkdirp)
 
 export type PackageJson = {
-  name: string
+  name?: string
   path?: string
   dependencies?: { [name: string]: string }
   devDependencies?: { [name: string]: string }