Skip to content

Commit d006c92

Browse files
author
Stephen Gutekanst
committed
frontend: correct docker:cmd directive form
`serve` is treated as a shell form and hence runs: ``` /sbin/tini -- /usr/local/bin/frontend /bin/sh -c serve ``` Which is incorrect. Instead, we want `["serve"]` which is treated as parameters to `ENTRYPOINT` by Docker, i.e.: ``` /sbin/tini -- /usr/local/bin/frontend serve ```
1 parent 5c5a0d9 commit d006c92

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

cmd/frontend/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
//docker:user sourcegraph
2-
//docker:cmd serve
2+
//docker:cmd ["serve"]
33
//docker:env CONFIGURATION_MODE=server
44
//docker:env PUBLIC_REPO_REDIRECTS=true
55

enterprise/cmd/frontend/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
//docker:user sourcegraph
2-
//docker:cmd serve
2+
//docker:cmd ["serve"]
33
//docker:env CONFIGURATION_MODE=server
44
//docker:env PUBLIC_REPO_REDIRECTS=true
55

0 commit comments

Comments
 (0)