Skip to content

Commit ced4f3c

Browse files
committed
run tests on Django 2.0
1 parent 7d015c8 commit ced4f3c

File tree

4 files changed

+34
-11
lines changed

4 files changed

+34
-11
lines changed

.travis.yml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,22 @@ cache: pip
44
python:
55
- "2.7"
66
- "3.4"
7-
- "3.5"
7+
- "3.6"
88
env:
99
- PACKAGES="Django>=1.7,<1.8 django-contrib-comments<1.8"
1010
- PACKAGES="Django>=1.8,<1.9"
1111
- PACKAGES="Django>=1.9,<1.10"
1212
- PACKAGES="Django>=1.10,<1.11"
13+
- PACKAGES="Django>=1.11,<1.12"
14+
- PACKAGES="Django>=2.0,<2.1"
1315
matrix:
1416
exclude:
15-
- python: '3.5'
17+
- python: '3.6'
1618
env: PACKAGES="Django>=1.7,<1.8 django-contrib-comments<1.8"
19+
- python: '2.7'
20+
env: PACKAGES="Django>=2.0,<2.1"
21+
allow_failure:
22+
- env: PACKAGES="Django>=2.0,<2.1"
1723

1824
before_install:
1925
- pip install codecov

examples/example/settings.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@
9191
'django.contrib.auth.middleware.AuthenticationMiddleware',
9292
'django.contrib.messages.middleware.MessageMiddleware',
9393
)
94+
MIDDLEWARE = MIDDLEWARE_CLASSES # Django 2.0
9495

9596
STATICFILES_FINDERS = (
9697
'django.contrib.staticfiles.finders.FileSystemFinder',

runtests.py

Lines changed: 22 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
if django.VERSION >= (1,8):
1919
base_app = 'django_comments'
2020

21-
template_settings = dict(
21+
versioned_settings = dict(
2222
TEMPLATES = [
2323
{
2424
'BACKEND': 'django.template.backends.django.DjangoTemplates',
@@ -36,7 +36,7 @@
3636
)
3737
else:
3838
base_app = 'django.contrib.comments'
39-
template_settings = dict(
39+
versioned_settings = dict(
4040
TEMPLATE_LOADERS = (
4141
'django.template.loaders.app_directories.Loader',
4242
),
@@ -45,6 +45,25 @@
4545
],
4646
)
4747

48+
if django.VERSION >= (2, 0):
49+
versioned_settings.update(dict(
50+
MIDDLEWARE = (
51+
'django.middleware.common.CommonMiddleware',
52+
'django.contrib.sessions.middleware.SessionMiddleware',
53+
'django.middleware.csrf.CsrfViewMiddleware',
54+
'django.contrib.auth.middleware.AuthenticationMiddleware',
55+
)
56+
))
57+
else:
58+
versioned_settings.update(dict(
59+
MIDDLEWARE_CLASSES = (
60+
'django.middleware.common.CommonMiddleware',
61+
'django.contrib.sessions.middleware.SessionMiddleware',
62+
'django.middleware.csrf.CsrfViewMiddleware',
63+
'django.contrib.auth.middleware.AuthenticationMiddleware',
64+
)
65+
))
66+
4867
settings.configure(
4968
DATABASES = {
5069
'default': {
@@ -60,18 +79,12 @@
6079
base_app,
6180
'threadedcomments',
6281
),
63-
MIDDLEWARE_CLASSES = (
64-
'django.middleware.common.CommonMiddleware',
65-
'django.contrib.sessions.middleware.SessionMiddleware',
66-
'django.middleware.csrf.CsrfViewMiddleware',
67-
'django.contrib.auth.middleware.AuthenticationMiddleware',
68-
),
6982
ROOT_URLCONF = '{0}.urls'.format(base_app),
7083
TEST_RUNNER = 'django.test.simple.DjangoTestSuiteRunner' if django.VERSION < (1,6) else 'django.test.runner.DiscoverRunner',
7184
SITE_ID = 1,
7285
COMMENTS_APP = 'threadedcomments',
7386
COMMENTS_ALLOW_PROFANITIES = True,
74-
**template_settings
87+
**versioned_settings
7588
)
7689

7790
sys.stderr.write('Using comments app {0} from {1}\n'.format(base_app, path.dirname(import_module(base_app).__file__)))

tox.ini

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
envlist=
33
py27-django{17,18,19,110},
44
py35-django{17,18,19,110},
5+
py35-django{111,20},
56
# py36-django-dev,
67
docs,
78

@@ -13,6 +14,8 @@ deps =
1314
django18: Django >= 1.8,<1.9
1415
django19: Django >= 1.9,<1.10
1516
django110: Django >= 1.10,<1.11
17+
django111: Django >= 1.11,<2.0
18+
django20: Django >= 2.0,<2.1
1619
django-dev: https://github.com/django/django/tarball/master
1720
commands=
1821
python --version

0 commit comments

Comments
 (0)