Remove maxWaitMins requirement if no dependencies defined in Trigger (linkedin#219)

Author: Charlie Summers

CONTRIBUTORS.md

@@ -132,6 +132,7 @@ The following were contributed by Charlie Summers. Thanks, Charlie!
 * `Add ability for Hadoop DSL to understand the TableauJob job type`
 * `Adding additional condition for TableauJob creation`
 * `Allow generateYamlOutput to be defined multiple times`
+* `Remove maxWaitMins requirement if no dependencies defined in Trigger`
 
 The following were contributed by Nicholas Cowan. Thanks, Nick!
 * `Add ability for Hadoop DSL to understand the HdfsWait job type`

VERSIONS.md

@@ -17,6 +17,10 @@ the License.
 Note that the LinkedIn build system occasionally requires that we skip a
 version bump, so you will see a few skipped version numbers in the list below.
 
+0.14.14
+
+* Remove maxWaitMins requirement if no dependencies defined in Trigger
+
 0.14.13
 
 * Allow generateYamlOutput to be defined multiple times

gradle.properties

@@ -1,2 +1,2 @@
 org.gradle.daemon=true
-version=0.14.13
+version=0.14.14

hadoop-plugin-test/expectedOutput/negative/triggerCheck.out

@@ -10,7 +10,7 @@ TriggerChecker ERROR: DaliDependency dali-data-dep in Trigger trigger1 in Workfl
 TriggerChecker ERROR: DaliDependency dali-data-dep in Trigger trigger1 in Workflow triggerFail1 must have a window greater than 0.
 TriggerChecker ERROR: DaliDependency dali-data-dep in Trigger trigger1 in Workflow triggerFail1 must have a nonnegative delay.
 TriggerChecker ERROR: 'unit' value in DaliDependency dali-data-dep in Trigger trigger1 in Workflow triggerFail1 can only be set to 'daily' or 'hourly'.
-TriggerChecker ERROR: Trigger trigger2 in Workflow triggerFail1 must define 'maxWaitMins' and it must be greater than 0.
+TriggerChecker WARN: Trigger trigger2 in Workflow triggerFail1 defines 'maxWaitMins' when there are no dependencies. Azkaban will automatically launch the flow when the schedule is met, so this isn't necessary.
 TriggerChecker ERROR: Trigger trigger2 in Workflow triggerFail1 contains more than one schedule.
 TriggerChecker ERROR: Schedule in Trigger trigger2 in Workflow triggerFail1 must define 'value'.
 TriggerChecker ERROR: Schedule in Trigger trigger2 in Workflow triggerFail1 must define 'value' as a valid cron expression.

hadoop-plugin-test/src/main/gradle/negative/triggerCheck.gradle

@@ -22,7 +22,7 @@ hadoop {
 
   workflow('triggerFail1') {
     trigger('trigger1') {
-      // no maxWaitMins throws an ERROR
+      // no maxWaitMins when there is a dependency throws an ERROR
       // no schedule throws an ERROR
       daliDependency('dali-data-dep') {
         // no dali dependency view throws an ERROR
@@ -33,7 +33,8 @@ hadoop {
     }
 
     trigger('trigger2') { // two defined triggers throws an ERROR
-      maxWaitMins 0 // maxWaitMins less than 1 throws an ERROR
+      // maxWaitMins defined with no dependencies throws a WARN
+      maxWaitMins 1
       schedule {
         // no schedule value throws an ERROR
       }

hadoop-plugin/src/main/groovy/com/linkedin/gradle/hadoopdsl/checker/TriggerChecker.groovy

@@ -14,9 +14,10 @@ import org.quartz.CronExpression;
  * <ul>
  *   <li>Trigger specific
  *   <li>ERROR if more than 1 trigger is defined in a workflow.</li>
- *   <li>ERROR if a trigger maxWaitMins doesn't exist or is less than 1.</li>
+ *   <li>ERROR if there are dependencies and a trigger maxWaitMins doesn't exist or is less than 1.</li>
  *   <li>WARN if a trigger maxWaitMins is greater than 10 days (14400) - will be set to 10 days
  *       by Azkaban.</li>
+ *   <li>WARN if a trigger maxWaitMins is set and there are no dependencies</li>
  *   <li>ERROR if a trigger schedule doesn't exist.</li>
  *   <li>ERROR if more than one trigger schedule is defined for a trigger.</li>
  *   <li>ERROR if a trigger schedule doesn't have a value.</li>
@@ -25,7 +26,7 @@ import org.quartz.CronExpression;
  *   <li>ERROR if a trigger dependency name is not unique.</li>
  *   <li>ERROR if a trigger dependency config (type + params) is not unique.</li>
  *   <li>
- *   <li>DaliDependency specific
+ *   <li>DaliDependency specific</li>
  *   <li>ERROR if a trigger dali dependency doesn't have a view.</li>
  *   <li>ERROR if a trigger dali dependency doesn't have a window.</li>
  *   <li>ERROR if a trigger dali dependency doesn't have a delay.</li>
@@ -106,15 +107,19 @@ class TriggerChecker extends BaseStaticChecker {
   boolean checkWaitMins() {
     boolean checkWaitMinsError = false;
 
-    // ERROR if maxWaitMins not defined or >1
-    if (trigger.maxWaitMins < MIN_FLOW_TRIGGER_WAIT_TIME) {
+    // ERROR if there are dependencies and maxWaitMins doesn't exist or <1
+    if (trigger.triggerDependencies.size() != 0 && trigger.maxWaitMins < MIN_FLOW_TRIGGER_WAIT_TIME) {
       project.logger.lifecycle("TriggerChecker ERROR: Trigger ${trigger.name} in Workflow ${workflow.name} must define 'maxWaitMins' and it must be greater than 0.");
       checkWaitMinsError = true;
     }
     // WARN if maxWaitMins >10 days (14400 mins)
-    else if (trigger.maxWaitMins > MAX_FLOW_TRIGGER_WAIT_TIME) {
+    if (trigger.maxWaitMins > MAX_FLOW_TRIGGER_WAIT_TIME) {
       project.logger.lifecycle("TriggerChecker WARN: Trigger ${trigger.name} in Workflow ${workflow.name} defines 'maxWaitMins' to be greater than 10 days. Azkaban will automatically reduce to 10 days.");
     }
+    // WARN if maxWaitMins is set when there are no dependencies
+    if (trigger.triggerDependencies.size() == 0 && trigger.maxWaitMins != 0) {
+      project.logger.lifecycle("TriggerChecker WARN: Trigger ${trigger.name} in Workflow ${workflow.name} defines 'maxWaitMins' when there are no dependencies. Azkaban will automatically launch the flow when the schedule is met, so this isn't necessary.");
+    }
 
     return checkWaitMinsError;
   }