Skip to content

Commit 1514a81

Browse files
committed
HDFS-6096. TestWebHdfsTokens may timeout. (Contributed by szetszwo)
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1576999 13f79535-47bb-0310-9956-ffa450edef68
1 parent fd9c201 commit 1514a81

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -603,6 +603,8 @@ Release 2.4.0 - UNRELEASED
603603
HDFS-5705. TestSecondaryNameNodeUpgrade#testChangeNsIDFails may fail due
604604
to ConcurrentModificationException. (Ted Yu via brandonli)
605605

606+
HDFS-6096. TestWebHdfsTokens may timeout. (szetszwo via Arpit Agarwal)
607+
606608
BREAKDOWN OF HDFS-5698 SUBTASKS AND RELATED JIRAS
607609

608610
HDFS-5717. Save FSImage header in protobuf. (Haohui Mai via jing9)

hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsTokens.java

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
import java.net.URI;
3434

3535
import org.apache.hadoop.conf.Configuration;
36-
import org.apache.hadoop.hdfs.security.token.delegation.DelegationTokenIdentifier;
3736
import org.apache.hadoop.hdfs.web.resources.DeleteOpParam;
3837
import org.apache.hadoop.hdfs.web.resources.GetOpParam;
3938
import org.apache.hadoop.hdfs.web.resources.HttpOpParam;
@@ -64,11 +63,10 @@ private WebHdfsFileSystem spyWebhdfsInSecureSetup() throws IOException {
6463
return fs;
6564
}
6665

67-
@SuppressWarnings("unchecked")
68-
@Test(timeout = 1000)
66+
@Test(timeout = 5000)
6967
public void testTokenForNonTokenOp() throws IOException {
7068
WebHdfsFileSystem fs = spyWebhdfsInSecureSetup();
71-
Token<DelegationTokenIdentifier> token = mock(Token.class);
69+
Token<?> token = mock(Token.class);
7270
doReturn(token).when(fs).getDelegationToken(null);
7371

7472
// should get/set/renew token
@@ -85,22 +83,21 @@ public void testTokenForNonTokenOp() throws IOException {
8583
verify(fs, never()).setDelegationToken(token);
8684
}
8785

88-
@Test(timeout = 1000)
86+
@Test(timeout = 5000)
8987
public void testNoTokenForGetToken() throws IOException {
9088
checkNoTokenForOperation(GetOpParam.Op.GETDELEGATIONTOKEN);
9189
}
9290

93-
@Test(timeout = 1000)
91+
@Test(timeout = 5000)
9492
public void testNoTokenForCanclToken() throws IOException {
9593
checkNoTokenForOperation(PutOpParam.Op.RENEWDELEGATIONTOKEN);
9694
}
9795

98-
@Test(timeout = 1000)
96+
@Test(timeout = 5000)
9997
public void testNoTokenForCancelToken() throws IOException {
10098
checkNoTokenForOperation(PutOpParam.Op.CANCELDELEGATIONTOKEN);
10199
}
102100

103-
@SuppressWarnings("unchecked")
104101
private void checkNoTokenForOperation(HttpOpParam.Op op) throws IOException {
105102
WebHdfsFileSystem fs = spyWebhdfsInSecureSetup();
106103
doReturn(null).when(fs).getDelegationToken(null);
@@ -110,7 +107,7 @@ private void checkNoTokenForOperation(HttpOpParam.Op op) throws IOException {
110107
fs.toUrl(op, null);
111108
verify(fs, never()).getDelegationToken();
112109
verify(fs, never()).getDelegationToken(null);
113-
verify(fs, never()).setDelegationToken(any(Token.class));
110+
verify(fs, never()).setDelegationToken((Token<?>)any(Token.class));
114111
}
115112

116113
@Test(timeout = 1000)

0 commit comments

Comments
 (0)