Skip to content

Commit 30f7bba

Browse files
Add on demand feature views deletion (feast-dev#2203)
Signed-off-by: corentinmarek <[email protected]>
1 parent 4c32d75 commit 30f7bba

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

sdk/python/feast/registry.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -667,6 +667,18 @@ def delete_feature_view(self, name: str, project: str, commit: bool = True):
667667
self.commit()
668668
return
669669

670+
for idx, existing_on_demand_feature_view_proto in enumerate(
671+
self.cached_registry_proto.on_demand_feature_views
672+
):
673+
if (
674+
existing_on_demand_feature_view_proto.spec.name == name
675+
and existing_on_demand_feature_view_proto.spec.project == project
676+
):
677+
del self.cached_registry_proto.on_demand_feature_views[idx]
678+
if commit:
679+
self.commit()
680+
return
681+
670682
raise FeatureViewNotFoundException(name, project)
671683

672684
def delete_entity(self, name: str, project: str, commit: bool = True):

0 commit comments

Comments
 (0)