Unit tests for processProtectedData() (#367)

Author: cedric25

packages/sdk/src/lib/dataProtectorCore/processProtectedData.ts

@@ -33,10 +33,12 @@ import { IExecConsumer } from '../types/internalTypes.js';
 import { getWhitelistContract } from './smartContract/getWhitelistContract.js';
 import { isAddressInWhitelist } from './smartContract/whitelistContract.read.js';
 
+export type ProcessProtectedData = typeof processProtectedData;
+
 export const processProtectedData = async ({
   iexec = throwIfMissing(),
-  protectedData = throwIfMissing(),
-  app = throwIfMissing(),
+  protectedData,
+  app,
   userWhitelist,
   maxPrice = DEFAULT_MAX_PRICE,
   args,
@@ -46,14 +48,14 @@ export const processProtectedData = async ({
   onStatusUpdate = () => {},
 }: IExecConsumer &
   ProcessProtectedDataParams): Promise<ProcessProtectedDataResponse> => {
-  const vApp = addressOrEnsSchema()
-    .required()
-    .label('authorizedApp')
-    .validateSync(app);
   const vProtectedData = addressOrEnsSchema()
     .required()
     .label('protectedData')
     .validateSync(protectedData);
+  const vApp = addressOrEnsSchema()
+    .required()
+    .label('authorizedApp')
+    .validateSync(app);
   const vUserWhitelist = addressSchema()
     .label('userWhitelist')
     .validateSync(userWhitelist);
@@ -96,7 +98,7 @@ export const processProtectedData = async ({
 
         if (!isRequesterInWhitelist) {
           throw new Error(
-            `As a user, you are not in the whitelist. So you can't access to the protectedData in order process it`
+            "As a user, you are not in the whitelist. You can't access the protectedData so you can't process it."
           );
         }
         requester = vUserWhitelist;
@@ -244,6 +246,7 @@ export const processProtectedData = async ({
       result,
     };
   } catch (error) {
+    console.error('[processProtectedData] ERROR', error);
     handleIfProtocolError(error);
     throw new WorkflowError({
       message: processProtectedDataErrorMessage,

packages/sdk/src/utils/validators.ts

@@ -97,7 +97,8 @@ export const grantedAccessSchema = () =>
     .noUnknown()
     .default(undefined);
 
-export const urlArraySchema = () => array().of(urlSchema());
+export const urlArraySchema = () =>
+  array().of(string().matches(/^http[s]?:\/\//, '${value} should be a url'));
 
 export const secretsSchema = () =>
   object().test(