Remove deprecated REST endpoints in TaskController (#731)

Author: jbern0rd

CHANGELOG.md

@@ -11,7 +11,8 @@ All notable changes to this project will be documented in this file.
 
 ### Breaking API changes
 
-- Remove deprecated blockhainAdapterUrl field from PublicConfiguration. (#729)
+- Remove deprecated blockhainAdapterUrl field from PublicConfiguration. (#730)
+- Remove deprecated REST endpoints in TaskController. (#731)
 
 ### Dependency Upgrades
 

src/main/java/com/iexec/core/task/TaskController.java

@@ -118,17 +118,6 @@ ReplicateModel buildReplicateModel(Replicate replicate) {
         return replicateModel;
     }
 
-    /**
-     * @deprecated Use {@code /tasks/{chainTaskId}/logs} instead
-     */
-    @Deprecated(forRemoval = true)
-    @GetMapping("/tasks/{chainTaskId}/stdout")
-    public ResponseEntity<TaskLogsModel> getTaskLogsLegacy(
-            @PathVariable("chainTaskId") String chainTaskId,
-            @RequestHeader("Authorization") String authorization) {
-        return getTaskLogs(chainTaskId, authorization);
-    }
-
     @GetMapping("/tasks/{chainTaskId}/logs")
     public ResponseEntity<TaskLogsModel> getTaskLogs(
             @PathVariable("chainTaskId") String chainTaskId,
@@ -153,18 +142,6 @@ public ResponseEntity<TaskLogsModel> getTaskLogs(
                 .orElse(ResponseEntity.notFound().build());
     }
 
-    /**
-     * @deprecated Use {@code /tasks/{chainTaskId}/replicates/{walletAddress}/logs} instead
-     */
-    @Deprecated(forRemoval = true)
-    @GetMapping("/tasks/{chainTaskId}/replicates/{walletAddress}/stdout")
-    public ResponseEntity<ComputeLogs> getComputeLogsLegacy(
-            @PathVariable("chainTaskId") String chainTaskId,
-            @PathVariable("walletAddress") String walletAddress,
-            @RequestHeader("Authorization") String authorization) {
-        return getComputeLogs(chainTaskId, walletAddress, authorization);
-    }
-
     @GetMapping("/tasks/{chainTaskId}/replicates/{walletAddress}/logs")
     public ResponseEntity<ComputeLogs> getComputeLogs(
             @PathVariable("chainTaskId") String chainTaskId,

src/test/java/com/iexec/core/task/TaskControllerTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2022-2024 IEXEC BLOCKCHAIN TECH
+ * Copyright 2022-2025 IEXEC BLOCKCHAIN TECH
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -92,24 +92,6 @@ String generateWalletAddress() {
     }
     //endregion
 
-    // region deprecated methods, to remove in future version
-    @Test
-    void shouldCallGetTaskLogs() {
-        final TaskController controller = spy(taskController);
-        final String authorization = String.join("_", challenge.getHash(), signature, requesterAddress);
-        controller.getTaskLogsLegacy(TASK_ID, authorization);
-        verify(controller).getTaskLogs(TASK_ID, authorization);
-    }
-
-    @Test
-    void shouldCallGetComputeLogs() {
-        final TaskController controller = spy(taskController);
-        final String authorization = String.join("_", challenge.getHash(), signature, requesterAddress);
-        controller.getComputeLogsLegacy(TASK_ID, WORKER_ADDRESS, authorization);
-        verify(controller).getComputeLogs(TASK_ID, WORKER_ADDRESS, authorization);
-    }
-    // endregion
-
     //region getChallenge
     @Test
     void shouldGetChallenge() {