Skip to content

Commit 5fbfb5d

Browse files
author
Hunter Skrasek
committed
Revert "Aim to fix a bug which caused exception responses to be logged, and"
This reverts commit 0c7e146.
1 parent cc21964 commit 5fbfb5d

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

src/Routing/Router.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -580,6 +580,10 @@ public function dispatch(Request $request)
580580
if ($request instanceof InternalRequest) {
581581
throw $exception;
582582
}
583+
584+
$this->exception->report($exception);
585+
586+
$response = $this->exception->handle($exception);
583587
}
584588

585589
return $this->prepareResponse($response, $request, $request->format());

tests/Routing/RouterTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,6 @@ public function testRouterHandlesCustomEtag()
244244

245245
public function testExceptionsAreHandledByExceptionHandler()
246246
{
247-
$this->markTestIncomplete('Test does not fully reflect adapters route handling, needs work.');
248247
$exception = new HttpException(400);
249248

250249
$this->router->version('v1', function () use ($exception) {

0 commit comments

Comments
 (0)