Skip to content

Commit b3fd610

Browse files
closing cursor
1 parent 03d6cf5 commit b3fd610

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

pyora.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717

1818
class Checks(object):
19-
2019
def check_active(self):
2120
"""Check Intance is active and open"""
2221
sql = "select to_char(case when inst_cnt > 0 then 1 else 0 end, \
@@ -370,7 +369,7 @@ def latchfree(self):
370369

371370
def tablespace(self, name):
372371
"""Get tablespace usage"""
373-
sql='''SELECT tablespace_name,
372+
sql = '''SELECT tablespace_name,
374373
100-(TRUNC((max_free_mb/max_size_mb) * 100)) AS USED
375374
FROM ( SELECT a.tablespace_name,b.size_mb,a.free_mb,b.max_size_mb,a.free_mb + (b.max_size_mb - b.size_mb) AS max_free_mb
376375
FROM (SELECT tablespace_name,TRUNC(SUM(bytes)/1024/1024) AS free_mb FROM dba_free_space GROUP BY tablespace_name) a,
@@ -567,6 +566,7 @@ def db_connect(self):
567566
self.cur = self.db.cursor()
568567

569568
def db_close(self):
569+
self.cur.close()
570570
self.db.close()
571571

572572
def __call__(self):
@@ -579,9 +579,9 @@ def __call__(self):
579579
finally:
580580
self.db_close()
581581
except Exception, err:
582-
#print 0
583-
#print str(err)
584-
pass
582+
print 0
583+
print str(err)
584+
585585

586586
if __name__ == "__main__":
587587
main = Main()

0 commit comments

Comments
 (0)