Skip to content

Commit fbb40df

Browse files
authored
Simplify generated extension range checks. (apple#348)
* Generate case ranges instead of conditionals for extension ranges. * Regenerate protos. * Regenerate reference protos.
1 parent 034ca01 commit fbb40df

21 files changed

+259
-223
lines changed

Reference/google/protobuf/descriptor.pb.swift

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -2185,9 +2185,9 @@ struct Google_Protobuf_FileOptions: SwiftProtobuf.Proto2Message, SwiftProtobuf.E
21852185
case 37: try decoder.decodeSingularStringField(value: &_csharpNamespace)
21862186
case 39: try decoder.decodeSingularStringField(value: &_swiftPrefix)
21872187
case 999: try decoder.decodeRepeatedMessageField(value: &uninterpretedOption)
2188-
default: if (1000 <= fieldNumber && fieldNumber < 536870912) {
2189-
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: Google_Protobuf_FileOptions.self, fieldNumber: fieldNumber)
2190-
}
2188+
case 1000..<536870912:
2189+
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: Google_Protobuf_FileOptions.self, fieldNumber: fieldNumber)
2190+
default: break
21912191
}
21922192
}
21932193

@@ -2422,9 +2422,9 @@ struct Google_Protobuf_MessageOptions: SwiftProtobuf.Proto2Message, SwiftProtobu
24222422
case 3: try decoder.decodeSingularBoolField(value: &_deprecated)
24232423
case 7: try decoder.decodeSingularBoolField(value: &_mapEntry)
24242424
case 999: try decoder.decodeRepeatedMessageField(value: &uninterpretedOption)
2425-
default: if (1000 <= fieldNumber && fieldNumber < 536870912) {
2426-
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: Google_Protobuf_MessageOptions.self, fieldNumber: fieldNumber)
2427-
}
2425+
case 1000..<536870912:
2426+
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: Google_Protobuf_MessageOptions.self, fieldNumber: fieldNumber)
2427+
default: break
24282428
}
24292429
}
24302430

@@ -2726,9 +2726,9 @@ struct Google_Protobuf_FieldOptions: SwiftProtobuf.Proto2Message, SwiftProtobuf.
27262726
case 3: try decoder.decodeSingularBoolField(value: &_deprecated)
27272727
case 10: try decoder.decodeSingularBoolField(value: &_weak)
27282728
case 999: try decoder.decodeRepeatedMessageField(value: &uninterpretedOption)
2729-
default: if (1000 <= fieldNumber && fieldNumber < 536870912) {
2730-
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: Google_Protobuf_FieldOptions.self, fieldNumber: fieldNumber)
2731-
}
2729+
case 1000..<536870912:
2730+
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: Google_Protobuf_FieldOptions.self, fieldNumber: fieldNumber)
2731+
default: break
27322732
}
27332733
}
27342734

@@ -2825,9 +2825,9 @@ struct Google_Protobuf_OneofOptions: SwiftProtobuf.Proto2Message, SwiftProtobuf.
28252825
mutating func _protobuf_generated_decodeField<D: SwiftProtobuf.Decoder>(decoder: inout D, fieldNumber: Int) throws {
28262826
switch fieldNumber {
28272827
case 999: try decoder.decodeRepeatedMessageField(value: &uninterpretedOption)
2828-
default: if (1000 <= fieldNumber && fieldNumber < 536870912) {
2829-
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: Google_Protobuf_OneofOptions.self, fieldNumber: fieldNumber)
2830-
}
2828+
case 1000..<536870912:
2829+
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: Google_Protobuf_OneofOptions.self, fieldNumber: fieldNumber)
2830+
default: break
28312831
}
28322832
}
28332833

@@ -2934,9 +2934,9 @@ struct Google_Protobuf_EnumOptions: SwiftProtobuf.Proto2Message, SwiftProtobuf.E
29342934
case 2: try decoder.decodeSingularBoolField(value: &_allowAlias)
29352935
case 3: try decoder.decodeSingularBoolField(value: &_deprecated)
29362936
case 999: try decoder.decodeRepeatedMessageField(value: &uninterpretedOption)
2937-
default: if (1000 <= fieldNumber && fieldNumber < 536870912) {
2938-
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: Google_Protobuf_EnumOptions.self, fieldNumber: fieldNumber)
2939-
}
2937+
case 1000..<536870912:
2938+
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: Google_Protobuf_EnumOptions.self, fieldNumber: fieldNumber)
2939+
default: break
29402940
}
29412941
}
29422942

@@ -3035,9 +3035,9 @@ struct Google_Protobuf_EnumValueOptions: SwiftProtobuf.Proto2Message, SwiftProto
30353035
switch fieldNumber {
30363036
case 1: try decoder.decodeSingularBoolField(value: &_deprecated)
30373037
case 999: try decoder.decodeRepeatedMessageField(value: &uninterpretedOption)
3038-
default: if (1000 <= fieldNumber && fieldNumber < 536870912) {
3039-
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: Google_Protobuf_EnumValueOptions.self, fieldNumber: fieldNumber)
3040-
}
3038+
case 1000..<536870912:
3039+
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: Google_Protobuf_EnumValueOptions.self, fieldNumber: fieldNumber)
3040+
default: break
30413041
}
30423042
}
30433043

@@ -3137,9 +3137,9 @@ struct Google_Protobuf_ServiceOptions: SwiftProtobuf.Proto2Message, SwiftProtobu
31373137
switch fieldNumber {
31383138
case 33: try decoder.decodeSingularBoolField(value: &_deprecated)
31393139
case 999: try decoder.decodeRepeatedMessageField(value: &uninterpretedOption)
3140-
default: if (1000 <= fieldNumber && fieldNumber < 536870912) {
3141-
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: Google_Protobuf_ServiceOptions.self, fieldNumber: fieldNumber)
3142-
}
3140+
case 1000..<536870912:
3141+
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: Google_Protobuf_ServiceOptions.self, fieldNumber: fieldNumber)
3142+
default: break
31433143
}
31443144
}
31453145

@@ -3295,9 +3295,9 @@ struct Google_Protobuf_MethodOptions: SwiftProtobuf.Proto2Message, SwiftProtobuf
32953295
case 33: try decoder.decodeSingularBoolField(value: &_deprecated)
32963296
case 34: try decoder.decodeSingularEnumField(value: &_idempotencyLevel)
32973297
case 999: try decoder.decodeRepeatedMessageField(value: &uninterpretedOption)
3298-
default: if (1000 <= fieldNumber && fieldNumber < 536870912) {
3299-
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: Google_Protobuf_MethodOptions.self, fieldNumber: fieldNumber)
3300-
}
3298+
case 1000..<536870912:
3299+
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: Google_Protobuf_MethodOptions.self, fieldNumber: fieldNumber)
3300+
default: break
33013301
}
33023302
}
33033303

Reference/google/protobuf/unittest.pb.swift

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4618,9 +4618,9 @@ struct ProtobufUnittest_TestFieldOrderings: SwiftProtobuf.Proto2Message, SwiftPr
46184618
case 1: try decoder.decodeSingularInt64Field(value: &_storage._myInt)
46194619
case 101: try decoder.decodeSingularFloatField(value: &_storage._myFloat)
46204620
case 200: try decoder.decodeSingularMessageField(value: &_storage._optionalNestedMessage)
4621-
default: if (2 <= fieldNumber && fieldNumber < 11) || (12 <= fieldNumber && fieldNumber < 101) {
4622-
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: ProtobufUnittest_TestFieldOrderings.self, fieldNumber: fieldNumber)
4623-
}
4621+
case 2..<11, 12..<101:
4622+
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: ProtobufUnittest_TestFieldOrderings.self, fieldNumber: fieldNumber)
4623+
default: break
46244624
}
46254625
}
46264626

@@ -8501,9 +8501,9 @@ struct ProtobufUnittest_TestParsingMerge: SwiftProtobuf.Proto2Message, SwiftProt
85018501
case 3: try decoder.decodeRepeatedMessageField(value: &_storage._repeatedAllTypes)
85028502
case 10: try decoder.decodeSingularGroupField(value: &_storage._optionalGroup)
85038503
case 20: try decoder.decodeRepeatedGroupField(value: &_storage._repeatedGroup)
8504-
default: if (1000 <= fieldNumber && fieldNumber < 536870912) {
8505-
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: ProtobufUnittest_TestParsingMerge.self, fieldNumber: fieldNumber)
8506-
}
8504+
case 1000..<536870912:
8505+
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: ProtobufUnittest_TestParsingMerge.self, fieldNumber: fieldNumber)
8506+
default: break
85078507
}
85088508
}
85098509

@@ -9298,9 +9298,9 @@ struct ProtobufUnittest_TestHugeFieldNumbers: SwiftProtobuf.Proto2Message, Swift
92989298
try decoder.handleConflictingOneOf()
92999299
}
93009300
_storage._oneofField = try ProtobufUnittest_TestHugeFieldNumbers.OneOf_OneofField(byDecodingFrom: &decoder, fieldNumber: fieldNumber)
9301-
default: if (536860000 <= fieldNumber && fieldNumber < 536870000) {
9302-
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: ProtobufUnittest_TestHugeFieldNumbers.self, fieldNumber: fieldNumber)
9303-
}
9301+
case 536860000..<536870000:
9302+
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: ProtobufUnittest_TestHugeFieldNumbers.self, fieldNumber: fieldNumber)
9303+
default: break
93049304
}
93059305
}
93069306

Reference/google/protobuf/unittest_custom_options.pb.swift

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -667,9 +667,9 @@ struct ProtobufUnittest_ComplexOptionType1: SwiftProtobuf.Proto2Message, SwiftPr
667667
case 2: try decoder.decodeSingularInt32Field(value: &_foo2)
668668
case 3: try decoder.decodeSingularInt32Field(value: &_foo3)
669669
case 4: try decoder.decodeRepeatedInt32Field(value: &foo4)
670-
default: if (100 <= fieldNumber && fieldNumber < 536870912) {
671-
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: ProtobufUnittest_ComplexOptionType1.self, fieldNumber: fieldNumber)
672-
}
670+
case 100..<536870912:
671+
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: ProtobufUnittest_ComplexOptionType1.self, fieldNumber: fieldNumber)
672+
default: break
673673
}
674674
}
675675

@@ -886,9 +886,9 @@ struct ProtobufUnittest_ComplexOptionType2: SwiftProtobuf.Proto2Message, SwiftPr
886886
case 2: try decoder.decodeSingularInt32Field(value: &_storage._baz)
887887
case 3: try decoder.decodeSingularMessageField(value: &_storage._fred)
888888
case 4: try decoder.decodeRepeatedMessageField(value: &_storage._barney)
889-
default: if (100 <= fieldNumber && fieldNumber < 536870912) {
890-
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: ProtobufUnittest_ComplexOptionType2.self, fieldNumber: fieldNumber)
891-
}
889+
case 100..<536870912:
890+
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: ProtobufUnittest_ComplexOptionType2.self, fieldNumber: fieldNumber)
891+
default: break
892892
}
893893
}
894894

Reference/google/protobuf/unittest_lite.pb.swift

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2839,9 +2839,9 @@ struct ProtobufUnittest_TestParsingMergeLite: SwiftProtobuf.Proto2Message, Swift
28392839
case 3: try decoder.decodeRepeatedMessageField(value: &_storage._repeatedAllTypes)
28402840
case 10: try decoder.decodeSingularGroupField(value: &_storage._optionalGroup)
28412841
case 20: try decoder.decodeRepeatedGroupField(value: &_storage._repeatedGroup)
2842-
default: if (1000 <= fieldNumber && fieldNumber < 536870912) {
2843-
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: ProtobufUnittest_TestParsingMergeLite.self, fieldNumber: fieldNumber)
2844-
}
2842+
case 1000..<536870912:
2843+
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: ProtobufUnittest_TestParsingMergeLite.self, fieldNumber: fieldNumber)
2844+
default: break
28452845
}
28462846
}
28472847

@@ -3515,9 +3515,9 @@ struct ProtobufUnittest_TestHugeFieldNumbersLite: SwiftProtobuf.Proto2Message, S
35153515
try decoder.handleConflictingOneOf()
35163516
}
35173517
_storage._oneofField = try ProtobufUnittest_TestHugeFieldNumbersLite.OneOf_OneofField(byDecodingFrom: &decoder, fieldNumber: fieldNumber)
3518-
default: if (536860000 <= fieldNumber && fieldNumber < 536870000) {
3519-
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: ProtobufUnittest_TestHugeFieldNumbersLite.self, fieldNumber: fieldNumber)
3520-
}
3518+
case 536860000..<536870000:
3519+
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: ProtobufUnittest_TestHugeFieldNumbersLite.self, fieldNumber: fieldNumber)
3520+
default: break
35213521
}
35223522
}
35233523

Reference/google/protobuf/unittest_no_generic_services.pb.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -117,9 +117,9 @@ struct Google_Protobuf_NoGenericServicesTest_TestMessage: SwiftProtobuf.Proto2Me
117117
mutating func _protobuf_generated_decodeField<D: SwiftProtobuf.Decoder>(decoder: inout D, fieldNumber: Int) throws {
118118
switch fieldNumber {
119119
case 1: try decoder.decodeSingularInt32Field(value: &_a)
120-
default: if (1000 <= fieldNumber && fieldNumber < 536870912) {
121-
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: Google_Protobuf_NoGenericServicesTest_TestMessage.self, fieldNumber: fieldNumber)
122-
}
120+
case 1000..<536870912:
121+
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: Google_Protobuf_NoGenericServicesTest_TestMessage.self, fieldNumber: fieldNumber)
122+
default: break
123123
}
124124
}
125125

Reference/google/protobuf/unittest_optimize_for.pb.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -235,9 +235,9 @@ struct ProtobufUnittest_TestOptimizedForSize: SwiftProtobuf.Proto2Message, Swift
235235
try decoder.handleConflictingOneOf()
236236
}
237237
_storage._foo = try ProtobufUnittest_TestOptimizedForSize.OneOf_Foo(byDecodingFrom: &decoder, fieldNumber: fieldNumber)
238-
default: if (1000 <= fieldNumber && fieldNumber < 536870912) {
239-
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: ProtobufUnittest_TestOptimizedForSize.self, fieldNumber: fieldNumber)
240-
}
238+
case 1000..<536870912:
239+
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: ProtobufUnittest_TestOptimizedForSize.self, fieldNumber: fieldNumber)
240+
default: break
241241
}
242242
}
243243

Reference/unittest_swift_extension.pb.swift

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -86,9 +86,9 @@ struct ProtobufUnittest_Extend_Foo: SwiftProtobuf.Proto2Message, SwiftProtobuf._
8686
mutating func _protobuf_generated_decodeField<D: SwiftProtobuf.Decoder>(decoder: inout D, fieldNumber: Int) throws {
8787
switch fieldNumber {
8888
case 1: try decoder.decodeSingularInt32Field(value: &_a)
89-
default: if (100 <= fieldNumber && fieldNumber < 1001) {
90-
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: Baz.self, fieldNumber: fieldNumber)
91-
}
89+
case 100..<1001:
90+
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: Baz.self, fieldNumber: fieldNumber)
91+
default: break
9292
}
9393
}
9494

@@ -396,9 +396,9 @@ struct ProtobufUnittest_Extend_MsgNoStorage: SwiftProtobuf.Proto2Message, SwiftP
396396
mutating func _protobuf_generated_decodeField<D: SwiftProtobuf.Decoder>(decoder: inout D, fieldNumber: Int) throws {
397397
switch fieldNumber {
398398
case 1: try decoder.decodeSingularInt32Field(value: &_x)
399-
default: if (100 <= fieldNumber && fieldNumber < 201) {
400-
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: ProtobufUnittest_Extend_MsgNoStorage.self, fieldNumber: fieldNumber)
401-
}
399+
case 100..<201:
400+
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: ProtobufUnittest_Extend_MsgNoStorage.self, fieldNumber: fieldNumber)
401+
default: break
402402
}
403403
}
404404

@@ -521,9 +521,9 @@ struct ProtobufUnittest_Extend_MsgUsesStorage: SwiftProtobuf.Proto2Message, Swif
521521
switch fieldNumber {
522522
case 1: try decoder.decodeSingularInt32Field(value: &_storage._x)
523523
case 2: try decoder.decodeSingularMessageField(value: &_storage._y)
524-
default: if (100 <= fieldNumber && fieldNumber < 201) {
525-
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: ProtobufUnittest_Extend_MsgUsesStorage.self, fieldNumber: fieldNumber)
526-
}
524+
case 100..<201:
525+
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: ProtobufUnittest_Extend_MsgUsesStorage.self, fieldNumber: fieldNumber)
526+
default: break
527527
}
528528
}
529529

Reference/unittest_swift_fieldorder.pb.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -350,9 +350,9 @@ struct Swift_Protobuf_TestFieldOrderings: SwiftProtobuf.Proto2Message, SwiftProt
350350
}
351351
_storage._options = try Swift_Protobuf_TestFieldOrderings.OneOf_Options(byDecodingFrom: &decoder, fieldNumber: fieldNumber)
352352
case 200: try decoder.decodeSingularMessageField(value: &_storage._optionalNestedMessage)
353-
default: if (2 <= fieldNumber && fieldNumber < 9) || (12 <= fieldNumber && fieldNumber < 56) {
354-
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: Swift_Protobuf_TestFieldOrderings.self, fieldNumber: fieldNumber)
355-
}
353+
case 2..<9, 12..<56:
354+
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: Swift_Protobuf_TestFieldOrderings.self, fieldNumber: fieldNumber)
355+
default: break
356356
}
357357
}
358358

Reference/unittest_swift_groups.pb.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,9 +87,9 @@ struct SwiftTestGroupExtensions: SwiftProtobuf.Proto2Message, SwiftProtobuf.Exte
8787
mutating func _protobuf_generated_decodeField<D: SwiftProtobuf.Decoder>(decoder: inout D, fieldNumber: Int) throws {
8888
switch fieldNumber {
8989
case 1: try decoder.decodeSingularInt32Field(value: &_a)
90-
default: if (2 <= fieldNumber && fieldNumber < 11) {
91-
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: SwiftTestGroupExtensions.self, fieldNumber: fieldNumber)
92-
}
90+
case 2..<11:
91+
try decoder.decodeExtensionField(values: &_extensionFieldValues, messageType: SwiftTestGroupExtensions.self, fieldNumber: fieldNumber)
92+
default: break
9393
}
9494
}
9595

0 commit comments

Comments
 (0)