Skip to content

Commit e7a87c4

Browse files
authored
Multi: Fixes for comments and duplicate selection options for Aurora and Media Convert examples. (awsdocs#6478)
* Fix duplicate version descriptions in aurora console app. * Python: Fixes for duplicate names in aurora console choices. * Fixes for mediaconvert snippet descriptions.
1 parent 0b22105 commit e7a87c4

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

.doc_gen/metadata/mediaconvert_metadata.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ mediaconvert_CreateJob:
2323
github: dotnetv3/MediaConvert
2424
sdkguide:
2525
excerpts:
26-
- description: Get the endpoint and set up the client.
26+
- description: Set up the file locations, client, and wrapper.
2727
snippet_tags:
2828
- MediaConvert.dotnetv3.Setup
2929
- description:
@@ -67,7 +67,7 @@ mediaconvert_ListJobs:
6767
github: dotnetv3/MediaConvert
6868
sdkguide:
6969
excerpts:
70-
- description: Get the endpoint and set up the client.
70+
- description: Set up the file locations, client, and wrapper.
7171
snippet_tags:
7272
- MediaConvert.dotnetv3.Setup
7373
- description: List the jobs with a particular status.
@@ -111,7 +111,7 @@ mediaconvert_GetJob:
111111
github: dotnetv3/MediaConvert
112112
sdkguide:
113113
excerpts:
114-
- description: Get the endpoint and set up the client.
114+
- description: Set up the file locations, client, and wrapper.
115115
snippet_tags:
116116
- MediaConvert.dotnetv3.Setup
117117
- description: Get a job by its ID.

dotnetv3/Aurora/Scenarios/AuroraScenario.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,7 @@ public static async Task<DBEngineVersion> ChooseDBEngineVersionAsync(string dbPa
279279
foreach (var version in allowedEngines)
280280
{
281281
Console.WriteLine(
282-
$"\t{i}. Engine: {version.Engine} Version {version.EngineVersion}.");
282+
$"\t{i}. {version.DBEngineVersionDescription}.");
283283
i++;
284284
}
285285

python/example_code/aurora/scenario_get_started_aurora.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ def create_cluster(self, cluster_name, db_engine, db_name, parameter_group):
127127
engine_versions = self.aurora_wrapper.get_engine_versions(
128128
db_engine, parameter_group["DBParameterGroupFamily"]
129129
)
130-
engine_choices = [ver["EngineVersion"] for ver in engine_versions]
130+
engine_choices = [ver["EngineVersionDescription"] for ver in engine_versions]
131131
print("The available engines for your parameter group are:")
132132
engine_index = q.choose("Which engine do you want to use? ", engine_choices)
133133
print(
@@ -142,7 +142,7 @@ def create_cluster(self, cluster_name, db_engine, db_name, parameter_group):
142142
parameter_group["DBClusterParameterGroupName"],
143143
db_name,
144144
db_engine,
145-
engine_choices[engine_index],
145+
engine_versions[engine_index]["EngineVersion"],
146146
admin_username,
147147
admin_password,
148148
)
@@ -173,15 +173,15 @@ def create_instance(self, cluster):
173173
inst_opts = self.aurora_wrapper.get_orderable_instances(
174174
cluster["Engine"], cluster["EngineVersion"]
175175
)
176-
inst_choices = list({opt["DBInstanceClass"] for opt in inst_opts})
176+
inst_choices = list({opt["DBInstanceClass"] + ", storage type: " + opt["StorageType"] for opt in inst_opts})
177177
inst_index = q.choose(
178178
"Which DB instance class do you want to use? ", inst_choices
179179
)
180180
print(
181181
f"Creating a database instance. This typically takes several minutes."
182182
)
183183
db_inst = self.aurora_wrapper.create_instance_in_cluster(
184-
cluster_name, cluster_name, cluster["Engine"], inst_choices[inst_index]
184+
cluster_name, cluster_name, cluster["Engine"], inst_opts[inst_index]["DBInstanceClass"]
185185
)
186186
while db_inst.get("DBInstanceStatus") != "available":
187187
wait(30)

0 commit comments

Comments
 (0)