tests: add Flask.logging.default_handler if not present

Author: zzacharo

tests/test_cmd.py

@@ -25,10 +25,12 @@
 
 from __future__ import absolute_import, print_function
 
+import logging
 import os
 from subprocess import call
 
 import pkg_resources
+import pytest
 from click.testing import CliRunner
 from flask.cli import ScriptInfo
 from mock import MagicMock, Mock, patch
@@ -37,6 +39,23 @@
 from invenio_base.cli import instance
 
 
+@pytest.fixture(autouse=True)
+def force_logging():
+    """Flask 0.13/1.0 changed logging to not add the default
+    handler in case a handler is already installed. pytest
+    automatically adds a handler to the root logger, causing
+    Flask not to add a handler. This is an issue when testing
+    Click output which uses the logger to output to the console.
+    """
+    try:
+        from flask.logging import default_handler
+        logger = logging.getLogger('flask.app')
+        if default_handler not in logger.handlers:
+            logger.handlers.append(default_handler)
+    except:
+        pass
+
+
 def test_instance_create():
     """Test ``instance create`` command."""
     runner = CliRunner()
@@ -69,22 +88,27 @@ def test_list_entry_points():
         assert lines[1] == '  inveniomanage = invenio_base.__main__:cli'
 
         # Test no entry point matching
-        result = runner.invoke(
-            instance, ['entrypoints', '-e', 'nothing_here'])
+        result = runner.invoke(instance, ['entrypoints', '-e', 'nothing_here'])
         assert result.exit_code == 0
         assert result.output == ""
 
         # By default we only show entry points groups starting with "invenio"
-        dist.get_entry_map = Mock(return_value={
-            'invenio_base.apps': {
-                'myapp': 'myapp = myapp:MyApp',
-                'app1': 'app1 = app1:MyApp'},
-            'invenio_base.api_apps': {
-                'myapi': 'myapi = myapi:MyApp'},
-            'console_scripts': {
-                'mycli': 'mycli = cli:main'},
-        })
-        result = runner.invoke(instance, ['entrypoints', ])
+        dist.get_entry_map = Mock(
+            return_value={
+                'invenio_base.apps': {
+                    'myapp': 'myapp = myapp:MyApp',
+                    'app1': 'app1 = app1:MyApp'
+                },
+                'invenio_base.api_apps': {
+                    'myapi': 'myapi = myapi:MyApp'
+                },
+                'console_scripts': {
+                    'mycli': 'mycli = cli:main'
+                },
+            })
+        result = runner.invoke(instance, [
+            'entrypoints',
+        ])
         assert result.exit_code == 0
         print(result.output.splitlines())
         lines = result.output.splitlines()
@@ -103,16 +127,15 @@ def _config_loader(app, **kwargs):
 
     create_app = create_app_factory('test', config_loader=_config_loader)
     app = create_app(KWARGS_TEST=True)
+
     script_info = ScriptInfo(create_app=lambda info: app)
 
     # Check that CLI command fails when the SECRET_KEY is not set.
     with app.app_context():
         runner = CliRunner()
-        result = runner.invoke(instance,
-                               ['migrate-secret-key',
-                                '--old-key',
-                                'OLD_SECRET_KEY'],
-                               obj=script_info)
+        result = runner.invoke(
+            instance, ['migrate-secret-key', '--old-key', 'OLD_SECRET_KEY'],
+            obj=script_info)
         assert result.exit_code == 1
         assert 'Error: SECRET_KEY is not set in the configuration.' in \
             result.output