Bug #32944543 USE FIL_SPACE_ACQUIRE_SILENT() INSTEAD OF FIL_SPACE_ACQUIRE() WHENEVER POSSIBLE

Problem:

To avoid generating unwanted warning messages in the server log, the function
fil_space_acquire_silent() needs to be used instead of fil_space_acquire()
whenever possible.  Identify the callers of fil_space_acquire() and check
what they do when the function returns nullptr.  If this doesn't result in an
error situation, then most likely the function fil_space_acquire_silent()
must be used.

Solution:

Use fil_space_acquire_silent() instead of fil_space_acquire() whenever
applicable.

rb#26320 in review by Marcin Babij <[email protected]>

Author: gurusami

storage/innobase/btr/btr0btr.cc

@@ -1062,7 +1062,7 @@ void btr_truncate(const dict_index_t *index) {
 
   page_no_t root_page_no = index->page;
   space_id_t space_id = index->space;
-  fil_space_t *space = fil_space_acquire(space_id);
+  fil_space_t *space = fil_space_acquire_silent(space_id);
 
   if (space == nullptr) {
     return;
@@ -1118,7 +1118,7 @@ void btr_truncate_recover(const dict_index_t *index) {
 
   page_no_t root_page_no = index->page;
   space_id_t space_id = index->space;
-  fil_space_t *space = fil_space_acquire(space_id);
+  fil_space_t *space = fil_space_acquire_silent(space_id);
 
   if (space == nullptr) {
     return;

storage/innobase/buf/buf0rea.cc

@@ -184,7 +184,7 @@ ulint buf_read_ahead_random(const page_id_t &page_id,
   /* Remember the tablespace version before we ask the tablespace size
   below: if DISCARD + IMPORT changes the actual .ibd file meanwhile, we
   do not try to read outside the bounds of the tablespace! */
-  if (fil_space_t *space = fil_space_acquire(page_id.space())) {
+  if (fil_space_t *space = fil_space_acquire_silent(page_id.space())) {
     if (high > space->size) {
       high = space->size;
     }
@@ -372,7 +372,7 @@ ulint buf_read_ahead_linear(const page_id_t &page_id,
   do not try to read outside the bounds of the tablespace! */
   ulint space_size;
 
-  if (fil_space_t *space = fil_space_acquire(page_id.space())) {
+  if (fil_space_t *space = fil_space_acquire_silent(page_id.space())) {
     space_size = space->size;
 
     fil_space_release(space);

storage/innobase/dict/dict0upgrade.cc

@@ -1290,7 +1290,7 @@ bool upgrade_space_version(const uint32 space_id, bool server_version_only) {
   page_t *page;
   mtr_t mtr;
 
-  fil_space_t *space = fil_space_acquire(space_id);
+  fil_space_t *space = fil_space_acquire_silent(space_id);
 
   if (space == nullptr) {
     return (true);

storage/innobase/ibuf/ibuf0ibuf.cc

@@ -4084,7 +4084,7 @@ void ibuf_merge_or_delete_for_page(buf_block_t *block, const page_id_t &page_id,
       return;
     }
 
-    space = fil_space_acquire(page_id.space());
+    space = fil_space_acquire_silent(page_id.space());
 
     if (space == nullptr) {
       /* Do not try to read the bitmap page from space;

storage/innobase/lock/lock0lock.cc

@@ -4708,7 +4708,7 @@ static bool lock_rec_fetch_page(const lock_t *lock) {
 
     /* Check if the space is exists or not. only
     when the space is valid, try to get the page. */
-    space = fil_space_acquire(space_id);
+    space = fil_space_acquire_silent(space_id);
     if (space) {
       mtr_start(&mtr);
       buf_page_get_gen(page_id, page_size, RW_NO_LATCH, nullptr,
@@ -5115,7 +5115,7 @@ static void lock_rec_block_validate(const page_id_t &page_id) {
 
   /* Make sure that the tablespace is not deleted while we are
   trying to access the page. */
-  if (fil_space_t *space = fil_space_acquire(page_id.space())) {
+  if (fil_space_t *space = fil_space_acquire_silent(page_id.space())) {
     mtr_start(&mtr);
 
     block = buf_page_get_gen(page_id, page_size_t(space->flags), RW_X_LATCH,