CDH-77708: Revert "CDH-61933: Prevent excessive logging of UnsupportedOperationException"

(cherry picked from commit b267252)
(cherry picked from commit 2a6b3aa)

This reverts commit 79f3445.

Change-Id: I169f1525b1e446f07d1a33886cd08e7335acbf02

Author: Sahil Takiar

hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfs-tests/test_libhdfs_ops.c

@@ -98,7 +98,7 @@ int main(int argc, char **argv) {
     if(!lfs) {
         fprintf(stderr, "Oops! Failed to connect to 'local' hdfs!\n");
         exit(-1);
-    }
+    } 
 
     {
         //Write tests
@@ -183,7 +183,7 @@ int main(int argc, char **argv) {
         }
         fprintf(stderr, "Current position: %" PRId64 "\n", currentPos);
 
-        if (hdfsFileUsesDirectRead(readFile)) {
+        if (!hdfsFileUsesDirectRead(readFile)) {
           fprintf(stderr, "Direct read support incorrectly not detected "
                   "for HDFS filesystem\n");
           exit(-1);
@@ -262,9 +262,8 @@ int main(int argc, char **argv) {
         totalResult += result;
         fprintf(stderr, "hdfsMove(local-local): %s\n", ((result = hdfsMove(lfs, srcPath, lfs, dstPath)) != 0 ? "Failed!" : "Success!"));
         totalResult += result;
-        // TODO fix failures later HDFS-14083.
-        // fprintf(stderr, "hdfsMove(remote-local): %s\n", ((result = hdfsMove(fs, srcPath, lfs, srcPath)) != 0 ? "Failed!" : "Success!"));
-        // totalResult += result;
+        fprintf(stderr, "hdfsMove(remote-local): %s\n", ((result = hdfsMove(fs, srcPath, lfs, srcPath)) != 0 ? "Failed!" : "Success!"));
+        totalResult += result;
 
         fprintf(stderr, "hdfsRename: %s\n", ((result = hdfsRename(fs, dstPath, srcPath)) != 0 ? "Failed!" : "Success!"));
         totalResult += result;
@@ -306,9 +305,7 @@ int main(int argc, char **argv) {
             totalResult++;
             fprintf(stderr, "waah! hdfsGetPathInfo for %s - FAILED!\n", slashTmp);
         }
-        exit(0);
 
-        // TODO fix failures later HDFS-14083.
         fileList = 0;
         fileList = hdfsListDirectory(fs, newDirectory, &numEntries);
         if (!(fileList == NULL && numEntries == 0 && !errno)) {
@@ -459,7 +456,7 @@ int main(int argc, char **argv) {
       fprintf(stderr, "Wrote %d bytes\n", num_written_bytes);
 
       if (hdfsFlush(fs, appendFile)) {
-        fprintf(stderr, "Failed to 'flush' %s\n", appendPath);
+        fprintf(stderr, "Failed to 'flush' %s\n", appendPath); 
         exit(-1);
       }
       fprintf(stderr, "Flushed %s successfully!\n", appendPath); 

hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfs/CMakeLists.txt

@@ -56,7 +56,6 @@ set_target_properties(hdfs PROPERTIES
 
 build_libhdfs_test(test_libhdfs_ops hdfs_static test_libhdfs_ops.c)
 link_libhdfs_test(test_libhdfs_ops hdfs_static ${JAVA_JVM_LIBRARY})
-add_libhdfs_test(test_libhdfs_ops hdfs_static)
 build_libhdfs_test(test_libhdfs_reads hdfs_static test_libhdfs_read.c)
 link_libhdfs_test(test_libhdfs_reads hdfs_static ${JAVA_JVM_LIBRARY})
 build_libhdfs_test(test_libhdfs_write hdfs_static test_libhdfs_write.c)

hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfs/exception.c

@@ -81,7 +81,7 @@ static const struct ExceptionInfo gExceptionInfo[] = {
     },
     {
         "java.lang.UnsupportedOperationException",
-        NOPRINT_EXC_OPERATION_NOTSUPPORTED,
+        0,
         ENOTSUP,
     },
     {

hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfs/exception.h

@@ -69,7 +69,6 @@
 #define NOPRINT_EXC_UNRESOLVED_LINK             0x04
 #define NOPRINT_EXC_PARENT_NOT_DIRECTORY        0x08
 #define NOPRINT_EXC_ILLEGAL_ARGUMENT            0x10
-#define NOPRINT_EXC_OPERATION_NOTSUPPORTED      0x20
 
 /**
  * Get information about an exception.

hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfs/hdfs.c

@@ -1497,21 +1497,9 @@ tSize readDirect(hdfsFS fs, hdfsFile f, void* buffer, tSize length)
         HADOOP_ISTRM, "read", "(Ljava/nio/ByteBuffer;)I", bb);
     destroyLocalReference(env, bb);
     if (jthr) {
-      if (f->flags & HDFS_FILE_SUPPORTS_DIRECT_READ) {
         errno = printExceptionAndFree(env, jthr, PRINT_EXC_ALL,
             "readDirect: FSDataInputStream#read");
-      } else {
-        // If the HDFS_FILE_SUPPORTS_DIRECT_READ is not set in the
-        // hdfs file handle, it means that this is a test to see if
-        // direct read can be done, called from hdfsOpenFIleImpl().
-        // In the cloud environment where byte buffered read is not
-        // supported the error log is filled with Exception of type
-        // UnspportedOperation. The change below prevents the excessive
-        // printing of the error message in cloud environment.
-        errno = printExceptionAndFree(env, jthr, NOPRINT_EXC_OPERATION_NOTSUPPORTED,
-              "readDirect: FSDataInputStream#read");
-      }
-      return -1;
+        return -1;
     }
     return (jVal.i < 0) ? 0 : jVal.i;
 }