Merge pull request react-native-camera#1814 from react-native-community/fix-ios-race-codition

n1ru4l · web-flow · commit 816e95bb28e1 · 2018-09-24T16:22:19.000+02:00
[ios] fix possible race condition in removeFromSuperview
diff --git a/ios/RN/RNCamera.m b/ios/RN/RNCamera.m
@@ -132,9 +132,9 @@ - (void)removeReactSubview:(UIView *)subview
 
 - (void)removeFromSuperview
 {
-    [self stopSession];
     [super removeFromSuperview];
     [[NSNotificationCenter defaultCenter] removeObserver:self name:UIDeviceOrientationDidChangeNotification object:nil];
+    [self stopSession];
 }
 
 -(void)updateType

Original file line number	Diff line number	Diff line change
`@@ -132,9 +132,9 @@ - (void)removeReactSubview:(UIView *)subview`
`132`	`132`
`133`	`133`	`- (void)removeFromSuperview`
`134`	`134`	`{`
`135`		`- [self stopSession];`
`136`	`135`	`[super removeFromSuperview];`
`137`	`136`	`[[NSNotificationCenter defaultCenter] removeObserver:self name:UIDeviceOrientationDidChangeNotification object:nil];`
	`137`	`+ [self stopSession];`
`138`	`138`	`}`
`139`	`139`
`140`	`140`	`-(void)updateType`