Fix failing scenarios in jruby

I'm not sure why but somehow some assertions don't seem to wait for the
content to appear in jruby. Migrating this tests to use a javascript
driver fixes it.

Furthermore, I think this is a good change (except for performance)
because this tests are actually supposed test js behaviour. The only
reason they were passing with a non-js driver is that they manually
simulate the js behaviour. See the "When I submit the batch action form"
step for an example. It's not testing the real behavior of the user, so
if any regressions are introduced where that stuff actually happens
(batch_actions.js.coffee), they won't be catched by the test.

Regarding the actual migration of the tests, it includes a couple of
changes to avoid using :contains or :first that are not valid css
selectors and are only working "by chance" (see [1], last comment) and a
rewrite of the previously mentioned step at a higher level to actually
trigger the js that is being tested.

[1]: teampoltergeist/poltergeist#323

Author: David Rodríguez

features/index/batch_actions.feature

@@ -1,5 +1,6 @@
 Feature: Batch Actions
 
+  @javascript
   Scenario: Use default (destroy) batch action
     Given 10 posts exist
     And an index configuration of:
@@ -16,7 +17,7 @@ Feature: Batch Actions
     And I follow "Batch Actions"
     Then I should see the batch action :destroy "Delete Selected"
 
-    Given I submit the batch action form with "destroy"
+    Given I click "Delete Selected" and accept confirmation
     Then I should see a flash with "Successfully destroyed 2 posts"
     And I should see 8 posts in the table
 
@@ -37,6 +38,7 @@ Feature: Batch Actions
     Then I should see a flash with "Successfully destroyed 2 posts"
     And I should see 3 posts in the table
 
+  @javascript
   Scenario: Use default (destroy) batch action on a nested resource
     Given I am logged in
     And 5 posts written by "John Doe" exist
@@ -58,7 +60,7 @@ Feature: Batch Actions
     And I follow "Batch Actions"
     Then I should see the batch action :destroy "Delete Selected"
 
-    Given I submit the batch action form with "destroy"
+    Given I click "Delete Selected" and accept confirmation
     Then I should see a flash with "Successfully destroyed 2 posts"
     And I should see 3 posts in the table
 

features/step_definitions/batch_action_steps.rb

@@ -7,11 +7,11 @@
 end
 
 Then /^I (should|should not) see the batch action :([^\s]*) "([^"]*)"$/ do |maybe, sym, title|
-  selector = ".batch_actions_selector a.batch_action:contains('#{title}')"
+  selector = ".batch_actions_selector a.batch_action"
   selector << "[href='#'][data-action='#{sym}']" if maybe == 'should'
 
   verb = maybe == 'should' ? :to : :to_not
-  expect(page).send verb, have_css(selector)
+  expect(page).send verb, have_css(selector, text: title)
 end
 
 Then /^the (\d+)(?:st|nd|rd|th) batch action should be "([^"]*)"$/ do |index, title|
@@ -57,6 +57,15 @@
   page.driver.submit form['method'], form['action'], params
 end
 
+When /^I click "(.*?)" and accept confirmation$/ do |link|
+  # Use this implementation instead if poltergeist ever implements it
+  # page.driver.accept_modal(:confirm) { click_link(link) }
+
+  click_link(link)
+  expect(page).to have_content("Are you sure you want to delete these posts?")
+  click_button("OK")
+end
+
 Then /^I should not see checkboxes in the table$/ do
   expect(page).to_not have_css '.paginated_collection table input[type=checkbox]'
 end

features/step_definitions/table_steps.rb

@@ -1,5 +1,6 @@
 Then /^I should see (\d+) ([\w]*) in the table$/ do |count, resource_type|
-  expect(all("table.index_table tr > td:first").count).to eq count.to_i
+  expect(page).to \
+    have_css("table.index_table tr > td:first-child", count: count.to_i)
 end
 
 # TODO: simplify this, if possible?