Skip to content

Commit 41a964c

Browse files
committed
[ibm] Nullable formats for attributes that may not be returned
1 parent 7725d07 commit 41a964c

File tree

3 files changed

+11
-7
lines changed

3 files changed

+11
-7
lines changed

tests/ibm/requests/compute/address_tests.rb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,9 @@
88
"id" => String,
99
"mode" => Integer,
1010
"hostname" => String,
11-
"type" => Integer
11+
"type" => Integer,
12+
"instanceId" => Fog::Nullable::String,
13+
"vlan" => Fog::Nullable::String,
1214
}
1315

1416
# create_address doesn't return mode, hostname or type attributes

tests/ibm/requests/compute/image_tests.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,16 @@
55
'visibility' => String,
66
'platform' => String,
77
'owner' => String,
8-
'architecture' => String,
8+
'architecture' => Fog::Nullable::String,
99
'createdTime' => Integer,
1010
'location' => String,
1111
'productCodes' => Array,
1212
'name' => String,
1313
'id' => String,
1414
'description' => String,
1515
'supportedInstanceTypes' => Array,
16-
'manifest' => String,
17-
'documentation' => String
16+
'manifest' => Fog::Nullable::String,
17+
'documentation' => Fog::Nullable::String,
1818
}
1919

2020
# TODO: Actually check this format

tests/ibm/requests/compute/instance_tests.rb

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,18 @@
1414
'imageId' => String,
1515
'launchTime' => Integer,
1616
'id' => String,
17+
'ip' => Fog::Nullable::String,
1718
'volumes' => Array,
18-
'root-only' => String,
19+
'root-only' => Fog::Nullable::String,
1920
'instanceType' => String,
20-
'diskSize' => String,
21+
'diskSize' => Fog::Nullable::String,
2122
'requestName' => String,
2223
'secondaryIP' => Array,
2324
'status' => Integer,
2425
'software' => Array,
2526
'expirationTime'=> Integer,
26-
'owner' => String
27+
'owner' => String,
28+
'vlan' => Fog::Nullable::String,
2729
}
2830

2931
@instances_format = {

0 commit comments

Comments
 (0)