Open
Description
Hi, thank you for this library ;-) I see the following issues:
- function setTimerWidth (line 230):
The following block seems to have no effect (the variable "this->ticks" will never be changed) ... why is it there? What if widthDifference is negative ... do you really want to make such a bit shift?
if (widthDifference > 0)
{
this->ticks << widthDifference;
}
else
{
this->ticks >> widthDifference;
}
- Function "int Servo::attach(int pin, int min, int max)" ... there is a return value in case the first condition is ok ("if ((this->servoChannel <= MAX_SERVOS) && (this->servoChannel > 0))").
Bye,
Filip
Metadata
Metadata
Assignees
Labels
No labels