SERVER-14527 Do not setLastError in assert_util.

MongoD and MongoS set it explicitly for write commands and wire writes, and in the
forceerror command, which is better than invoking it every time an assertion is
thrown.  It prevents swallowed exceptions from being reported, and obviates the
LastError::Disabled type and "last error disabled" functionality in general.

Author: amschwerin

src/mongo/util/assert_util.cpp

@@ -39,7 +39,6 @@ using namespace std;
 #endif
 
 #include "mongo/bson/bsonobjbuilder.h"
-#include "mongo/db/lasterror.h"
 #include "mongo/util/stacktrace.h"
 
 namespace mongo {
@@ -111,7 +110,6 @@ namespace mongo {
 
         log() << "warning assertion failure " << msg << ' ' << file << ' ' << dec << line << endl;
         logContext();
-        setLastError(0,msg && *msg ? msg : "wassertion failure");
         assertionCount.condrollover( ++assertionCount.warning );
 #if defined(_DEBUG) || defined(_DURABLEDEFAULTON) || defined(_DURABLEDEFAULTOFF)
         // this is so we notice in buildbot
@@ -124,7 +122,6 @@ namespace mongo {
         assertionCount.condrollover( ++assertionCount.regular );
         log() << "Assertion failure " << msg << ' ' << file << ' ' << dec << line << endl;
         logContext();
-        setLastError(0,msg && *msg ? msg : "assertion failure");
         stringstream temp;
         temp << "assertion " << file << ":" << line;
         AssertionException e(temp.str(),0);
@@ -178,7 +175,6 @@ namespace mongo {
     NOINLINE_DECL void uasserted(int msgid, const char *msg) {
         assertionCount.condrollover( ++assertionCount.user );
         LOG(1) << "User Assertion: " << msgid << ":" << msg << endl;
-        setLastError(msgid,msg);
         throw UserException(msgid, msg);
     }
 
@@ -189,7 +185,6 @@ namespace mongo {
     NOINLINE_DECL void msgasserted(int msgid, const char *msg) {
         assertionCount.condrollover( ++assertionCount.warning );
         log() << "Assertion: " << msgid << ":" << msg << endl;
-        setLastError(msgid,msg && *msg ? msg : "massert failure");
         //breakpoint();
         logContext();
         throw MsgAssertionException(msgid, msg);
@@ -198,7 +193,6 @@ namespace mongo {
     NOINLINE_DECL void msgassertedNoTrace(int msgid, const char *msg) {
         assertionCount.condrollover( ++assertionCount.warning );
         log() << "Assertion: " << msgid << ":" << msg << endl;
-        setLastError(msgid,msg && *msg ? msg : "massert failure");
         throw MsgAssertionException(msgid, msg);
     }