test(test_init_command): test the json config behavior when the Init function is called

Author: danvergara

tests/commands/test_init_command.py

@@ -1,3 +1,4 @@
+import json
 import os
 
 import pytest
@@ -30,6 +31,14 @@ def ask(self):
     'tag_format = "$version"\n'
 )
 
+EXPECTED_JSON_CONFIG = {
+    "commitizen": {
+        "name": "cz_conventional_commits",
+        "version": "0.0.1",
+        "tag_format": "$version",
+    }
+}
+
 
 def test_init_without_setup_pre_commit_hook(tmpdir, mocker, config):
     mocker.patch(
@@ -85,47 +94,54 @@ def test_init_without_choosing_tag(config, mocker, tmpdir):
 
 
 class TestPreCommitCases:
-    @pytest.fixture(scope="function", autouse=True)
-    def default_choices(_, mocker):
+    @pytest.fixture(scope="function", params=["pyproject.toml", ".cz.json"])
+    def default_choice(_, request, mocker):
         mocker.patch(
             "questionary.select",
             side_effect=[
-                FakeQuestion("pyproject.toml"),
+                FakeQuestion(request.param),
                 FakeQuestion("cz_conventional_commits"),
             ],
         )
         mocker.patch("questionary.confirm", return_value=FakeQuestion(True))
         mocker.patch("questionary.text", return_value=FakeQuestion("$version"))
         mocker.patch("questionary.confirm", return_value=FakeQuestion(True))
+        return request.param
 
-    def test_no_existing_pre_commit_conifg(_, tmpdir, config):
+    def test_no_existing_pre_commit_json_conifg(_, default_choice, tmpdir, config):
         with tmpdir.as_cwd():
             commands.Init(config)()
 
-            with open("pyproject.toml", "r") as toml_file:
-                config_data = toml_file.read()
-            assert config_data == expected_config
+            with open(default_choice, "r") as file:
+                if "json" in default_choice:
+                    assert json.load(file) == EXPECTED_JSON_CONFIG
+                else:
+                    config_data = file.read()
+                    assert config_data == expected_config
 
             with open(pre_commit_config_filename, "r") as pre_commit_file:
                 pre_commit_config_data = yaml.safe_load(pre_commit_file.read())
             assert pre_commit_config_data == {"repos": [cz_hook_config]}
 
-    def test_empty_pre_commit_config(_, tmpdir, config):
+    def test_empty_pre_commit_config(_, default_choice, tmpdir, config):
         with tmpdir.as_cwd():
             p = tmpdir.join(pre_commit_config_filename)
             p.write("")
 
             commands.Init(config)()
 
-            with open("pyproject.toml", "r") as toml_file:
-                config_data = toml_file.read()
-            assert config_data == expected_config
+            with open(default_choice, "r") as file:
+                if "json" in default_choice:
+                    assert json.load(file) == EXPECTED_JSON_CONFIG
+                else:
+                    config_data = file.read()
+                    assert config_data == expected_config
 
             with open(pre_commit_config_filename, "r") as pre_commit_file:
                 pre_commit_config_data = yaml.safe_load(pre_commit_file.read())
             assert pre_commit_config_data == {"repos": [cz_hook_config]}
 
-    def test_pre_commit_config_without_cz_hook(_, tmpdir, config):
+    def test_pre_commit_config_without_cz_hook(_, default_choice, tmpdir, config):
         existing_hook_config = {
             "repo": "https://github.com/pre-commit/pre-commit-hooks",
             "rev": "v1.2.3",
@@ -138,26 +154,32 @@ def test_pre_commit_config_without_cz_hook(_, tmpdir, config):
 
             commands.Init(config)()
 
-            with open("pyproject.toml", "r") as toml_file:
-                config_data = toml_file.read()
-            assert config_data == expected_config
+            with open(default_choice, "r") as file:
+                if "json" in default_choice:
+                    assert json.load(file) == EXPECTED_JSON_CONFIG
+                else:
+                    config_data = file.read()
+                    assert config_data == expected_config
 
             with open(pre_commit_config_filename, "r") as pre_commit_file:
                 pre_commit_config_data = yaml.safe_load(pre_commit_file.read())
             assert pre_commit_config_data == {
                 "repos": [existing_hook_config, cz_hook_config]
             }
 
-    def test_cz_hook_exists_in_pre_commit_config(_, tmpdir, config):
+    def test_cz_hook_exists_in_pre_commit_config(_, default_choice, tmpdir, config):
         with tmpdir.as_cwd():
             p = tmpdir.join(pre_commit_config_filename)
             p.write(yaml.safe_dump({"repos": [cz_hook_config]}))
 
             commands.Init(config)()
 
-            with open("pyproject.toml", "r") as toml_file:
-                config_data = toml_file.read()
-            assert config_data == expected_config
+            with open(default_choice, "r") as file:
+                if "json" in default_choice:
+                    assert json.load(file) == EXPECTED_JSON_CONFIG
+                else:
+                    config_data = file.read()
+                    assert config_data == expected_config
 
             with open(pre_commit_config_filename, "r") as pre_commit_file:
                 pre_commit_config_data = yaml.safe_load(pre_commit_file.read())

tests/test_conf.py

@@ -149,4 +149,4 @@ def test_init_empty_config_content(self, tmpdir):
         json_config.init_empty_config_content()
 
         with open(path, "r") as json_file:
-            assert json.load(json_file) == {"commitizen": ""}
+            assert json.load(json_file) == {"commitizen": {}}