Merge pull request chriskacerguis#210 from mohabusama/master

Phil Sturgeon · Phil Sturgeon · commit cefa36a5feda · 2013-10-01T09:35:45.000-07:00
Escaping CSV headings
diff --git a/application/libraries/Format.php b/application/libraries/Format.php
@@ -197,7 +197,7 @@ public function to_csv()
 			$data = array($data);
 		}
 
-		$output = implode(',', $headings).PHP_EOL;
+		$output = '"'.implode('","', $headings).'"'.PHP_EOL;
 		foreach ($data as &$row)
 		{
 			$row = str_replace('"', '""', $row); // Escape dbl quotes per RFC 4180

Original file line number	Diff line number	Diff line change
`@@ -197,7 +197,7 @@ public function to_csv()`
`197`	`197`	`$data = array($data);`
`198`	`198`	`}`
`199`	`199`
`200`		`- $output = implode(',', $headings).PHP_EOL;`
	`200`	`+ $output = '"'.implode('","', $headings).'"'.PHP_EOL;`
`201`	`201`	`foreach ($data as &$row)`
`202`	`202`	`{`
`203`	`203`	`$row = str_replace('"', '""', $row); // Escape dbl quotes per RFC 4180`