Fixes analyzer issues

Author: flovilmart

Parse/Parse/Internal/Commands/PFRESTQueryCommand.m

@@ -202,7 +202,7 @@ + (nullable NSDictionary *)findCommandParametersWithOrder:(NSString *)order
         parameters[@"where"] = whereData;
     }
     if (encodingFailed && encodingError) {
-        *error = encodingError;
+        PFSetError(error, encodingError);
         return nil;
     }
 

Parse/Parse/Internal/KeyValueCache/PFKeyValueCache.h

@@ -35,7 +35,7 @@ NS_ASSUME_NONNULL_BEGIN
 #pragma mark - Getting
 ///--------------------------------------
 
-- (NSString *)objectForKey:(NSString *)key maxAge:(NSTimeInterval)age;
+- (nullable NSString *)objectForKey:(NSString *)key maxAge:(NSTimeInterval)age;
 
 ///--------------------------------------
 #pragma mark - Removing

Parse/Parse/Internal/Object/PFObjectPrivate.h

@@ -85,7 +85,7 @@
  @return Current object state.
  */
 @property (nonatomic, copy) PFObjectState *_state;
-@property (nonatomic, copy) NSMutableSet *_availableKeys;
+@property (nonatomic, retain) NSMutableSet *_availableKeys;
 
 - (instancetype)initWithObjectState:(PFObjectState *)state;
 + (instancetype)objectWithClassName:(NSString *)className

Parse/Parse/Internal/Object/State/PFObjectState.m

@@ -7,6 +7,7 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  */
 
+#import "PFAssert.h"
 #import "PFObjectState.h"
 #import "PFObjectState_Private.h"
 
@@ -129,7 +130,7 @@ - (NSDictionary *)dictionaryRepresentationWithObjectEncoder:(PFEncoder *)objectE
         result[key] = encoded;
     }];
     if (failed && encodingError) {
-        *error = encodingError;
+        PFSetError(error, encodingError);
         return nil;
     }
     return [result copy];

Parse/Parse/Internal/Object/Utilities/PFObjectUtilities.h

@@ -20,9 +20,9 @@ NS_ASSUME_NONNULL_BEGIN
 #pragma mark - Operations
 ///--------------------------------------
 
-+ (id)newValueByApplyingFieldOperation:(PFFieldOperation *)operation
-                          toDictionary:(NSMutableDictionary *)dictionary
-                                forKey:(NSString *)key;
++ (nullable id)newValueByApplyingFieldOperation:(PFFieldOperation *)operation
+                                   toDictionary:(NSMutableDictionary *)dictionary
+                                         forKey:(NSString *)key;
 + (void)applyOperationSet:(PFOperationSet *)operationSet toDictionary:(NSMutableDictionary *)dictionary;
 
 ///--------------------------------------

Parse/Parse/Internal/PFAssert.h

@@ -81,6 +81,11 @@ if (!(condition) && error && *error == nil) { \
     return rval;\
 }
 
+#define PFSetError(errorPointer, error) \
+if (errorPointer) {\
+*errorPointer = error;\
+}
+
 /*
  Returns the passed value if the condition isn't met and the *error is set
  */

Parse/Parse/Internal/Query/Controller/PFQueryController.h

@@ -78,7 +78,7 @@ NS_ASSUME_NONNULL_BEGIN
 #pragma mark - Caching
 ///--------------------------------------
 
-- (NSString *)cacheKeyForQueryState:(PFQueryState *)queryState sessionToken:(nullable NSString *)sessionToken;
+- (nullable NSString *)cacheKeyForQueryState:(PFQueryState *)queryState sessionToken:(nullable NSString *)sessionToken;
 - (BOOL)hasCachedResultForQueryState:(PFQueryState *)queryState sessionToken:(nullable NSString *)sessionToken;
 
 - (void)clearCachedResultForQueryState:(PFQueryState *)queryState sessionToken:(nullable NSString *)sessionToken;

Parse/Parse/PFEncoder.m

@@ -107,7 +107,7 @@ - (id)encodeObject:(id)object error:(NSError * __autoreleasing *) error {
             }
         }];
         if (encodingFailed) {
-            *error = encodingError;
+            PFSetError(error, encodingError);
             return nil;
         }
         return dict;

Parse/Parse/PFObject.m

@@ -245,7 +245,7 @@ + (BOOL)collectDirtyChildren:(id)node
             }
         }];
         if (wasStopped) {
-            *error = localError;
+            PFSetError(error, localError);
             return NO;
         }
     } else if ([node isKindOfClass:[PFACL class]]) {