Added attachment upload filename param

Author: Joan

src/Redmine/Api/Attachment.php

@@ -41,13 +41,15 @@ public function download($id)
      * Upload a file to redmine.
      *
      * @see http://www.redmine.org/projects/redmine/wiki/Rest_api#Attaching-files
-     *
+     * available $params :
+	 * filename: filename of the attachment
+	 * 
      * @param string $attachment the attachment content
-     *
+     * @param array $params optional parameters to be passed to the api 
      * @return array information about the attachment
      */
-    public function upload($attachment)
+    public function upload($attachment, $params = [])
     {
-        return $this->post('/uploads.json', $attachment);
+        return $this->post('/uploads.json?'.http_build_query($params), $attachment);
     }
 }

src/Redmine/Client.php

@@ -600,7 +600,7 @@ public function prepareRequest($path, $method = 'GET', $data = '')
     private function isUploadCall($path, $data)
     {
         return
-            ('/uploads.json' === $path || '/uploads.xml' === $path) &&
+            (preg_match('/\/uploads.(json|xml)/i', $path)) &&
             isset($data) &&
             is_file($data)
         ;
@@ -626,7 +626,7 @@ private function setHttpHeader($path)
 
         // Content type headers
         $tmp = parse_url($this->url.$path);
-        if ('/uploads.json' === $path || '/uploads.xml' === $path) {
+        if (preg_match('/\/uploads.(json|xml)/i', $path)) {
             $httpHeader[] = 'Content-Type: application/octet-stream';
         } elseif ('json' === substr($tmp['path'], -4)) {
             $httpHeader[] = 'Content-Type: application/json';