Corrected error in prefixBinarySearch

TwoStone · TwoStone · commit 812399e1db41 · 2013-06-16T01:46:59.000+02:00
There were an obvious mistake in the calculation of the middle for the binary search. (stopIndex + stopIndex) / 2 will evualuate  to stopIndex and not to the arithmetic middle as intended.
diff --git a/plugins-client/ext.codecomplete/complete_util.js b/plugins-client/ext.codecomplete/complete_util.js
@@ -38,7 +38,7 @@ function prefixBinarySearch(items, prefix) {
         else if (prefix > items[middle]) {
             startIndex = middle + 1;
         }
-        middle = Math.floor((stopIndex + stopIndex) / 2);
+        middle = Math.floor((stopIndex + startIndex) / 2);
     }
     
     // Look back to make sure we haven't skipped any

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ function prefixBinarySearch(items, prefix) {`
`38`	`38`	`else if (prefix > items[middle]) {`
`39`	`39`	`startIndex = middle + 1;`
`40`	`40`	`}`
`41`		`- middle = Math.floor((stopIndex + stopIndex) / 2);`
	`41`	`+ middle = Math.floor((stopIndex + startIndex) / 2);`
`42`	`42`	`}`
`43`	`43`
`44`	`44`	`// Look back to make sure we haven't skipped any`