🐛 settings.json config update error handling (#1024) #1028
+39
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, config file updates fail silently if there is a syntax error in workspace settings.json. This PR adds error handling for the config file update command and surfaces the error via a notification when thrown. After: https://github.com/user-attachments/assets/2e9bda4a-9842-4026-b092-40e3793fa3f1 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Improved error handling for configuration updates with clearer error messages. When configuration fails, users now receive helpful guidance and can directly open settings to resolve syntax or formatting issues. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Ian Bolton <[email protected]> Signed-off-by: Cherry Picker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, config file updates fail silently if there is a syntax error
in workspace settings.json. This PR adds error handling for the config
file update command and surfaces the error via a notification when
thrown.
After:
Screen.Recording.2025-11-17.at.12.55.56.PM.mov
Summary by CodeRabbit
messages. When configuration fails, users now receive helpful guidance
and can directly open settings to resolve syntax or formatting issues.
Signed-off-by: Ian Bolton [email protected]
Signed-off-by: Cherry Picker [email protected]