-
Notifications
You must be signed in to change notification settings - Fork 24
👻 Add script for building downstream vsix #1046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
⛔ Snyk checks have failed. 1 issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
WalkthroughThis PR adds tooling to support downstream builds for the release-0.8 branch. It introduces a new npm script Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
package.json(1 hunks)scripts/build-downstream.sh(1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: djzager
Repo: konveyor/editor-extensions PR: 885
File: vscode/src/commands.ts:18-18
Timestamp: 2025-09-30T18:00:23.969Z
Learning: In the konveyor/editor-extensions repository, the commands konveyor.configureLabelSelector and konveyor.configureSourcesTargets were previously removed along with their handlers. Any PR that removes their definitions from vscode/package.json is cleanup work, not adding new functionality.
📚 Learning: 2025-09-15T18:33:26.909Z
Learnt from: djzager
Repo: konveyor/editor-extensions PR: 736
File: .github/workflows/ci-repo.yml:170-175
Timestamp: 2025-09-15T18:33:26.909Z
Learning: In the konveyor/editor-extensions repository, the team prefers manually bumping asset versions in collect-assets.js rather than dynamically collecting assets based on git refs, as external dependencies don't stay in sync with their main branch and manual control provides better stability.
Applied to files:
package.jsonscripts/build-downstream.sh
📚 Learning: 2025-09-30T18:00:23.969Z
Learnt from: djzager
Repo: konveyor/editor-extensions PR: 885
File: vscode/src/commands.ts:18-18
Timestamp: 2025-09-30T18:00:23.969Z
Learning: In the konveyor/editor-extensions repository, the commands konveyor.configureLabelSelector and konveyor.configureSourcesTargets were previously removed along with their handlers. Any PR that removes their definitions from vscode/package.json is cleanup work, not adding new functionality.
Applied to files:
scripts/build-downstream.sh
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Build (windows)
- GitHub Check: Build (linux)
- GitHub Check: Build (macos)
🔇 Additional comments (2)
scripts/build-downstream.sh (1)
1-27: Build script structure and error handling look solid.The pipeline flow (clean → install → collect-assets:downstream → build → dist → package) is logical and complete. Proper use of
set -efor strict error handling, clear emoji-prefixed progress messages, and final VSIX file listing. All referenced npm scripts are defined in package.json.package.json (1)
63-63: New downstream asset collection script is properly aligned.The
collect-assets:downstreamscript correctly mirrors the existingcollect-assets:devpattern while targeting therelease-0.8branch for downstream builds. GITHUB_TOKEN handling and script invocation are consistent with the dev variant.
| echo "📦 Collecting assets for development..." | ||
| npm run collect-assets:downstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix inconsistent echo message.
Line 14 says "Collecting assets for development..." but this script is for downstream builds targeting release-0.8, not development. The message should reflect the actual purpose.
-echo "📦 Collecting assets for development..."
+echo "📦 Collecting assets for downstream..."📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| echo "📦 Collecting assets for development..." | |
| npm run collect-assets:downstream | |
| echo "📦 Collecting assets for downstream..." | |
| npm run collect-assets:downstream |
🤖 Prompt for AI Agents
In scripts/build-downstream.sh around lines 14 to 15, the echo message
incorrectly says "Collecting assets for development..." even though this script
builds downstream for release-0.8; update the echo to reflect the downstream
release target (for example: "📦 Collecting assets for downstream
release-0.8...") so the log accurately describes the script's purpose.
djzager
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason this script can't exist solely in the migtools repo?
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.