Skip to content

Conversation

@ibolton336
Copy link
Member

@ibolton336 ibolton336 commented Nov 24, 2025

Summary by CodeRabbit

  • Chores
    • Added infrastructure for downstream release builds, including new build scripts and asset collection workflows to support organized release management processes.

✏️ Tip: You can customize this high-level summary in your review settings.

@ibolton336 ibolton336 requested a review from a team as a code owner November 24, 2025 19:44
@ibolton336 ibolton336 added the cherry-pick/release-0.2 For PRs that should be cherry-picked for v0.2 of the editor extension. label Nov 24, 2025
@snyk-io
Copy link

snyk-io bot commented Nov 24, 2025

Snyk checks have failed. 1 issues have been found so far.

Status Scanner Critical High Medium Low Total (1)
Open Source Security 0 0 1 0 1 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@coderabbitai
Copy link

coderabbitai bot commented Nov 24, 2025

Walkthrough

This PR adds tooling to support downstream builds for the release-0.8 branch. It introduces a new npm script collect-assets:downstream in package.json that collects assets from workflow artifacts for the downstream branch, and adds a new bash build script (scripts/build-downstream.sh) that orchestrates a complete downstream build pipeline including dependency installation, asset collection, building, distribution packaging, and artifact listing.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify the collect-assets:downstream script references the correct downstream branch (release-0.8)
  • Ensure build-downstream.sh has correct file permissions and is executable
  • Confirm all relative script paths in build-downstream.sh are accurate from its location

Possibly related PRs

Suggested reviewers

  • djzager
  • pranavgaikwad

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, but the description template indicates this is optional guidance rather than a required section. Consider adding a brief description explaining the purpose of these downstream build scripts and how they differ from the existing build process.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title uses the 👻 prefix to indicate no release note and clearly describes the main change: adding a script for building downstream VSIX files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5ac051b and 65959ae.

📒 Files selected for processing (2)
  • package.json (1 hunks)
  • scripts/build-downstream.sh (1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: djzager
Repo: konveyor/editor-extensions PR: 885
File: vscode/src/commands.ts:18-18
Timestamp: 2025-09-30T18:00:23.969Z
Learning: In the konveyor/editor-extensions repository, the commands konveyor.configureLabelSelector and konveyor.configureSourcesTargets were previously removed along with their handlers. Any PR that removes their definitions from vscode/package.json is cleanup work, not adding new functionality.
📚 Learning: 2025-09-15T18:33:26.909Z
Learnt from: djzager
Repo: konveyor/editor-extensions PR: 736
File: .github/workflows/ci-repo.yml:170-175
Timestamp: 2025-09-15T18:33:26.909Z
Learning: In the konveyor/editor-extensions repository, the team prefers manually bumping asset versions in collect-assets.js rather than dynamically collecting assets based on git refs, as external dependencies don't stay in sync with their main branch and manual control provides better stability.

Applied to files:

  • package.json
  • scripts/build-downstream.sh
📚 Learning: 2025-09-30T18:00:23.969Z
Learnt from: djzager
Repo: konveyor/editor-extensions PR: 885
File: vscode/src/commands.ts:18-18
Timestamp: 2025-09-30T18:00:23.969Z
Learning: In the konveyor/editor-extensions repository, the commands konveyor.configureLabelSelector and konveyor.configureSourcesTargets were previously removed along with their handlers. Any PR that removes their definitions from vscode/package.json is cleanup work, not adding new functionality.

Applied to files:

  • scripts/build-downstream.sh
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Build (windows)
  • GitHub Check: Build (linux)
  • GitHub Check: Build (macos)
🔇 Additional comments (2)
scripts/build-downstream.sh (1)

1-27: Build script structure and error handling look solid.

The pipeline flow (clean → install → collect-assets:downstream → build → dist → package) is logical and complete. Proper use of set -e for strict error handling, clear emoji-prefixed progress messages, and final VSIX file listing. All referenced npm scripts are defined in package.json.

package.json (1)

63-63: New downstream asset collection script is properly aligned.

The collect-assets:downstream script correctly mirrors the existing collect-assets:dev pattern while targeting the release-0.8 branch for downstream builds. GITHUB_TOKEN handling and script invocation are consistent with the dev variant.

Comment on lines +14 to +15
echo "📦 Collecting assets for development..."
npm run collect-assets:downstream
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix inconsistent echo message.

Line 14 says "Collecting assets for development..." but this script is for downstream builds targeting release-0.8, not development. The message should reflect the actual purpose.

-echo "📦 Collecting assets for development..."
+echo "📦 Collecting assets for downstream..."
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
echo "📦 Collecting assets for development..."
npm run collect-assets:downstream
echo "📦 Collecting assets for downstream..."
npm run collect-assets:downstream
🤖 Prompt for AI Agents
In scripts/build-downstream.sh around lines 14 to 15, the echo message
incorrectly says "Collecting assets for development..." even though this script
builds downstream for release-0.8; update the echo to reflect the downstream
release target (for example: "📦 Collecting assets for downstream
release-0.8...") so the log accurately describes the script's purpose.

Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason this script can't exist solely in the migtools repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick/release-0.2 For PRs that should be cherry-picked for v0.2 of the editor extension.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants