Skip to content

👻 Add script for building downstream vsix #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

👻 Add script for building downstream vsix #1046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@
"postbuild": "[ -f scripts/postbuild.js ] && node scripts/postbuild.js || echo 'No postbuild script found'",
"collect-assets": "rimraf ./downloaded_assets && node ./scripts/collect-assets.js",
"collect-assets:dev": "GITHUB_TOKEN=$(gh auth token 2>/dev/null || echo '') node ./scripts/collect-assets.js --use-workflow-artifacts --branch=main",
"collect-assets:downstream": "GITHUB_TOKEN=$(gh auth token 2>/dev/null || echo '') node ./scripts/collect-assets.js --use-workflow-artifacts --branch=release-0.8",
"dist": "rimraf ./dist && node ./scripts/copy-dist.js",
"package": "node ./scripts/package-extensions.js",
"package-core": "node ./scripts/package-extensions.js core",
Expand Down
27 changes: 27 additions & 0 deletions scripts/build-downstream.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
#!/bin/bash

# Build script for Konveyor extension
# Runs full build pipeline: clean -> collect assets -> build -> dist -> package

set -e # Exit on any error

echo "🧹 Cleaning..."
npm run clean

echo "📦 Installing dependencies..."
npm i

echo "📦 Collecting assets for development..."
npm run collect-assets:downstream
Comment on lines +14 to +15
Copy link

@coderabbitai coderabbitai bot Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix inconsistent echo message.

Line 14 says "Collecting assets for development..." but this script is for downstream builds targeting release-0.8, not development. The message should reflect the actual purpose.

-echo "📦 Collecting assets for development..."
+echo "📦 Collecting assets for downstream..."
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
echo "📦 Collecting assets for development..."
npm run collect-assets:downstream
echo "📦 Collecting assets for downstream..."
npm run collect-assets:downstream
🤖 Prompt for AI Agents 
In scripts/build-downstream.sh around lines 14 to 15, the echo message
incorrectly says "Collecting assets for development..." even though this script
builds downstream for release-0.8; update the echo to reflect the downstream
release target (for example: "📦 Collecting assets for downstream
release-0.8...") so the log accurately describes the script's purpose.


echo "🔨 Building..."
npm run build

echo "📦 Creating distribution..."
npm run dist

echo "📦 Packaging VSIX..."
npm run package

echo "✅ Build complete! VSIX file:"
ls -la dist/*.vsix
Loading