Skip to content

Conversation

@mguetta1
Copy link
Contributor

@mguetta1 mguetta1 commented Nov 11, 2025

Cherry-pick #1736, #1749

Summary by CodeRabbit

  • Tests
    • Simplified role-assignment flow by removing an intermediate dropdown and streamlining selection.
    • Improved password and text input handling in tests with a new optional faster input mode.
    • Updated test titles and element selectors to match the current UI, improving reliability and maintenance.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Nov 11, 2025

Walkthrough

This PR updates Cypress end-to-end tests and utilities: it simplifies role assignment in the Keycloak user model by selecting realm roles via text instead of a filter dropdown and adjusts the role button selector; it changes password input calls to pass two boolean flags; it adds an optional useInvoke boolean to inputText in cypress/utils/utils.ts to allow setting field values via .invoke("val", ...); and it removes a bug marker from a test title string.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Verify role selection changes in cypress/e2e/models/keycloak/users/user.ts correctly target the UI and that the two boolean flags passed to password inputs have the intended effect.
  • Confirm selector update in cypress/e2e/views/rbac.view.ts (button[data-testid="add-role-mapping-button"]) matches the application DOM.
  • Review cypress/utils/utils.ts for correct behavior of the new useInvoke branch (event triggering, clearing behavior) and ensure backward compatibility of the inputText signature.

Possibly related PRs

Suggested reviewers

  • abrugaro
  • nachandr
  • sshveta

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete and does not follow the repository template, which requires reviewers to be requested and specifies optional RFR/WIP tags. The current description lacks structured sections and detailed information. Expand the description to include detailed context about the cherry-picked changes, specify which files/components were updated, and request reviews from the specified reviewers (sshveta, nachandr, igor) as outlined in the template.
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main objective: adapting changes from RHBK 26.4.2, which aligns with the changeset that modifies Cypress test files to support the new version's UI updates.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a0b2400 and 9786d41.

📒 Files selected for processing (4)
  • cypress/e2e/models/keycloak/users/user.ts (2 hunks)
  • cypress/e2e/tests/rbac/migrator.test.ts (1 hunks)
  • cypress/e2e/views/rbac.view.ts (1 hunks)
  • cypress/utils/utils.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (4)
  • cypress/e2e/tests/rbac/migrator.test.ts
  • cypress/utils/utils.ts
  • cypress/e2e/views/rbac.view.ts
  • cypress/e2e/models/keycloak/users/user.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: e2e-main / e2e-ui-integration-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mguetta1 mguetta1 marked this pull request as draft November 11, 2025 20:50
@mguetta1 mguetta1 changed the title [RFR] Adapt changes introduced in RHBK 26.4.2 (#1736) Adapt changes introduced in RHBK 26.4.2 (#1736) Nov 11, 2025
mguetta1 and others added 2 commits November 26, 2025 14:07
* Adapt changes introduced in RHBK 26.4.2

Signed-off-by: Maayan Hadasi <[email protected]>

* Adding explicit waits between clicks

Signed-off-by: Maayan Hadasi <[email protected]>

---------

Signed-off-by: Maayan Hadasi <[email protected]>
@mguetta1 mguetta1 marked this pull request as ready for review November 26, 2025 13:03
@mguetta1 mguetta1 changed the title Adapt changes introduced in RHBK 26.4.2 (#1736) [RFR] Adapt changes introduced in RHBK 26.4.2 (#1736) Nov 26, 2025
Copy link
Collaborator

@abrugaro abrugaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code lgtm, can we please check why the ci fails if the tests are not marked with bug numbers anymore? thanks!

Copy link
Collaborator

@abrugaro abrugaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw it working on Jenkins, lgtm.

It would be good if we could invest some time in checking why it fails here so we avoid merging things in red

@mguetta1
Copy link
Contributor Author

Saw it working on Jenkins, lgtm.

It would be good if we could invest some time in checking why it fails here so we avoid merging things in red

Looks like Keycloak is not enabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants