-
Notifications
You must be signed in to change notification settings - Fork 42
[RFR] Adapt changes introduced in RHBK 26.4.2 (#1736) #1738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThis PR updates Cypress end-to-end tests and utilities: it simplifies role assignment in the Keycloak user model by selecting realm roles via text instead of a filter dropdown and adjusts the role button selector; it changes password input calls to pass two boolean flags; it adds an optional Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (4)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
* Adapt changes introduced in RHBK 26.4.2 Signed-off-by: Maayan Hadasi <[email protected]> * Adding explicit waits between clicks Signed-off-by: Maayan Hadasi <[email protected]> --------- Signed-off-by: Maayan Hadasi <[email protected]>
Signed-off-by: Maayan Hadasi <[email protected]>
abrugaro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code lgtm, can we please check why the ci fails if the tests are not marked with bug numbers anymore? thanks!
abrugaro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saw it working on Jenkins, lgtm.
It would be good if we could invest some time in checking why it fails here so we avoid merging things in red
Looks like Keycloak is not enabled |
Cherry-pick #1736, #1749
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.