Skip to content

Commit 3840a24

Browse files
committed
Merge branch 'hotfix/cs-and-packages'
Fix CS issues and update composer definition
2 parents 50fed77 + f763661 commit 3840a24

File tree

7 files changed

+30
-34
lines changed

7 files changed

+30
-34
lines changed

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
composer.lock
2+
vendor/

Module.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public function getConfig()
4141

4242
/**
4343
* Provide console usage messages for console endpoints
44-
*
44+
*
4545
* @return array
4646
*/
4747
public function getConsoleUsage()
@@ -56,9 +56,9 @@ public function getConsoleUsage()
5656
/**
5757
* Listen to the application bootstrap event
5858
*
59-
* Registers a post-routing event. Additionally, if the
59+
* Registers a post-routing event. Additionally, if the
6060
* "PhlySimplePage\PageCache" service is registered, it will pull the
61-
* "PhlySimplePage\PageCacheListener" service and attach it to the
61+
* "PhlySimplePage\PageCacheListener" service and attach it to the
6262
* event manager.
6363
*
6464
* @param \Zend\Mvc\MvcEvent $e
@@ -137,8 +137,8 @@ public function onDispatchPost($e)
137137

138138
/**
139139
* Normalize a cache key
140-
*
141-
* @param string $key
140+
*
141+
* @param string $key
142142
* @return string
143143
*/
144144
public static function normalizeCacheKey($key)

composer.json

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,6 @@
88
"module"
99
],
1010
"homepage": "https://github.com/weierophinney/PhlySimplePage",
11-
"repositories": [
12-
{
13-
"type": "composer",
14-
"url": "https://packages.zendframework.com/"
15-
}
16-
],
1711
"authors": [
1812
{
1913
"name": "Matthew Weier O'Phinney",

src/PhlySimplePage/CacheControllerService.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ class CacheControllerService implements FactoryInterface
1818
{
1919
/**
2020
* Create and return CacheController
21-
*
21+
*
2222
* @param ServiceLocatorInterface $controllers
2323
* @return CacheController
2424
* @throws Exception\ServiceNotCreatedException

src/PhlySimplePage/PageCacheListener.php

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
use Zend\EventManager\ListenerAggregateInterface;
1313

1414
/**
15-
* Event listener implementing page level caching for pages provided by the
15+
* Event listener implementing page level caching for pages provided by the
1616
* PageController.
1717
*/
1818
class PageCacheListener implements ListenerAggregateInterface
@@ -29,22 +29,22 @@ class PageCacheListener implements ListenerAggregateInterface
2929

3030
/**
3131
* Whether or not to cache this request
32-
*
32+
*
3333
* @var bool
3434
*/
3535
protected $cacheThisRequest = false;
3636

3737
/**
3838
* Key to use when caching
39-
*
39+
*
4040
* @var string
4141
*/
4242
protected $cacheKey;
4343

4444
/**
4545
* Constructor
46-
*
47-
* @param AbstractAdapter $cache
46+
*
47+
* @param AbstractAdapter $cache
4848
*/
4949
public function __construct(AbstractAdapter $cache)
5050
{
@@ -56,10 +56,10 @@ public function __construct(AbstractAdapter $cache)
5656
*
5757
* Registers two event listeners:
5858
*
59-
* - route, at priority -99,
60-
* - finish, at priority -10001,
61-
*
62-
* @param EventManagerInterface $events
59+
* - route, at priority -99,
60+
* - finish, at priority -10001,
61+
*
62+
* @param EventManagerInterface $events
6363
*/
6464
public function attach(EventManagerInterface $events)
6565
{
@@ -69,8 +69,8 @@ public function attach(EventManagerInterface $events)
6969

7070
/**
7171
* Detach any registered listeners from the given event manager instance.
72-
*
73-
* @param EventManagerInterface $events
72+
*
73+
* @param EventManagerInterface $events
7474
*/
7575
public function detach(EventManagerInterface $events)
7676
{
@@ -85,12 +85,12 @@ public function detach(EventManagerInterface $events)
8585
* "route" event listener
8686
*
8787
* Checks to see if (a) we have a controller we're interested in, (b) if
88-
* a "template" was provided in the route matches, and (c) if we have a
89-
* cache hit for that template name. If we do, we return a populated
88+
* a "template" was provided in the route matches, and (c) if we have a
89+
* cache hit for that template name. If we do, we return a populated
9090
* response; if not, we continue, but indicate that we should cache the
9191
* response on completion.
92-
*
93-
* @param \Zend\Mvc\MvcEvent $e
92+
*
93+
* @param \Zend\Mvc\MvcEvent $e
9494
* @return null|\Zend\Stdlib\ResponseInterface
9595
*/
9696
public function onRoutePost($e)
@@ -117,7 +117,7 @@ public function onRoutePost($e)
117117
}
118118

119119
$cacheKey = Module::normalizeCacheKey($template);
120-
120+
121121
$result = $this->cache->getItem($cacheKey, $success);
122122
if (!$success) {
123123
// Not a cache hit; keep working, but indicate we should cache this
@@ -136,8 +136,8 @@ public function onRoutePost($e)
136136
* "finish" event listener
137137
*
138138
* Checks to see if we should cache the current request; if so, it does.
139-
*
140-
* @param \Zend\Mvc\MvcEvent $e
139+
*
140+
* @param \Zend\Mvc\MvcEvent $e
141141
*/
142142
public function onFinishPost($e)
143143
{

src/PhlySimplePage/PageCacheListenerService.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ class PageCacheListenerService implements FactoryInterface
1717
{
1818
/**
1919
* Create and return page cache listener
20-
*
21-
* @param ServiceLocatorInterface $services
20+
*
21+
* @param ServiceLocatorInterface $services
2222
* @return PageCacheListener
2323
* @throws Exception\ServiceNotCreatedException
2424
*/

src/PhlySimplePage/PageCacheService.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ class PageCacheService implements FactoryInterface
1919
{
2020
/**
2121
* Create and return cache storage adapter
22-
*
23-
* @param ServiceLocatorInterface $services
22+
*
23+
* @param ServiceLocatorInterface $services
2424
* @return \Zend\Cache\Storage\Adapter\AbstractAdapter
2525
* @throws Exception\ServiceNotCreatedException
2626
*/

0 commit comments

Comments
 (0)