Skip to content

Commit 1c68e5c

Browse files
committed
refactor default bypass predicate object
1 parent 8dac7db commit 1c68e5c

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

concurrency-limits-core/src/main/java/com/netflix/concurrency/limits/limiter/AbstractLimiter.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@ public abstract class AbstractLimiter<ContextT> implements Limiter<ContextT> {
3939
*/
4040
public abstract static class BypassLimiterBuilder<BuilderT extends BypassLimiterBuilder<BuilderT, ContextT>, ContextT> extends Builder<BuilderT> {
4141

42-
private Predicate<ContextT> bypassResolver = (context) -> false;
42+
private final Predicate<ContextT> ALWAYS_FALSE = (context) -> false;
43+
private Predicate<ContextT> bypassResolver = ALWAYS_FALSE;
4344

4445
/**
4546
* Add a chainable bypass resolver predicate from context. Multiple resolvers may be added and if any of the
@@ -49,7 +50,11 @@ public abstract static class BypassLimiterBuilder<BuilderT extends BypassLimiter
4950
* @return Chainable builder
5051
*/
5152
public BuilderT bypassLimitResolver(Predicate<ContextT> shouldBypass) {
52-
this.bypassResolver = bypassResolver.or(shouldBypass);
53+
if (this.bypassResolver == ALWAYS_FALSE) {
54+
this.bypassResolver = shouldBypass;
55+
} else {
56+
this.bypassResolver = bypassResolver.or(shouldBypass);
57+
}
5358
return self();
5459
}
5560
}

0 commit comments

Comments
 (0)