Added Magento Exception logging

Author: LeonB

README.md

@@ -25,6 +25,31 @@ modman init modman clone
 [email protected]:wearefarm/magento-sentry-extension.git
 ```
 
+## Installation: enabling Magento Exception handling
+
+Because Magento catches all exceptions via a global try/catch construct
+`set_exception_handler` doesn't work (the exception handler is never reached).
+With a small addition to `app/Mage.php` this can be fixed:
+
+``` php
+  public static function run($code = '', $type = 'store', $options = array())
+  {
+    ......
+    } catch (Exception $e) {
+    if (self::isInstalled() || self::$_isDownloader) {
+    //add this line
+    self::dispatchEvent('mage_run_exception',array('exception' => $e));
+    //-----------------------------------------------------------------
+    self::printException($e);
+    exit();
+    }
+  }
+```
+
+I hope Magento will include this patch in Magento. Another solution could be
+[PHP's runkit](http://www.php.net/manual/en/book.runkit.php) or editing
+`errors/report.php`.
+
 ## Configuration
 
 In your Magento back-office, go to System → Configuration → Advanced → Developer

src/app/code/community/AMG/Sentry/Model/Observer.php

@@ -2,14 +2,23 @@
 
 class AMG_Sentry_Model_Observer {
 
-    public function initSentryLogger($observer){
+    public $error_handler;
+
+    public function __construct()
+    {
         if (Mage::getStoreConfigFlag('dev/amg-sentry/active')) {
             // Instantiate a new client
             $client = Mage::getSingleton('amg-sentry/client');
 
             // Install error handlers and shutdown function to catch fatal errors
-            $error_handler = new Raven_ErrorHandler($client);
+            $this->error_handler = new Raven_ErrorHandler($client);
+        }
+
+        return $this;
+    }
 
+    public function initSentryLogger($observer){
+        if ($error_handler = $this->error_handler) {
             // Check if we should log errors, warnings etc.
             if (Mage::getStoreConfigFlag('dev/amg-sentry/php-errors')) {
                 $error_handler->registerErrorHandler();
@@ -25,5 +34,14 @@ public function initSentryLogger($observer){
                 $error_handler->registerShutdownFunction();
             }
         }
+
+        return $this;
+    }
+
+    public function mageRunException($observer)
+    {
+        $exception = $observer->getException();
+        $this->error_handler->handleException($exception);
+        return $this;
     }
 }

src/app/code/community/AMG/Sentry/etc/config.xml

@@ -10,25 +10,25 @@
  It is also available through the world-wide-web at this URL:
  http://opensource.org/licenses/osl-3.0.php
 
- @category		AMG
- @package		AMG_Sentry
- @copyright		Copyright © 2012 Jean Roussel <[email protected]>
- @license		http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+ @category      AMG
+ @package       AMG_Sentry
+ @copyright     Copyright © 2012 Jean Roussel <[email protected]>
+ @license       http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
  
 -->
 <config>
-	<modules>
-		<AMG_Sentry>
-			<version>1.0.0</version>
-		</AMG_Sentry>
-	</modules>
-	<global>
+    <modules>
+        <AMG_Sentry>
+            <version>1.0.0</version>
+        </AMG_Sentry>
+    </modules>
+    <global>
         <models>
             <amg-sentry>
                 <class>AMG_Sentry_Model</class>
             </amg-sentry>
         </models>
-        <events>	
+        <events>
             <controller_action_predispatch>
                 <observers>
                     <amg-sentry_controller_action_predispatch>
@@ -37,19 +37,28 @@
                         <method>initSentryLogger</method>
                     </amg-sentry_controller_action_predispatch>
                 </observers>
-            </controller_action_predispatch>      
+            </controller_action_predispatch>
+            <mage_run_exception>
+                <observers>
+                    <amg-sentry_mage_run_exceptioin>
+                        <type>singleton</type>
+                        <class>amg-sentry/observer</class>
+                        <method>mageRunException</method>
+                    </amg-sentry_mage_run_exceptioin>
+                </observers>
+            </mage_run_exception>
         </events>
-	</global>
-	<default>
-		<dev>
-			<amg-sentry>
-				<active>false</active>
-				<dsn>http://public:[email protected]:9000/[PROJECT_ID]</dsn>
-				<logger>magento</logger>
+    </global>
+    <default>
+        <dev>
+            <amg-sentry>
+                <active>false</active>
+                <dsn>http://public:[email protected]:9000/[PROJECT_ID]</dsn>
+                <logger>magento</logger>
                 <php-errors>false</php-errors>
                 <php-exceptions>false</php-exceptions>
                 <php-fatal-errors>false</php-fatal-errors>
-			</amg-sentry>
-		</dev>
-	</default>
+            </amg-sentry>
+        </dev>
+    </default>
 </config>