Skip to content

Commit ee832e4

Browse files
committed
IGNITE-4472 Fixed became this user.
1 parent e8f8e0a commit ee832e4

File tree

4 files changed

+7
-14
lines changed

4 files changed

+7
-14
lines changed

modules/web-console/backend/routes/profile.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ module.exports.factory = function(_, express, mongo, usersService) {
5050
if (becomeUsed) {
5151
req.session.viewedUser = user;
5252

53-
return user;
53+
return req.user;
5454
}
5555

5656
return new Promise((resolve, reject) => {
@@ -64,7 +64,7 @@ module.exports.factory = function(_, express, mongo, usersService) {
6464
});
6565
});
6666
})
67-
.then(() => usersService.get(req.user, req.session.viewedUser))
67+
.then((user) => usersService.get(user, req.session.viewedUser))
6868
.then(res.api.ok)
6969
.catch(res.api.error);
7070
});

modules/web-console/backend/services/sessions.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,7 @@ module.exports.factory = (_, mongo, errors) => {
4242
return Promise.reject(new errors.IllegalAccessError('Became this user is not permitted. Only administrators can perform this actions.'));
4343

4444
return mongo.Account.findById(viewedUserId).lean().exec()
45-
.then((viewedUser) => {
46-
viewedUser.token = session.req.user.token;
47-
48-
session.viewedUser = viewedUser;
49-
});
45+
.then((viewedUser) => session.viewedUser = viewedUser);
5046
}
5147

5248
/**

modules/web-console/backend/services/users.js

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -212,11 +212,8 @@ module.exports.factory = (_, mongo, settings, spacesService, mailsService, activ
212212

213213
const becomeUsed = viewedUser && user.admin;
214214

215-
if (becomeUsed) {
216-
user = viewedUser;
217-
218-
user.becomeUsed = true;
219-
}
215+
if (becomeUsed)
216+
user = _.extend({}, viewedUser, {becomeUsed: true, becameToken: user.token});
220217
else
221218
user = user.toJSON();
222219

modules/web-console/frontend/views/templates/agent-download.jade

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@
3434
i.fa.fa-chevron-circle-right(ng-show='!agentLoad.showToken' ng-click='agentLoad.showToken = ! agentLoad.showToken')
3535
a(ng-click='agentLoad.showToken = ! agentLoad.showToken') {{agentLoad.showToken ? 'Hide security token...' : 'Show security token...'}}
3636
.details-row(ng-show='agentLoad.showToken')
37-
label.labelField Security token: {{user.token}}
38-
i.tipLabel.fa.fa-clipboard(ignite-copy-to-clipboard='{{user.token}}' bs-tooltip='' data-title='Copy security token to clipboard')
37+
label.labelField Security token: {{user.becameToken || user.token}}
38+
i.tipLabel.fa.fa-clipboard(ignite-copy-to-clipboard='{{user.becameToken || user.token}}' bs-tooltip='' data-title='Copy security token to clipboard')
3939
i.tipLabel.icon-help(ng-if=lines bs-tooltip='' data-title='The security token is used for authorization of web agent')
4040
.agent-download(ng-if='hasAgents')
4141
p Connection to Ignite Web Agent is established, but agent failed to connect to Ignite Node

0 commit comments

Comments
 (0)