Fix incorrect newline in loose lists

Closes #79

Author: lampsitter

CHANGELOG.md

@@ -2,6 +2,12 @@
 
 ## Unreleased
 
+
+### Fixed
+
+- Loose lists would get a newline between the bullet point and the text when it
+  is the first markdown element.
+
 ## 0.21.0 - 2025-07-10
 
 ### Changed

egui_commonmark/examples/mixing.rs

@@ -49,6 +49,11 @@ fn main() -> eframe::Result<()> {
    - baa
                         "#,
                     r#"
+1. Loose list
+
+2. aaa
+                        "#,
+                    r#"
 ```rust
 let x = 3;
 ```

egui_commonmark/src/parsers/pulldown.rs

@@ -15,6 +15,9 @@ use pulldown_cmark::{CowStr, HeadingLevel};
 /// All elements try to insert a newline before them (if they are allowed)
 /// and end their own line.
 struct Newline {
+    /// Whether a newline should not be inserted before a widget. This is only for
+    /// the first widget.
+    should_not_start_newline_forced: bool,
     /// Whether an element should insert a newline before it
     should_start_newline: bool,
     /// Whether an element should end it's own line using a newline
@@ -28,8 +31,8 @@ struct Newline {
 impl Default for Newline {
     fn default() -> Self {
         Self {
-            // Default as false as the first line should not have a newline above it
-            should_start_newline: false,
+            should_not_start_newline_forced: true,
+            should_start_newline: true,
             should_end_newline: true,
             should_end_newline_forced: true,
         }
@@ -42,11 +45,11 @@ impl Newline {
     }
 
     pub fn can_insert_start(&self) -> bool {
-        self.should_start_newline
+        self.should_start_newline && !self.should_not_start_newline_forced
     }
 
     pub fn try_insert_start(&self, ui: &mut Ui) {
-        if self.should_start_newline {
+        if self.can_insert_start() {
             newline(ui);
         }
     }
@@ -172,7 +175,7 @@ impl CommonMarkViewerInternal {
                 }
 
                 if index == 0 {
-                    self.line.should_start_newline = true;
+                    self.line.should_not_start_newline_forced = false;
                 }
             }
 
@@ -266,7 +269,7 @@ impl CommonMarkViewerInternal {
                         self.process_event(ui, &mut events, e, src_span, cache, options, max_width);
 
                         if i == 0 {
-                            self.line.should_start_newline = true;
+                            self.line.should_not_start_newline_forced = false;
                         }
                     }
                 });
@@ -410,7 +413,7 @@ impl CommonMarkViewerInternal {
             // Currently the blockquotes are made in such a way that they need a newline at the end
             // and the start so when this is the first element in the markdown the newline must be
             // manually enabled
-            self.line.should_start_newline = true;
+            self.line.should_not_start_newline_forced = false;
             if let Some(alert) = parse_alerts(&options.alerts, &mut collected_events) {
                 egui_commonmark_backend::alert_ui(alert, ui, |ui| {
                     for (event, src_span) in collected_events {

egui_commonmark_macros/src/generator.rs

@@ -10,6 +10,9 @@ use quote::quote;
 use syn::Expr;
 
 struct Newline {
+    /// Whether a newline should not be inserted before a widget. This is only for
+    /// the first widget.
+    should_not_start_newline_forced: bool,
     /// Whether an element should insert a newline before it
     should_start_newline: bool,
     /// Whether an element should end it's own line using a newline
@@ -23,8 +26,8 @@ struct Newline {
 impl Default for Newline {
     fn default() -> Self {
         Self {
-            // Default as false as the first line should not have a newline above it
-            should_start_newline: false,
+            should_not_start_newline_forced: true,
+            should_start_newline: true,
             should_end_newline: true,
             should_end_newline_forced: true,
         }
@@ -37,12 +40,12 @@ impl Newline {
     }
 
     pub fn can_insert_start(&self) -> bool {
-        self.should_start_newline
+        self.should_start_newline && !self.should_not_start_newline_forced
     }
 
     #[must_use]
     pub fn try_insert_start(&self) -> TokenStream {
-        if self.should_start_newline {
+        if self.can_insert_start() {
             quote!(egui_commonmark_backend::newline(ui);)
         } else {
             TokenStream::new()
@@ -219,7 +222,7 @@ impl CommonMarkViewerInternal {
             let e = self.process_event(&mut events, e, &cache, &options);
 
             if i == 0 {
-                self.line.should_start_newline = true;
+                self.line.should_not_start_newline_forced = false;
             }
 
             event_stream.extend(e);
@@ -376,7 +379,8 @@ impl CommonMarkViewerInternal {
             });
             stream.extend(self.line.try_insert_start());
 
-            self.line.should_start_newline = true;
+            // See non proc macro version for reaseon
+            self.line.should_not_start_newline_forced = false;
             if let Some(alert) = parse_alerts(&options.alerts, &mut collected_events) {
                 let Alert {
                     accent_color,