Skip to content

Version 4.x breaks Laravel's NotificationSent event #178

@kohenkatz

Description

@kohenkatz

One of the changes made in #168 is that FcmChannel#send now has a void return type.

This makes Laravel's built-in NotificationSent event useless, because the responses are no longer included in that event object.

As shown in the comments on #29, there can be good reasons to receive success responses, not only failure responses (as are now done with NotificationFailed events).

Please put back returning the FCM results from the send function.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions