Enhance MCP commands for WSL compatibility (#121)

* Enhance MCP commands for WSL compatibility

* Add optional parameter to `getPhpPath` for absolute path control

* feat: add tests for WSL and absolute path overrides

* refactor: simplify 'isRunningInWsl'

* refactor: reduce conditional on boost mcp install

* rector: update test return types

---------

Co-authored-by: Ashley Hindle <[email protected]>

Author: HichemTab-tech

src/Console/InstallCommand.php

@@ -487,11 +487,21 @@ private function installMcpServerConfig(): void
             $this->output->write("  {$ideDisplay}... ");
             $results = [];
 
-            $php = $mcpClient->getPhpPath();
             if ($this->shouldInstallMcp()) {
+                $inWsl = $this->isRunningInWsl();
+                $mcp = array_filter([
+                    'laravel-boost',
+                    $inWsl ? 'wsl' : false,
+                    $mcpClient->getPhpPath($inWsl),
+                    $mcpClient->getArtisanPath($inWsl),
+                    'boost:mcp',
+                ]);
                 try {
-                    $artisan = $mcpClient->getArtisanPath();
-                    $result = $mcpClient->installMcp('laravel-boost', $php, [$artisan, 'boost:mcp']);
+                    $result = $mcpClient->installMcp(
+                        array_shift($mcp),
+                        array_shift($mcp),
+                        $mcp
+                    );
 
                     if ($result) {
                         $results[] = $this->greenTick.' Boost';
@@ -507,6 +517,7 @@ private function installMcpServerConfig(): void
 
             // Install Herd MCP if enabled
             if ($this->shouldInstallHerdMcp()) {
+                $php = $mcpClient->getPhpPath();
                 try {
                     $result = $mcpClient->installMcp(
                         key: 'herd',
@@ -552,4 +563,14 @@ private function detectLocalization(): bool
         /** @phpstan-ignore-next-line  */
         return $actuallyUsing && is_dir(base_path('lang'));
     }
+
+    /**
+     * Are we running inside a Windows Subsystem for Linux (WSL) environment?
+     * This differentiates between a regular Linux installation and a WSL.
+     */
+    private function isRunningInWsl(): bool
+    {
+        // Check for WSL-specific environment variables.
+        return ! empty(getenv('WSL_DISTRO_NAME')) || ! empty(getenv('IS_WSL'));
+    }
 }

src/Contracts/McpClient.php

@@ -22,12 +22,12 @@ public function useAbsolutePathForMcp(): bool;
     /**
      * Get the PHP executable path for this MCP client.
      */
-    public function getPhpPath(): string;
+    public function getPhpPath(bool $forceAbsolutePath = false): string;
 
     /**
      * Get the artisan path for this MCP client.
      */
-    public function getArtisanPath(): string;
+    public function getArtisanPath(bool $forceAbsolutePath = false): string;
 
     /**
      * Install an MCP server configuration in this IDE.

src/Install/CodeEnvironment/CodeEnvironment.php

@@ -5,7 +5,6 @@
 namespace Laravel\Boost\Install\CodeEnvironment;
 
 use Illuminate\Contracts\Filesystem\FileNotFoundException;
-use Illuminate\Support\Facades\File;
 use Illuminate\Support\Facades\Process;
 use Laravel\Boost\Contracts\Agent;
 use Laravel\Boost\Contracts\McpClient;
@@ -39,14 +38,14 @@ public function useAbsolutePathForMcp(): bool
         return $this->useAbsolutePathForMcp;
     }
 
-    public function getPhpPath(): string
+    public function getPhpPath(bool $forceAbsolutePath = false): string
     {
-        return $this->useAbsolutePathForMcp() ? PHP_BINARY : 'php';
+        return ($this->useAbsolutePathForMcp() || $forceAbsolutePath) ? PHP_BINARY : 'php';
     }
 
-    public function getArtisanPath(): string
+    public function getArtisanPath(bool $forceAbsolutePath = false): string
     {
-        return $this->useAbsolutePathForMcp() ? base_path('artisan') : 'artisan';
+        return ($this->useAbsolutePathForMcp() || $forceAbsolutePath) ? base_path('artisan') : 'artisan';
     }
 
     /**

tests/Feature/Console/InstallCommandWslTest.php

@@ -0,0 +1,58 @@
+<?php
+
+declare(strict_types=1);
+
+use Laravel\Boost\Console\InstallCommand;
+
+test('isRunningInWsl returns true when WSL_DISTRO_NAME is set', function (): void {
+    putenv('WSL_DISTRO_NAME=Ubuntu');
+
+    $command = new InstallCommand;
+    $reflection = new ReflectionClass($command);
+    $method = $reflection->getMethod('isRunningInWsl');
+
+    expect($method->invoke($command))->toBeTrue();
+});
+
+test('isRunningInWsl returns true when IS_WSL is set', function (): void {
+    putenv('IS_WSL=1');
+
+    $command = new InstallCommand;
+    $reflection = new ReflectionClass($command);
+    $method = $reflection->getMethod('isRunningInWsl');
+
+    expect($method->invoke($command))->toBeTrue();
+});
+
+test('isRunningInWsl returns true when both WSL env vars are set', function (): void {
+    putenv('WSL_DISTRO_NAME=Ubuntu');
+    putenv('IS_WSL=true');
+
+    $command = new InstallCommand;
+    $reflection = new ReflectionClass($command);
+    $method = $reflection->getMethod('isRunningInWsl');
+
+    expect($method->invoke($command))->toBeTrue();
+});
+
+test('isRunningInWsl returns false when no WSL env vars are set', function (): void {
+    putenv('WSL_DISTRO_NAME');
+    putenv('IS_WSL');
+
+    $command = new InstallCommand;
+    $reflection = new ReflectionClass($command);
+    $method = $reflection->getMethod('isRunningInWsl');
+
+    expect($method->invoke($command))->toBeFalse();
+});
+
+test('isRunningInWsl returns false when WSL env vars are empty strings', function (): void {
+    putenv('WSL_DISTRO_NAME=');
+    putenv('IS_WSL=');
+
+    $command = new InstallCommand;
+    $reflection = new ReflectionClass($command);
+    $method = $reflection->getMethod('isRunningInWsl');
+
+    expect($method->invoke($command))->toBeFalse();
+});

tests/Feature/Install/CodeEnvironment/CodeEnvironmentPathResolutionTest.php

@@ -37,3 +37,35 @@
 
     expect($cursor->getArtisanPath())->toBe('artisan');
 });
+
+test('CodeEnvironment returns absolute paths when forceAbsolutePath is true', function (): void {
+    $strategyFactory = Mockery::mock(DetectionStrategyFactory::class);
+    $cursor = new Cursor($strategyFactory);
+
+    expect($cursor->getPhpPath(true))->toBe(PHP_BINARY);
+    expect($cursor->getArtisanPath(true))->toEndWith('artisan')
+        ->and($cursor->getArtisanPath(true))->not()->toBe('artisan');
+});
+
+test('CodeEnvironment maintains relative paths when forceAbsolutePath is false', function (): void {
+    $strategyFactory = Mockery::mock(DetectionStrategyFactory::class);
+    $cursor = new Cursor($strategyFactory);
+
+    expect($cursor->getPhpPath(false))->toBe('php');
+    expect($cursor->getArtisanPath(false))->toBe('artisan');
+});
+
+test('PhpStorm paths remain absolute regardless of forceAbsolutePath parameter', function (): void {
+    $strategyFactory = Mockery::mock(DetectionStrategyFactory::class);
+    $phpStorm = new PhpStorm($strategyFactory);
+
+    // PhpStorm always uses absolute paths, so forceAbsolutePath shouldn't change behavior
+    expect($phpStorm->getPhpPath(true))->toBe(PHP_BINARY);
+    expect($phpStorm->getPhpPath(false))->toBe(PHP_BINARY);
+
+    $artisanPath = $phpStorm->getArtisanPath(true);
+    expect($artisanPath)->toEndWith('artisan')
+        ->and($artisanPath)->not()->toBe('artisan');
+
+    expect($phpStorm->getArtisanPath(false))->toBe($artisanPath);
+});

tests/Unit/Install/CodeEnvironment/CodeEnvironmentTest.php

@@ -409,3 +409,13 @@ public function mcpConfigPath(): string
         ->and($capturedPath)->toBe($vscode->mcpConfigPath())
         ->and($capturedContent)->toBe(fixture('mcp-expected.json5'));
 });
+
+test('getPhpPath uses absolute paths when forceAbsolutePath is true', function (): void {
+    $environment = new TestCodeEnvironment($this->strategyFactory);
+    expect($environment->getPhpPath(true))->toBe(PHP_BINARY);
+});
+
+test('getPhpPath maintains default behavior when forceAbsolutePath is false', function (): void {
+    $environment = new TestCodeEnvironment($this->strategyFactory);
+    expect($environment->getPhpPath(false))->toBe('php');
+});